aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Gortmaker <paul.gortmaker@windriver.com>2014-02-19 17:46:40 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-28 18:27:10 -0500
commit42d87b184f039e67bf61662258377e7a21403754 (patch)
tree8920103d117122c4ac0363eb64dd53eac896ae51
parentfc945d6eb70ebf29532b94ae309c0d4c6d609c3c (diff)
powerpc: select MEMORY for FSL_IFC to not break existing .config files
commit d2ae2e20fbdde5a65f3a5a153044ab1e5c53f7cc ("driver/memory:Move Freescale IFC driver to a common driver") introduces this build regression into the mpc85xx_defconfig: drivers/built-in.o: In function `fsl_ifc_nand_remove': drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to `fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1147: undefined reference to `fsl_ifc_ctrl_dev' drivers/built-in.o: In function `fsl_ifc_nand_probe': drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to `fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1031: undefined reference to `fsl_ifc_ctrl_dev' drivers/built-in.o: In function `match_bank': drivers/mtd/nand/fsl_ifc_nand.c:1013: undefined reference to `convert_ifc_address' drivers/built-in.o: In function `fsl_ifc_nand_probe': drivers/mtd/nand/fsl_ifc_nand.c:1059: undefined reference to `fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1080: undefined reference to `fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to `fsl_ifc_ctrl_dev' drivers/mtd/nand/fsl_ifc_nand.c:1069: undefined reference to `fsl_ifc_ctrl_dev' make: *** [vmlinux] Error 1 This happens because there is nothing to descend us into the drivers/memory directory in the mpc85xx_defconfig. It wasn't selecting CONFIG_MEMORY. So we never built drivers/memory/fsl_ifc.o and so we have nothing to link the above symbols against. Since the goal of the original commit was to relocate the driver to an arch independent location, it only makes sense to relocate the Kconfig setting there as well. But that alone won't fix the build failure; for that we ensure whoever selects FSL_IFC also selects MEMORY. Cc: Prabhakar Kushwaha <prabhakar@freescale.com> Cc: Scott Wood <scottwood@freescale.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: David Woodhouse <dwmw2@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--arch/powerpc/Kconfig4
-rw-r--r--drivers/memory/Kconfig4
-rw-r--r--drivers/mtd/nand/Kconfig1
3 files changed, 5 insertions, 4 deletions
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 957bf344c0f5..b9fcecc706ab 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -736,10 +736,6 @@ config FSL_LBC
736 controller. Also contains some common code used by 736 controller. Also contains some common code used by
737 drivers for specific local bus peripherals. 737 drivers for specific local bus peripherals.
738 738
739config FSL_IFC
740 bool
741 depends on FSL_SOC
742
743config FSL_GTM 739config FSL_GTM
744 bool 740 bool
745 depends on PPC_83xx || QUICC_ENGINE || CPM2 741 depends on PPC_83xx || QUICC_ENGINE || CPM2
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 29a11db365bc..a3640fe9852f 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -50,4 +50,8 @@ config TEGRA30_MC
50 analysis, especially for IOMMU/SMMU(System Memory Management 50 analysis, especially for IOMMU/SMMU(System Memory Management
51 Unit) module. 51 Unit) module.
52 52
53config FSL_IFC
54 bool
55 depends on FSL_SOC
56
53endif 57endif
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 90ff447bf043..a4bee41ad5cb 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -428,6 +428,7 @@ config MTD_NAND_FSL_IFC
428 tristate "NAND support for Freescale IFC controller" 428 tristate "NAND support for Freescale IFC controller"
429 depends on MTD_NAND && FSL_SOC 429 depends on MTD_NAND && FSL_SOC
430 select FSL_IFC 430 select FSL_IFC
431 select MEMORY
431 help 432 help
432 Various Freescale chips e.g P1010, include a NAND Flash machine 433 Various Freescale chips e.g P1010, include a NAND Flash machine
433 with built-in hardware ECC capabilities. 434 with built-in hardware ECC capabilities.