diff options
author | Christian Borntraeger <borntraeger@de.ibm.com> | 2014-11-21 10:21:56 -0500 |
---|---|---|
committer | Christian Borntraeger <borntraeger@de.ibm.com> | 2014-12-18 03:54:39 -0500 |
commit | 4218091cb45f601b889cd032e39fe6878a426e70 (patch) | |
tree | 36f63ef018f6842f91b2118240cc6a144ef52571 | |
parent | 14cf3d977b80f5e355f8ac7547cf1b9ff9fb3e09 (diff) |
mips/gup: Replace ACCESS_ONCE with READ_ONCE
ACCESS_ONCE does not work reliably on non-scalar types. For
example gcc 4.6 and 4.7 might remove the volatile tag for such
accesses during the SRA (scalar replacement of aggregates) step
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)
Change the gup code to replace ACCESS_ONCE with READ_ONCE.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r-- | arch/mips/mm/gup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/mm/gup.c b/arch/mips/mm/gup.c index 06ce17c2a905..8aa50e3f3fce 100644 --- a/arch/mips/mm/gup.c +++ b/arch/mips/mm/gup.c | |||
@@ -30,7 +30,7 @@ retry: | |||
30 | 30 | ||
31 | return pte; | 31 | return pte; |
32 | #else | 32 | #else |
33 | return ACCESS_ONCE(*ptep); | 33 | return READ_ONCE(*ptep); |
34 | #endif | 34 | #endif |
35 | } | 35 | } |
36 | 36 | ||