diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2013-11-03 00:15:05 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2013-11-03 18:18:47 -0500 |
| commit | 40db23e5337d99fda05ee6cd18034b516f8f123d (patch) | |
| tree | 3620424cec3d8df5ec5455335620e65b37a94909 | |
| parent | f80bbd8b92987f55f26691cd53785c4a54622eb0 (diff) | |
random: make add_timer_randomness() fill the nonblocking pool first
Change add_timer_randomness() so that it directs incoming entropy to
the nonblocking pool first if it hasn't been fully initialized yet.
This matches the strategy we use in add_interrupt_randomness(), which
allows us to push the randomness where we need it the most during when
the system is first booting up, so that get_random_bytes() and
/dev/urandom become safe to use as soon as possible.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| -rw-r--r-- | drivers/char/random.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/char/random.c b/drivers/char/random.c index f126bd2f69fe..62923138e77a 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c | |||
| @@ -761,6 +761,7 @@ static struct timer_rand_state input_timer_state; | |||
| 761 | */ | 761 | */ |
| 762 | static void add_timer_randomness(struct timer_rand_state *state, unsigned num) | 762 | static void add_timer_randomness(struct timer_rand_state *state, unsigned num) |
| 763 | { | 763 | { |
| 764 | struct entropy_store *r; | ||
| 764 | struct { | 765 | struct { |
| 765 | long jiffies; | 766 | long jiffies; |
| 766 | unsigned cycles; | 767 | unsigned cycles; |
| @@ -773,7 +774,8 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num) | |||
| 773 | sample.jiffies = jiffies; | 774 | sample.jiffies = jiffies; |
| 774 | sample.cycles = random_get_entropy(); | 775 | sample.cycles = random_get_entropy(); |
| 775 | sample.num = num; | 776 | sample.num = num; |
| 776 | mix_pool_bytes(&input_pool, &sample, sizeof(sample), NULL); | 777 | r = nonblocking_pool.initialized ? &input_pool : &nonblocking_pool; |
| 778 | mix_pool_bytes(r, &sample, sizeof(sample), NULL); | ||
| 777 | 779 | ||
| 778 | /* | 780 | /* |
| 779 | * Calculate number of bits of randomness we probably added. | 781 | * Calculate number of bits of randomness we probably added. |
| @@ -807,8 +809,7 @@ static void add_timer_randomness(struct timer_rand_state *state, unsigned num) | |||
| 807 | * Round down by 1 bit on general principles, | 809 | * Round down by 1 bit on general principles, |
| 808 | * and limit entropy entimate to 12 bits. | 810 | * and limit entropy entimate to 12 bits. |
| 809 | */ | 811 | */ |
| 810 | credit_entropy_bits(&input_pool, | 812 | credit_entropy_bits(r, min_t(int, fls(delta>>1), 11)); |
| 811 | min_t(int, fls(delta>>1), 11)); | ||
| 812 | } | 813 | } |
| 813 | preempt_enable(); | 814 | preempt_enable(); |
| 814 | } | 815 | } |
