diff options
author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-10-24 11:01:25 -0400 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2014-10-27 20:44:00 -0400 |
commit | 3f7256fe5fc64132a2dd19695255c990aa2188cf (patch) | |
tree | 84824900cca453dfe843703ec76cb481a62c3b44 | |
parent | a7339126fdc6d94bc9deba0eaa751622c37b3948 (diff) |
ASoC: sgtl5000: Use the preferred form for passing a size of a struct
According to Documentation/CodingStyle - Chapter 14:
"The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."
So do it as recommeded.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | sound/soc/codecs/sgtl5000.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 59336f6aba80..490404c6b4d8 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c | |||
@@ -1439,8 +1439,7 @@ static int sgtl5000_i2c_probe(struct i2c_client *client, | |||
1439 | struct device_node *np = client->dev.of_node; | 1439 | struct device_node *np = client->dev.of_node; |
1440 | u32 value; | 1440 | u32 value; |
1441 | 1441 | ||
1442 | sgtl5000 = devm_kzalloc(&client->dev, sizeof(struct sgtl5000_priv), | 1442 | sgtl5000 = devm_kzalloc(&client->dev, sizeof(*sgtl5000), GFP_KERNEL); |
1443 | GFP_KERNEL); | ||
1444 | if (!sgtl5000) | 1443 | if (!sgtl5000) |
1445 | return -ENOMEM; | 1444 | return -ENOMEM; |
1446 | 1445 | ||