diff options
| author | Adrian Bunk <bunk@stusta.de> | 2005-07-01 08:07:37 -0400 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2005-07-01 08:07:37 -0400 |
| commit | 3eee0d03e33b0294eb3165c96f213a8c8ee461a8 (patch) | |
| tree | 712eb8b7065683ea4fe5ba362116401bee3a96a3 | |
| parent | 6e6293dd3d4372c114674266158053d049366a0d (diff) | |
[PATCH] MMC: wbsd cleanups
This patch contains the following possible cleanups:
- make some needlessly global code static
- remove the unneeded global function DBG_REG
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
| -rw-r--r-- | drivers/mmc/wbsd.c | 29 | ||||
| -rw-r--r-- | drivers/mmc/wbsd.h | 7 |
2 files changed, 7 insertions, 29 deletions
diff --git a/drivers/mmc/wbsd.c b/drivers/mmc/wbsd.c index 0bd9b53fa898..0c41d4b41a65 100644 --- a/drivers/mmc/wbsd.c +++ b/drivers/mmc/wbsd.c | |||
| @@ -54,28 +54,6 @@ | |||
| 54 | #define DBGF(x...) do { } while (0) | 54 | #define DBGF(x...) do { } while (0) |
| 55 | #endif | 55 | #endif |
| 56 | 56 | ||
| 57 | #ifdef CONFIG_MMC_DEBUG | ||
| 58 | void DBG_REG(int reg, u8 value) | ||
| 59 | { | ||
| 60 | int i; | ||
| 61 | |||
| 62 | printk(KERN_DEBUG "wbsd: Register %d: 0x%02X %3d '%c' ", | ||
| 63 | reg, (int)value, (int)value, (value < 0x20)?'.':value); | ||
| 64 | |||
| 65 | for (i = 7;i >= 0;i--) | ||
| 66 | { | ||
| 67 | if (value & (1 << i)) | ||
| 68 | printk("x"); | ||
| 69 | else | ||
| 70 | printk("."); | ||
| 71 | } | ||
| 72 | |||
| 73 | printk("\n"); | ||
| 74 | } | ||
| 75 | #else | ||
| 76 | #define DBG_REG(r, v) do {} while (0) | ||
| 77 | #endif | ||
| 78 | |||
| 79 | /* | 57 | /* |
| 80 | * Device resources | 58 | * Device resources |
| 81 | */ | 59 | */ |
| @@ -92,6 +70,13 @@ MODULE_DEVICE_TABLE(pnp, pnp_dev_table); | |||
| 92 | 70 | ||
| 93 | #endif /* CONFIG_PNP */ | 71 | #endif /* CONFIG_PNP */ |
| 94 | 72 | ||
| 73 | static const int config_ports[] = { 0x2E, 0x4E }; | ||
| 74 | static const int unlock_codes[] = { 0x83, 0x87 }; | ||
| 75 | |||
| 76 | static const int valid_ids[] = { | ||
| 77 | 0x7112, | ||
| 78 | }; | ||
| 79 | |||
| 95 | #ifdef CONFIG_PNP | 80 | #ifdef CONFIG_PNP |
| 96 | static unsigned int nopnp = 0; | 81 | static unsigned int nopnp = 0; |
| 97 | #else | 82 | #else |
diff --git a/drivers/mmc/wbsd.h b/drivers/mmc/wbsd.h index 9f5383e6e593..661a9f6a6e6f 100644 --- a/drivers/mmc/wbsd.h +++ b/drivers/mmc/wbsd.h | |||
| @@ -8,13 +8,6 @@ | |||
| 8 | * published by the Free Software Foundation. | 8 | * published by the Free Software Foundation. |
| 9 | */ | 9 | */ |
| 10 | 10 | ||
| 11 | const int config_ports[] = { 0x2E, 0x4E }; | ||
| 12 | const int unlock_codes[] = { 0x83, 0x87 }; | ||
| 13 | |||
| 14 | const int valid_ids[] = { | ||
| 15 | 0x7112, | ||
| 16 | }; | ||
| 17 | |||
| 18 | #define LOCK_CODE 0xAA | 11 | #define LOCK_CODE 0xAA |
| 19 | 12 | ||
| 20 | #define WBSD_CONF_SWRST 0x02 | 13 | #define WBSD_CONF_SWRST 0x02 |
