aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohan Hovold <jhovold@gmail.com>2012-10-25 07:35:10 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-25 12:38:06 -0400
commit3eb55cc4ed88eee3b5230f66abcdbd2a91639eda (patch)
tree55a155a9518a46aaf23cf722b859ddfd76b18662
parent65a4cdbb170e4ec1a7fa0e94936d47e24a17b0e8 (diff)
USB: mos7840: fix port-device leak in error path
The driver set the usb-serial port pointers to NULL on errors in attach, effectively preventing usb-serial core from decrementing the port ref counters and releasing the port devices and associated data. Cc: <stable@vger.kernel.org> Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/serial/mos7840.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 35ad3f5c4c0e..c5e5a6c8d69e 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2587,7 +2587,6 @@ error:
2587 kfree(mos7840_port->ctrl_buf); 2587 kfree(mos7840_port->ctrl_buf);
2588 usb_free_urb(mos7840_port->control_urb); 2588 usb_free_urb(mos7840_port->control_urb);
2589 kfree(mos7840_port); 2589 kfree(mos7840_port);
2590 serial->port[i] = NULL;
2591 } 2590 }
2592 return status; 2591 return status;
2593} 2592}