aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLuciano Coelho <luciano.coelho@intel.com>2014-07-05 04:43:01 -0400
committerJohannes Berg <johannes.berg@intel.com>2014-07-21 06:21:26 -0400
commit3e2a0226c624066943259eaa5e1261da9d8a25fc (patch)
treede0782a3812fb1f28be7edd2e69ece08f4c419b1
parentbb3f848608f070a6e3f6c477ba7ff46cf1fb0f02 (diff)
mac80211: remove redundant IEEE80211_STA_CSA_RECEIVED flag
The csa_active flag was added in sdata a while ago and made IEEE80211_STA_CSA_RECEIVED redundant. The new flag is also used to mark when CSA is ongoing on other iftypes and took over the old one as the preferred method for checking whether we're in the middle of a channel switch. Remove the old, redundant flag. Signed-off-by: Luciano Coelho <luciano.coelho@intel.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--net/mac80211/ieee80211_i.h1
-rw-r--r--net/mac80211/mlme.c8
2 files changed, 1 insertions, 8 deletions
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 0d8539caebca..49731dd044bb 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -345,7 +345,6 @@ enum ieee80211_sta_flags {
345 IEEE80211_STA_CONNECTION_POLL = BIT(1), 345 IEEE80211_STA_CONNECTION_POLL = BIT(1),
346 IEEE80211_STA_CONTROL_PORT = BIT(2), 346 IEEE80211_STA_CONTROL_PORT = BIT(2),
347 IEEE80211_STA_DISABLE_HT = BIT(4), 347 IEEE80211_STA_DISABLE_HT = BIT(4),
348 IEEE80211_STA_CSA_RECEIVED = BIT(5),
349 IEEE80211_STA_MFP_ENABLED = BIT(6), 348 IEEE80211_STA_MFP_ENABLED = BIT(6),
350 IEEE80211_STA_UAPSD_ENABLED = BIT(7), 349 IEEE80211_STA_UAPSD_ENABLED = BIT(7),
351 IEEE80211_STA_NULLFUNC_ACKED = BIT(8), 350 IEEE80211_STA_NULLFUNC_ACKED = BIT(8),
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index fcc074871d51..31a8afaf7332 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -996,8 +996,6 @@ static void ieee80211_chswitch_work(struct work_struct *work)
996 sdata->csa_block_tx = false; 996 sdata->csa_block_tx = false;
997 } 997 }
998 998
999 ifmgd->flags &= ~IEEE80211_STA_CSA_RECEIVED;
1000
1001 ieee80211_sta_reset_beacon_monitor(sdata); 999 ieee80211_sta_reset_beacon_monitor(sdata);
1002 ieee80211_sta_reset_conn_monitor(sdata); 1000 ieee80211_sta_reset_conn_monitor(sdata);
1003 1001
@@ -1055,7 +1053,7 @@ ieee80211_sta_process_chanswitch(struct ieee80211_sub_if_data *sdata,
1055 return; 1053 return;
1056 1054
1057 /* disregard subsequent announcements if we are already processing */ 1055 /* disregard subsequent announcements if we are already processing */
1058 if (ifmgd->flags & IEEE80211_STA_CSA_RECEIVED) 1056 if (sdata->vif.csa_active)
1059 return; 1057 return;
1060 1058
1061 current_band = cbss->channel->band; 1059 current_band = cbss->channel->band;
@@ -1082,8 +1080,6 @@ ieee80211_sta_process_chanswitch(struct ieee80211_sub_if_data *sdata,
1082 return; 1080 return;
1083 } 1081 }
1084 1082
1085 ifmgd->flags |= IEEE80211_STA_CSA_RECEIVED;
1086
1087 mutex_lock(&local->mtx); 1083 mutex_lock(&local->mtx);
1088 mutex_lock(&local->chanctx_mtx); 1084 mutex_lock(&local->chanctx_mtx);
1089 conf = rcu_dereference_protected(sdata->vif.chanctx_conf, 1085 conf = rcu_dereference_protected(sdata->vif.chanctx_conf,
@@ -2099,8 +2095,6 @@ static void __ieee80211_disconnect(struct ieee80211_sub_if_data *sdata)
2099 ieee80211_set_disassoc(sdata, IEEE80211_STYPE_DEAUTH, 2095 ieee80211_set_disassoc(sdata, IEEE80211_STYPE_DEAUTH,
2100 WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY, 2096 WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY,
2101 true, frame_buf); 2097 true, frame_buf);
2102 ifmgd->flags &= ~IEEE80211_STA_CSA_RECEIVED;
2103
2104 mutex_lock(&local->mtx); 2098 mutex_lock(&local->mtx);
2105 sdata->vif.csa_active = false; 2099 sdata->vif.csa_active = false;
2106 if (sdata->csa_block_tx) { 2100 if (sdata->csa_block_tx) {