diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-24 17:55:20 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-24 17:55:20 -0400 |
| commit | 3d8bbe243dc7418b4b2eadcbf5693887d076a521 (patch) | |
| tree | 80cb6e131441ded36bbbdd82ce2e9c526eaafb45 | |
| parent | bc465aa9d045feb0e13b4a8f32cc33c1943f62d6 (diff) | |
| parent | c1b03ab5e886760bdd38c9c7a27af149046ffe01 (diff) | |
Merge tag 'iio-fixes-for-4.0c' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus
Jonathan writes:
3rd set of IIO fixes for the 4.0 cycle.
* A double free occured on an error path in due to an event registration issue.
The fix is the minimal change rather than possibly reworking this area of
the core to give a more elegant solution (future work).
* A number of drivers were directly accessing indio_dev->buffer->scan_mask
to identify the currently enabled channel set. This may not be correct
if we have additional clients on the push interface. The correct option
is indio_dev->active_scan_mask. This is fixed.
* bmc150 had incorrectly specified sampling frequency (a datasheet confusion
as they are specified in terms of bandwith - e.g. half the sampling
frequency).
* hmc5843 wasn't setting it's name and hence the name attribute was
returning an empty string.
* inv_mpu6050 wasn't clearing the locally held timestamp buffer when the
hardware fifo was reset. Also an inconsistency existed in the interface
for the scale of the channels. Magic numbers were written but real ones
were used for the reads. Now uses real numbers (i.e. not array indexes)
for both.
* fix a missing dependency in the dummy driver. Previously shielded from
the autobuilders by an earlier build error.
| -rw-r--r-- | drivers/iio/accel/bma180.c | 2 | ||||
| -rw-r--r-- | drivers/iio/accel/bmc150-accel.c | 20 | ||||
| -rw-r--r-- | drivers/iio/accel/kxcjk-1013.c | 2 | ||||
| -rw-r--r-- | drivers/iio/adc/at91_adc.c | 5 | ||||
| -rw-r--r-- | drivers/iio/adc/ti_am335x_adc.c | 3 | ||||
| -rw-r--r-- | drivers/iio/gyro/bmg160.c | 2 | ||||
| -rw-r--r-- | drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 56 | ||||
| -rw-r--r-- | drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 25 | ||||
| -rw-r--r-- | drivers/iio/imu/kmx61.c | 2 | ||||
| -rw-r--r-- | drivers/iio/industrialio-core.c | 5 | ||||
| -rw-r--r-- | drivers/iio/industrialio-event.c | 1 | ||||
| -rw-r--r-- | drivers/iio/proximity/sx9500.c | 2 | ||||
| -rw-r--r-- | drivers/staging/iio/Kconfig | 1 | ||||
| -rw-r--r-- | drivers/staging/iio/magnetometer/hmc5843_core.c | 1 |
14 files changed, 68 insertions, 59 deletions
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c index 1096da327130..75c6d2103e07 100644 --- a/drivers/iio/accel/bma180.c +++ b/drivers/iio/accel/bma180.c | |||
| @@ -659,7 +659,7 @@ static irqreturn_t bma180_trigger_handler(int irq, void *p) | |||
| 659 | 659 | ||
| 660 | mutex_lock(&data->mutex); | 660 | mutex_lock(&data->mutex); |
| 661 | 661 | ||
| 662 | for_each_set_bit(bit, indio_dev->buffer->scan_mask, | 662 | for_each_set_bit(bit, indio_dev->active_scan_mask, |
| 663 | indio_dev->masklength) { | 663 | indio_dev->masklength) { |
| 664 | ret = bma180_get_data_reg(data, bit); | 664 | ret = bma180_get_data_reg(data, bit); |
| 665 | if (ret < 0) { | 665 | if (ret < 0) { |
diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c index 066d0c04072c..75567fd457dc 100644 --- a/drivers/iio/accel/bmc150-accel.c +++ b/drivers/iio/accel/bmc150-accel.c | |||
| @@ -168,14 +168,14 @@ static const struct { | |||
| 168 | int val; | 168 | int val; |
| 169 | int val2; | 169 | int val2; |
| 170 | u8 bw_bits; | 170 | u8 bw_bits; |
| 171 | } bmc150_accel_samp_freq_table[] = { {7, 810000, 0x08}, | 171 | } bmc150_accel_samp_freq_table[] = { {15, 620000, 0x08}, |
| 172 | {15, 630000, 0x09}, | 172 | {31, 260000, 0x09}, |
| 173 | {31, 250000, 0x0A}, | 173 | {62, 500000, 0x0A}, |
| 174 | {62, 500000, 0x0B}, | 174 | {125, 0, 0x0B}, |
| 175 | {125, 0, 0x0C}, | 175 | {250, 0, 0x0C}, |
| 176 | {250, 0, 0x0D}, | 176 | {500, 0, 0x0D}, |
| 177 | {500, 0, 0x0E}, | 177 | {1000, 0, 0x0E}, |
| 178 | {1000, 0, 0x0F} }; | 178 | {2000, 0, 0x0F} }; |
| 179 | 179 | ||
| 180 | static const struct { | 180 | static const struct { |
| 181 | int bw_bits; | 181 | int bw_bits; |
| @@ -840,7 +840,7 @@ static int bmc150_accel_validate_trigger(struct iio_dev *indio_dev, | |||
| 840 | } | 840 | } |
| 841 | 841 | ||
| 842 | static IIO_CONST_ATTR_SAMP_FREQ_AVAIL( | 842 | static IIO_CONST_ATTR_SAMP_FREQ_AVAIL( |
| 843 | "7.810000 15.630000 31.250000 62.500000 125 250 500 1000"); | 843 | "15.620000 31.260000 62.50000 125 250 500 1000 2000"); |
| 844 | 844 | ||
| 845 | static struct attribute *bmc150_accel_attributes[] = { | 845 | static struct attribute *bmc150_accel_attributes[] = { |
| 846 | &iio_const_attr_sampling_frequency_available.dev_attr.attr, | 846 | &iio_const_attr_sampling_frequency_available.dev_attr.attr, |
| @@ -986,7 +986,7 @@ static irqreturn_t bmc150_accel_trigger_handler(int irq, void *p) | |||
| 986 | int bit, ret, i = 0; | 986 | int bit, ret, i = 0; |
| 987 | 987 | ||
| 988 | mutex_lock(&data->mutex); | 988 | mutex_lock(&data->mutex); |
| 989 | for_each_set_bit(bit, indio_dev->buffer->scan_mask, | 989 | for_each_set_bit(bit, indio_dev->active_scan_mask, |
| 990 | indio_dev->masklength) { | 990 | indio_dev->masklength) { |
| 991 | ret = i2c_smbus_read_word_data(data->client, | 991 | ret = i2c_smbus_read_word_data(data->client, |
| 992 | BMC150_ACCEL_AXIS_TO_REG(bit)); | 992 | BMC150_ACCEL_AXIS_TO_REG(bit)); |
diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index 567de269cc00..1a6379525fa4 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c | |||
| @@ -956,7 +956,7 @@ static irqreturn_t kxcjk1013_trigger_handler(int irq, void *p) | |||
| 956 | 956 | ||
| 957 | mutex_lock(&data->mutex); | 957 | mutex_lock(&data->mutex); |
| 958 | 958 | ||
| 959 | for_each_set_bit(bit, indio_dev->buffer->scan_mask, | 959 | for_each_set_bit(bit, indio_dev->active_scan_mask, |
| 960 | indio_dev->masklength) { | 960 | indio_dev->masklength) { |
| 961 | ret = kxcjk1013_get_acc_reg(data, bit); | 961 | ret = kxcjk1013_get_acc_reg(data, bit); |
| 962 | if (ret < 0) { | 962 | if (ret < 0) { |
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index ff61ae55dd3f..8a0eb4a04fb5 100644 --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c | |||
| @@ -544,7 +544,6 @@ static int at91_adc_configure_trigger(struct iio_trigger *trig, bool state) | |||
| 544 | { | 544 | { |
| 545 | struct iio_dev *idev = iio_trigger_get_drvdata(trig); | 545 | struct iio_dev *idev = iio_trigger_get_drvdata(trig); |
| 546 | struct at91_adc_state *st = iio_priv(idev); | 546 | struct at91_adc_state *st = iio_priv(idev); |
| 547 | struct iio_buffer *buffer = idev->buffer; | ||
| 548 | struct at91_adc_reg_desc *reg = st->registers; | 547 | struct at91_adc_reg_desc *reg = st->registers; |
| 549 | u32 status = at91_adc_readl(st, reg->trigger_register); | 548 | u32 status = at91_adc_readl(st, reg->trigger_register); |
| 550 | int value; | 549 | int value; |
| @@ -564,7 +563,7 @@ static int at91_adc_configure_trigger(struct iio_trigger *trig, bool state) | |||
| 564 | at91_adc_writel(st, reg->trigger_register, | 563 | at91_adc_writel(st, reg->trigger_register, |
| 565 | status | value); | 564 | status | value); |
| 566 | 565 | ||
| 567 | for_each_set_bit(bit, buffer->scan_mask, | 566 | for_each_set_bit(bit, idev->active_scan_mask, |
| 568 | st->num_channels) { | 567 | st->num_channels) { |
| 569 | struct iio_chan_spec const *chan = idev->channels + bit; | 568 | struct iio_chan_spec const *chan = idev->channels + bit; |
| 570 | at91_adc_writel(st, AT91_ADC_CHER, | 569 | at91_adc_writel(st, AT91_ADC_CHER, |
| @@ -579,7 +578,7 @@ static int at91_adc_configure_trigger(struct iio_trigger *trig, bool state) | |||
| 579 | at91_adc_writel(st, reg->trigger_register, | 578 | at91_adc_writel(st, reg->trigger_register, |
| 580 | status & ~value); | 579 | status & ~value); |
| 581 | 580 | ||
| 582 | for_each_set_bit(bit, buffer->scan_mask, | 581 | for_each_set_bit(bit, idev->active_scan_mask, |
| 583 | st->num_channels) { | 582 | st->num_channels) { |
| 584 | struct iio_chan_spec const *chan = idev->channels + bit; | 583 | struct iio_chan_spec const *chan = idev->channels + bit; |
| 585 | at91_adc_writel(st, AT91_ADC_CHDR, | 584 | at91_adc_writel(st, AT91_ADC_CHDR, |
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 2e5cc4409f78..a0e7161f040c 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c | |||
| @@ -188,12 +188,11 @@ static int tiadc_buffer_preenable(struct iio_dev *indio_dev) | |||
| 188 | static int tiadc_buffer_postenable(struct iio_dev *indio_dev) | 188 | static int tiadc_buffer_postenable(struct iio_dev *indio_dev) |
| 189 | { | 189 | { |
| 190 | struct tiadc_device *adc_dev = iio_priv(indio_dev); | 190 | struct tiadc_device *adc_dev = iio_priv(indio_dev); |
| 191 | struct iio_buffer *buffer = indio_dev->buffer; | ||
| 192 | unsigned int enb = 0; | 191 | unsigned int enb = 0; |
| 193 | u8 bit; | 192 | u8 bit; |
| 194 | 193 | ||
| 195 | tiadc_step_config(indio_dev); | 194 | tiadc_step_config(indio_dev); |
| 196 | for_each_set_bit(bit, buffer->scan_mask, adc_dev->channels) | 195 | for_each_set_bit(bit, indio_dev->active_scan_mask, adc_dev->channels) |
| 197 | enb |= (get_adc_step_bit(adc_dev, bit) << 1); | 196 | enb |= (get_adc_step_bit(adc_dev, bit) << 1); |
| 198 | adc_dev->buffer_en_ch_steps = enb; | 197 | adc_dev->buffer_en_ch_steps = enb; |
| 199 | 198 | ||
diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c index 60451b328242..ccf3ea7e1afa 100644 --- a/drivers/iio/gyro/bmg160.c +++ b/drivers/iio/gyro/bmg160.c | |||
| @@ -822,7 +822,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p) | |||
| 822 | int bit, ret, i = 0; | 822 | int bit, ret, i = 0; |
| 823 | 823 | ||
| 824 | mutex_lock(&data->mutex); | 824 | mutex_lock(&data->mutex); |
| 825 | for_each_set_bit(bit, indio_dev->buffer->scan_mask, | 825 | for_each_set_bit(bit, indio_dev->active_scan_mask, |
| 826 | indio_dev->masklength) { | 826 | indio_dev->masklength) { |
| 827 | ret = i2c_smbus_read_word_data(data->client, | 827 | ret = i2c_smbus_read_word_data(data->client, |
| 828 | BMG160_AXIS_TO_REG(bit)); | 828 | BMG160_AXIS_TO_REG(bit)); |
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index d8d5bed65e07..ef76afe2643c 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | |||
| @@ -410,42 +410,46 @@ error_read_raw: | |||
| 410 | } | 410 | } |
| 411 | } | 411 | } |
| 412 | 412 | ||
| 413 | static int inv_mpu6050_write_fsr(struct inv_mpu6050_state *st, int fsr) | 413 | static int inv_mpu6050_write_gyro_scale(struct inv_mpu6050_state *st, int val) |
| 414 | { | 414 | { |
| 415 | int result; | ||
