diff options
| author | Len Brown <len.brown@intel.com> | 2012-07-26 19:40:08 -0400 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2012-07-30 21:10:16 -0400 |
| commit | 3b6961ba8c682cc71e51079017743c1b282fd259 (patch) | |
| tree | 5c8cafe80b6cc8f6358046a402f815624df324dc | |
| parent | ec033d0a02901551346b9f43f8ff9bad51378891 (diff) | |
ACPI/x86: revert 'x86, acpi: Call acpi_enter_sleep_state via an asmlinkage C function from assembler'
cd74257b974d6d26442c97891c4d05772748b177
patched up GTS/BFS -- a feature we want to remove.
So revert it (by hand, due to conflict in sleep.h)
to prepare for GTS/BFS removal.
Signed-off-by: Len Brown <len.brown@intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
| -rw-r--r-- | arch/x86/kernel/acpi/sleep.c | 4 | ||||
| -rw-r--r-- | arch/x86/kernel/acpi/sleep.h | 2 | ||||
| -rw-r--r-- | arch/x86/kernel/acpi/wakeup_32.S | 4 | ||||
| -rw-r--r-- | arch/x86/kernel/acpi/wakeup_64.S | 4 |
4 files changed, 6 insertions, 8 deletions
diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c index 95bf99de9058..1b8e5a03d942 100644 --- a/arch/x86/kernel/acpi/sleep.c +++ b/arch/x86/kernel/acpi/sleep.c | |||
| @@ -25,10 +25,6 @@ unsigned long acpi_realmode_flags; | |||
| 25 | static char temp_stack[4096]; | 25 | static char temp_stack[4096]; |
| 26 | #endif | 26 | #endif |
| 27 | 27 | ||
| 28 | asmlinkage void acpi_enter_s3(void) | ||
| 29 | { | ||
| 30 | acpi_enter_sleep_state(3, wake_sleep_flags); | ||
| 31 | } | ||
| 32 | /** | 28 | /** |
| 33 | * acpi_suspend_lowlevel - save kernel state | 29 | * acpi_suspend_lowlevel - save kernel state |
| 34 | * | 30 | * |
diff --git a/arch/x86/kernel/acpi/sleep.h b/arch/x86/kernel/acpi/sleep.h index 5653a5791ec9..67f59f8c6956 100644 --- a/arch/x86/kernel/acpi/sleep.h +++ b/arch/x86/kernel/acpi/sleep.h | |||
| @@ -2,7 +2,6 @@ | |||
| 2 | * Variables and functions used by the code in sleep.c | 2 | * Variables and functions used by the code in sleep.c |
| 3 | */ | 3 | */ |
| 4 | 4 | ||
| 5 | #include <linux/linkage.h> | ||
| 6 | #include <asm/realmode.h> | 5 | #include <asm/realmode.h> |
| 7 | 6 | ||
| 8 | extern unsigned long saved_video_mode; | 7 | extern unsigned long saved_video_mode; |
| @@ -11,7 +10,6 @@ extern long saved_magic; | |||
| 11 | extern int wakeup_pmode_return; | 10 | extern int wakeup_pmode_return; |
| 12 | 11 | ||
| 13 | extern u8 wake_sleep_flags; | 12 | extern u8 wake_sleep_flags; |
| 14 | extern asmlinkage void acpi_enter_s3(void); | ||
| 15 | 13 | ||
| 16 | extern unsigned long acpi_copy_wakeup_routine(unsigned long); | 14 | extern unsigned long acpi_copy_wakeup_routine(unsigned long); |
| 17 | extern void wakeup_long64(void); | 15 | extern void wakeup_long64(void); |
diff --git a/arch/x86/kernel/acpi/wakeup_32.S b/arch/x86/kernel/acpi/wakeup_32.S index 72610839f03b..13ab720573e3 100644 --- a/arch/x86/kernel/acpi/wakeup_32.S +++ b/arch/x86/kernel/acpi/wakeup_32.S | |||
| @@ -74,7 +74,9 @@ restore_registers: | |||
| 74 | ENTRY(do_suspend_lowlevel) | 74 | ENTRY(do_suspend_lowlevel) |
| 75 | call save_processor_state | 75 | call save_processor_state |
| 76 | call save_registers | 76 | call save_registers |
| 77 | call acpi_enter_s3 | 77 | pushl $3 |
| 78 | call acpi_enter_sleep_state | ||
| 79 | addl $4, %esp | ||
| 78 | 80 | ||
| 79 | # In case of S3 failure, we'll emerge here. Jump | 81 | # In case of S3 failure, we'll emerge here. Jump |
| 80 | # to ret_point to recover | 82 | # to ret_point to recover |
diff --git a/arch/x86/kernel/acpi/wakeup_64.S b/arch/x86/kernel/acpi/wakeup_64.S index 014d1d28c397..8ea5164cbd04 100644 --- a/arch/x86/kernel/acpi/wakeup_64.S +++ b/arch/x86/kernel/acpi/wakeup_64.S | |||
| @@ -71,7 +71,9 @@ ENTRY(do_suspend_lowlevel) | |||
| 71 | movq %rsi, saved_rsi | 71 | movq %rsi, saved_rsi |
| 72 | 72 | ||
| 73 | addq $8, %rsp | 73 | addq $8, %rsp |
| 74 | call acpi_enter_s3 | 74 | movl $3, %edi |
| 75 | xorl %eax, %eax | ||
| 76 | call acpi_enter_sleep_state | ||
| 75 | /* in case something went wrong, restore the machine status and go on */ | 77 | /* in case something went wrong, restore the machine status and go on */ |
| 76 | jmp resume_point | 78 | jmp resume_point |
| 77 | 79 | ||
