diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2015-03-13 02:21:41 -0400 |
---|---|---|
committer | Michal Marek <mmarek@suse.cz> | 2015-03-24 11:48:44 -0400 |
commit | 3a975b8cfcbe026b535f83bde9a3c009bae214f9 (patch) | |
tree | f15341a6f0f32da859fa202ecb73fda5194ba65c | |
parent | 371cfd4ff0611d8bc5d18bbb9cc6a2bc3d56cd3d (diff) |
merge_config.sh: improve indentation
It is true that we do not want to move the code too far to the
right, but something like below is not preferred:
if [ "x$PREV_VAL" != "x$NEW_VAL" ] ; then
echo Value of $CFG is redefined by fragment $MERGE_FILE:
echo Previous value: $PREV_VAL
echo New value: $NEW_VAL
echo
elif [ "$WARNREDUN" = "true" ]; then
echo Value of $CFG is redundant by fragment $MERGE_FILE:
fi
To fix this, call "continue" if the "grep" command fails to find the
given CONFIG.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
-rwxr-xr-x | scripts/kconfig/merge_config.sh | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh index 88d89b2986db..56584b107bf8 100755 --- a/scripts/kconfig/merge_config.sh +++ b/scripts/kconfig/merge_config.sh | |||
@@ -103,20 +103,18 @@ for MERGE_FILE in $MERGE_LIST ; do | |||
103 | CFG_LIST=$(sed -n "$SED_CONFIG_EXP" $MERGE_FILE) | 103 | CFG_LIST=$(sed -n "$SED_CONFIG_EXP" $MERGE_FILE) |
104 | 104 | ||
105 | for CFG in $CFG_LIST ; do | 105 | for CFG in $CFG_LIST ; do |
106 | grep -q -w $CFG $TMP_FILE | 106 | grep -q -w $CFG $TMP_FILE || continue |
107 | if [ $? -eq 0 ] ; then | 107 | PREV_VAL=$(grep -w $CFG $TMP_FILE) |
108 | PREV_VAL=$(grep -w $CFG $TMP_FILE) | 108 | NEW_VAL=$(grep -w $CFG $MERGE_FILE) |
109 | NEW_VAL=$(grep -w $CFG $MERGE_FILE) | 109 | if [ "x$PREV_VAL" != "x$NEW_VAL" ] ; then |
110 | if [ "x$PREV_VAL" != "x$NEW_VAL" ] ; then | ||
111 | echo Value of $CFG is redefined by fragment $MERGE_FILE: | 110 | echo Value of $CFG is redefined by fragment $MERGE_FILE: |
112 | echo Previous value: $PREV_VAL | 111 | echo Previous value: $PREV_VAL |
113 | echo New value: $NEW_VAL | 112 | echo New value: $NEW_VAL |
114 | echo | 113 | echo |
115 | elif [ "$WARNREDUN" = "true" ]; then | 114 | elif [ "$WARNREDUN" = "true" ]; then |
116 | echo Value of $CFG is redundant by fragment $MERGE_FILE: | 115 | echo Value of $CFG is redundant by fragment $MERGE_FILE: |
117 | fi | ||
118 | sed -i "/$CFG[ =]/d" $TMP_FILE | ||
119 | fi | 116 | fi |
117 | sed -i "/$CFG[ =]/d" $TMP_FILE | ||
120 | done | 118 | done |
121 | cat $MERGE_FILE >> $TMP_FILE | 119 | cat $MERGE_FILE >> $TMP_FILE |
122 | done | 120 | done |