diff options
author | H Hartley Sweeten <hartleys@visionengravers.com> | 2012-08-16 22:43:55 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-17 11:14:30 -0400 |
commit | 39ffddbb6c6803590f6150eb889975727acb943c (patch) | |
tree | 593335fe97a483655559d3d219bb885564abdf02 | |
parent | 3b96f250ba086109241261337751ade2833ac333 (diff) |
staging: comedi: cb_pcidio: remove thisboard macro
This macro relies on a local variable having a specific name.
Remove it and use the comedi_board() helper to get the pointer.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/comedi/drivers/cb_pcidio.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/drivers/staging/comedi/drivers/cb_pcidio.c b/drivers/staging/comedi/drivers/cb_pcidio.c index e370d0d81bbd..c377bebd41c4 100644 --- a/drivers/staging/comedi/drivers/cb_pcidio.c +++ b/drivers/staging/comedi/drivers/cb_pcidio.c | |||
@@ -85,11 +85,6 @@ static const struct pcidio_board pcidio_boards[] = { | |||
85 | }, | 85 | }, |
86 | }; | 86 | }; |
87 | 87 | ||
88 | /* | ||
89 | * Useful for shorthand access to the particular board structure | ||
90 | */ | ||
91 | #define thisboard ((const struct pcidio_board *)dev->board_ptr) | ||
92 | |||
93 | static struct pci_dev *pcidio_find_pci_dev(struct comedi_device *dev, | 88 | static struct pci_dev *pcidio_find_pci_dev(struct comedi_device *dev, |
94 | struct comedi_devconfig *it) | 89 | struct comedi_devconfig *it) |
95 | { | 90 | { |
@@ -122,6 +117,7 @@ static struct pci_dev *pcidio_find_pci_dev(struct comedi_device *dev, | |||
122 | 117 | ||
123 | static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it) | 118 | static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it) |
124 | { | 119 | { |
120 | const struct pcidio_board *thisboard; | ||
125 | struct pci_dev *pcidev; | 121 | struct pci_dev *pcidev; |
126 | int i; | 122 | int i; |
127 | int ret; | 123 | int ret; |
@@ -130,11 +126,7 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it) | |||
130 | if (!pcidev) | 126 | if (!pcidev) |
131 | return -EIO; | 127 | return -EIO; |
132 | comedi_set_hw_dev(dev, &pcidev->dev); | 128 | comedi_set_hw_dev(dev, &pcidev->dev); |
133 | 129 | thisboard = comedi_board(dev); | |
134 | /* | ||
135 | * Initialize dev->board_name. Note that we can use the "thisboard" | ||
136 | * macro now, since we just initialized it in the last line. | ||
137 | */ | ||
138 | dev->board_name = thisboard->name; | 130 | dev->board_name = thisboard->name; |
139 | 131 | ||
140 | if (comedi_pci_enable(pcidev, thisboard->name)) | 132 | if (comedi_pci_enable(pcidev, thisboard->name)) |
@@ -158,6 +150,7 @@ static int pcidio_attach(struct comedi_device *dev, struct comedi_devconfig *it) | |||
158 | 150 | ||
159 | static void pcidio_detach(struct comedi_device *dev) | 151 | static void pcidio_detach(struct comedi_device *dev) |
160 | { | 152 | { |
153 | const struct pcidio_board *thisboard = comedi_board(dev); | ||
161 | struct pci_dev *pcidev = comedi_to_pci_dev(dev); | 154 | struct pci_dev *pcidev = comedi_to_pci_dev(dev); |
162 | 155 | ||
163 | if (pcidev) { | 156 | if (pcidev) { |