aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2013-02-24 03:55:07 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-03-15 14:45:16 -0400
commit39d35681d5380b403855202dcd75575a8d5b0ec1 (patch)
treee8b8b01bca4af0c9d82d8882e717543db42f6a3b
parent8a7298d361827a1f244415dde62b1b07688d6a3a (diff)
USB: remove incorrect __exit markups
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/host/ehci-mxc.c2
-rw-r--r--drivers/usb/host/ehci-orion.c4
-rw-r--r--drivers/usb/host/ehci-sh.c4
-rw-r--r--drivers/usb/otg/isp1301_omap.c4
-rw-r--r--drivers/usb/otg/twl4030-usb.c4
-rw-r--r--drivers/usb/otg/twl6030-usb.c4
-rw-r--r--drivers/usb/phy/mv_u3d_phy.c2
7 files changed, 12 insertions, 12 deletions
diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index b5b7be45e301..a38c8c8e5b0d 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -172,7 +172,7 @@ err_alloc:
172 return ret; 172 return ret;
173} 173}
174 174
175static int __exit ehci_mxc_drv_remove(struct platform_device *pdev) 175static int ehci_mxc_drv_remove(struct platform_device *pdev)
176{ 176{
177 struct mxc_usbh_platform_data *pdata = pdev->dev.platform_data; 177 struct mxc_usbh_platform_data *pdata = pdev->dev.platform_data;
178 struct usb_hcd *hcd = platform_get_drvdata(pdev); 178 struct usb_hcd *hcd = platform_get_drvdata(pdev);
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index 914a3ecfb5d3..38c45fb3357e 100644
--- a/drivers/usb/host/ehci-orion.c
+++ b/drivers/usb/host/ehci-orion.c
@@ -305,7 +305,7 @@ err1:
305 return err; 305 return err;
306} 306}
307 307
308static int __exit ehci_orion_drv_remove(struct platform_device *pdev) 308static int ehci_orion_drv_remove(struct platform_device *pdev)
309{ 309{
310 struct usb_hcd *hcd = platform_get_drvdata(pdev); 310 struct usb_hcd *hcd = platform_get_drvdata(pdev);
311 struct clk *clk; 311 struct clk *clk;
@@ -333,7 +333,7 @@ MODULE_DEVICE_TABLE(of, ehci_orion_dt_ids);
333 333
334static struct platform_driver ehci_orion_driver = { 334static struct platform_driver ehci_orion_driver = {
335 .probe = ehci_orion_drv_probe, 335 .probe = ehci_orion_drv_probe,
336 .remove = __exit_p(ehci_orion_drv_remove), 336 .remove = ehci_orion_drv_remove,
337 .shutdown = usb_hcd_platform_shutdown, 337 .shutdown = usb_hcd_platform_shutdown,
338 .driver = { 338 .driver = {
339 .name = "orion-ehci", 339 .name = "orion-ehci",
diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c
index 3565a300f401..e30e39672027 100644
--- a/drivers/usb/host/ehci-sh.c
+++ b/drivers/usb/host/ehci-sh.c
@@ -170,7 +170,7 @@ fail_create_hcd:
170 return ret; 170 return ret;
171} 171}
172 172
173static int __exit ehci_hcd_sh_remove(struct platform_device *pdev) 173static int ehci_hcd_sh_remove(struct platform_device *pdev)
174{ 174{
175 struct ehci_sh_priv *priv = platform_get_drvdata(pdev); 175 struct ehci_sh_priv *priv = platform_get_drvdata(pdev);
176 struct usb_hcd *hcd = priv->hcd; 176 struct usb_hcd *hcd = priv->hcd;
@@ -196,7 +196,7 @@ static void ehci_hcd_sh_shutdown(struct platform_device *pdev)
196 196
197static struct platform_driver ehci_hcd_sh_driver = { 197static struct platform_driver ehci_hcd_sh_driver = {
198 .probe = ehci_hcd_sh_probe, 198 .probe = ehci_hcd_sh_probe,
199 .remove = __exit_p(ehci_hcd_sh_remove), 199 .remove = ehci_hcd_sh_remove
200 .shutdown = ehci_hcd_sh_shutdown, 200 .shutdown = ehci_hcd_sh_shutdown,
201 .driver = { 201 .driver = {
202 .name = "sh_ehci", 202 .name = "sh_ehci",
diff --git a/drivers/usb/otg/isp1301_omap.c b/drivers/usb/otg/isp1301_omap.c
index af9cb11626b2..8b9de9581319 100644
--- a/drivers/usb/otg/isp1301_omap.c
+++ b/drivers/usb/otg/isp1301_omap.c
@@ -1212,7 +1212,7 @@ static void isp1301_release(struct device *dev)
1212 1212
1213static struct isp1301 *the_transceiver; 1213static struct isp1301 *the_transceiver;
1214 1214
1215static int __exit isp1301_remove(struct i2c_client *i2c) 1215static int isp1301_remove(struct i2c_client *i2c)
1216{ 1216{
1217 struct isp1301 *isp; 1217 struct isp1301 *isp;
1218 1218
@@ -1634,7 +1634,7 @@ static struct i2c_driver isp1301_driver = {
1634 .name = "isp1301_omap", 1634 .name = "isp1301_omap",
1635 }, 1635 },
1636 .probe = isp1301_probe, 1636 .probe = isp1301_probe,
1637 .remove = __exit_p(isp1301_remove), 1637 .remove = isp1301_remove,
1638 .id_table = isp1301_id, 1638 .id_table = isp1301_id,
1639}; 1639};
1640 1640
diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c
index a994715a3101..24d573a134b1 100644
--- a/drivers/usb/otg/twl4030-usb.c
+++ b/drivers/usb/otg/twl4030-usb.c
@@ -658,7 +658,7 @@ static int twl4030_usb_probe(struct platform_device *pdev)
658 return 0; 658 return 0;
659} 659}
660 660
661static int __exit twl4030_usb_remove(struct platform_device *pdev) 661static int twl4030_usb_remove(struct platform_device *pdev)
662{ 662{
663 struct twl4030_usb *twl = platform_get_drvdata(pdev); 663 struct twl4030_usb *twl = platform_get_drvdata(pdev);
664 int val; 664 int val;
@@ -702,7 +702,7 @@ MODULE_DEVICE_TABLE(of, twl4030_usb_id_table);
702 702
703static struct platform_driver twl4030_usb_driver = { 703static struct platform_driver twl4030_usb_driver = {
704 .probe = twl4030_usb_probe, 704 .probe = twl4030_usb_probe,
705 .remove = __exit_p(twl4030_usb_remove), 705 .remove = twl4030_usb_remove,
706 .driver = { 706 .driver = {
707 .name = "twl4030_usb", 707 .name = "twl4030_usb",
708 .owner = THIS_MODULE, 708 .owner = THIS_MODULE,
diff --git a/drivers/usb/otg/twl6030-usb.c b/drivers/usb/otg/twl6030-usb.c
index 8cd6cf49bdbd..7f3c5b0e3f66 100644
--- a/drivers/usb/otg/twl6030-usb.c
+++ b/drivers/usb/otg/twl6030-usb.c
@@ -393,7 +393,7 @@ static int twl6030_usb_probe(struct platform_device *pdev)
393 return 0; 393 return 0;
394} 394}
395 395
396static int __exit twl6030_usb_remove(struct platform_device *pdev) 396static int twl6030_usb_remove(struct platform_device *pdev)
397{ 397{
398 struct twl6030_usb *twl = platform_get_drvdata(pdev); 398 struct twl6030_usb *twl = platform_get_drvdata(pdev);
399 399
@@ -420,7 +420,7 @@ MODULE_DEVICE_TABLE(of, twl6030_usb_id_table);
420 420
421static struct platform_driver twl6030_usb_driver = { 421static struct platform_driver twl6030_usb_driver = {
422 .probe = twl6030_usb_probe, 422 .probe = twl6030_usb_probe,
423 .remove = __exit_p(twl6030_usb_remove), 423 .remove = twl6030_usb_remove,
424 .driver = { 424 .driver = {
425 .name = "twl6030_usb", 425 .name = "twl6030_usb",
426 .owner = THIS_MODULE, 426 .owner = THIS_MODULE,
diff --git a/drivers/usb/phy/mv_u3d_phy.c b/drivers/usb/phy/mv_u3d_phy.c
index 9d8599122aa9..bafd67f1f134 100644
--- a/drivers/usb/phy/mv_u3d_phy.c
+++ b/drivers/usb/phy/mv_u3d_phy.c
@@ -313,7 +313,7 @@ err:
313 return ret; 313 return ret;
314} 314}
315 315
316static int __exit mv_u3d_phy_remove(struct platform_device *pdev) 316static int mv_u3d_phy_remove(struct platform_device *pdev)
317{ 317{
318 struct mv_u3d_phy *mv_u3d_phy = platform_get_drvdata(pdev); 318 struct mv_u3d_phy *mv_u3d_phy = platform_get_drvdata(pdev);
319 319