aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomasz Figa <t.figa@samsung.com>2013-12-12 11:07:19 -0500
committerMike Turquette <mturquette@linaro.org>2014-01-08 12:57:07 -0500
commit3966c947f45911e093114371462687134d5e8d40 (patch)
treed83e0faef3d02d6fd89aeca672794ac9ad7f3b22
parentd73ac4ca66676d0b0d57a8828d10d479ad054d0c (diff)
clk: max77686: Refactor driver data handling
As a prerequisite for further patch adding OF clock provider support to the driver, this patch changes the driver to store an array of struct clk * as driver data. Signed-off-by: Tomasz Figa <t.figa@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: Mike Turquette <mturquette@linaro.org>
-rw-r--r--drivers/clk/clk-max77686.c27
1 files changed, 14 insertions, 13 deletions
diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
index 4dc1832fe241..3cf38dc66379 100644
--- a/drivers/clk/clk-max77686.c
+++ b/drivers/clk/clk-max77686.c
@@ -137,12 +137,13 @@ static struct clk *max77686_clk_register(struct device *dev,
137static int max77686_clk_probe(struct platform_device *pdev) 137static int max77686_clk_probe(struct platform_device *pdev)
138{ 138{
139 struct max77686_dev *iodev = dev_get_drvdata(pdev->dev.parent); 139 struct max77686_dev *iodev = dev_get_drvdata(pdev->dev.parent);
140 struct max77686_clk **max77686_clks; 140 struct max77686_clk *max77686_clks[MAX77686_CLKS_NUM];
141 struct clk **clocks;
141 int i, ret; 142 int i, ret;
142 143
143 max77686_clks = devm_kzalloc(&pdev->dev, sizeof(struct max77686_clk *) 144 clocks = devm_kzalloc(&pdev->dev, sizeof(struct clk *)
144 * MAX77686_CLKS_NUM, GFP_KERNEL); 145 * MAX77686_CLKS_NUM, GFP_KERNEL);
145 if (!max77686_clks) 146 if (!clocks)
146 return -ENOMEM; 147 return -ENOMEM;
147 148
148 for (i = 0; i < MAX77686_CLKS_NUM; i++) { 149 for (i = 0; i < MAX77686_CLKS_NUM; i++) {
@@ -153,23 +154,20 @@ static int max77686_clk_probe(struct platform_device *pdev)
153 } 154 }
154 155
155 for (i = 0; i < MAX77686_CLKS_NUM; i++) { 156 for (i = 0; i < MAX77686_CLKS_NUM; i++) {
156 struct clk *clk;
157
158 max77686_clks[i]->iodev = iodev; 157 max77686_clks[i]->iodev = iodev;
159 max77686_clks[i]->mask = 1 << i; 158 max77686_clks[i]->mask = 1 << i;
160 max77686_clks[i]->hw.init = &max77686_clks_init[i]; 159 max77686_clks[i]->hw.init = &max77686_clks_init[i];
161 160
162 clk = max77686_clk_register(&pdev->dev, max77686_clks[i]); 161 clocks[i] = max77686_clk_register(&pdev->dev, max77686_clks[i]);
163 if (IS_ERR(clk)) { 162 if (IS_ERR(clocks[i])) {
164 ret = PTR_ERR(clk); 163 ret = PTR_ERR(clocks[i]);
165
166 dev_err(&pdev->dev, "failed to register %s\n", 164 dev_err(&pdev->dev, "failed to register %s\n",
167 max77686_clks[i]->hw.init->name); 165 max77686_clks[i]->hw.init->name);
168 goto err_clocks; 166 goto err_clocks;
169 } 167 }
170 } 168 }
171 169
172 platform_set_drvdata(pdev, max77686_clks); 170 platform_set_drvdata(pdev, clocks);
173 171
174 return 0; 172 return 0;
175 173
@@ -184,12 +182,15 @@ err_clocks:
184 182
185static int max77686_clk_remove(struct platform_device *pdev) 183static int max77686_clk_remove(struct platform_device *pdev)
186{ 184{
187 struct max77686_clk **max77686_clks = platform_get_drvdata(pdev); 185 struct clk **clocks = platform_get_drvdata(pdev);
188 int i; 186 int i;
189 187
190 for (i = 0; i < MAX77686_CLKS_NUM; i++) { 188 for (i = 0; i < MAX77686_CLKS_NUM; i++) {
191 clkdev_drop(max77686_clks[i]->lookup); 189 struct clk_hw *hw = __clk_get_hw(clocks[i]);
192 clk_unregister(max77686_clks[i]->hw.clk); 190 struct max77686_clk *max77686 = to_max77686_clk(hw);
191
192 clkdev_drop(max77686->lookup);
193 clk_unregister(clocks[i]);
193 } 194 }
194 return 0; 195 return 0;
195} 196}