diff options
author | Hans Verkuil <hans.verkuil@cisco.com> | 2013-03-04 07:32:00 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-03-23 10:00:05 -0400 |
commit | 3887056bc4a07b607be2e403b29e8006b465227b (patch) | |
tree | 6c597961db180768cb18da4392cca1bfc78919a8 | |
parent | 8e42bf033e1d2a4ece4050a9c3f6226e60a7bb2f (diff) |
[media] s5p-tv: remove dv_preset support from mixer_video
The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Tested-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/platform/s5p-tv/mixer_video.c | 64 |
1 files changed, 0 insertions, 64 deletions
diff --git a/drivers/media/platform/s5p-tv/mixer_video.c b/drivers/media/platform/s5p-tv/mixer_video.c index 24fb38177c82..9961e13f683d 100644 --- a/drivers/media/platform/s5p-tv/mixer_video.c +++ b/drivers/media/platform/s5p-tv/mixer_video.c | |||
@@ -501,64 +501,6 @@ fail: | |||
501 | return -ERANGE; | 501 | return -ERANGE; |
502 | } | 502 | } |
503 | 503 | ||
504 | static int mxr_enum_dv_presets(struct file *file, void *fh, | ||
505 | struct v4l2_dv_enum_preset *preset) | ||
506 | { | ||
507 | struct mxr_layer *layer = video_drvdata(file); | ||
508 | struct mxr_device *mdev = layer->mdev; | ||
509 | int ret; | ||
510 | |||
511 | /* lock protects from changing sd_out */ | ||
512 | mutex_lock(&mdev->mutex); | ||
513 | ret = v4l2_subdev_call(to_outsd(mdev), video, enum_dv_presets, preset); | ||
514 | mutex_unlock(&mdev->mutex); | ||
515 | |||
516 | return ret ? -EINVAL : 0; | ||
517 | } | ||
518 | |||
519 | static int mxr_s_dv_preset(struct file *file, void *fh, | ||
520 | struct v4l2_dv_preset *preset) | ||
521 | { | ||
522 | struct mxr_layer *layer = video_drvdata(file); | ||
523 | struct mxr_device *mdev = layer->mdev; | ||
524 | int ret; | ||
525 | |||
526 | /* lock protects from changing sd_out */ | ||
527 | mutex_lock(&mdev->mutex); | ||
528 | |||
529 | /* preset change cannot be done while there is an entity | ||
530 | * dependant on output configuration | ||
531 | */ | ||
532 | if (mdev->n_output > 0) { | ||
533 | mutex_unlock(&mdev->mutex); | ||
534 | return -EBUSY; | ||
535 | } | ||
536 | |||
537 | ret = v4l2_subdev_call(to_outsd(mdev), video, s_dv_preset, preset); | ||
538 | |||
539 | mutex_unlock(&mdev->mutex); | ||
540 | |||
541 | mxr_layer_update_output(layer); | ||
542 | |||
543 | /* any failure should return EINVAL according to V4L2 doc */ | ||
544 | return ret ? -EINVAL : 0; | ||
545 | } | ||
546 | |||
547 | static int mxr_g_dv_preset(struct file *file, void *fh, | ||
548 | struct v4l2_dv_preset *preset) | ||
549 | { | ||
550 | struct mxr_layer *layer = video_drvdata(file); | ||
551 | struct mxr_device *mdev = layer->mdev; | ||
552 | int ret; | ||
553 | |||
554 | /* lock protects from changing sd_out */ | ||
555 | mutex_lock(&mdev->mutex); | ||
556 | ret = v4l2_subdev_call(to_outsd(mdev), video, g_dv_preset, preset); | ||
557 | mutex_unlock(&mdev->mutex); | ||
558 | |||
559 | return ret ? -EINVAL : 0; | ||
560 | } | ||
561 | |||
562 | static int mxr_enum_dv_timings(struct file *file, void *fh, | 504 | static int mxr_enum_dv_timings(struct file *file, void *fh, |
563 | struct v4l2_enum_dv_timings *timings) | 505 | struct v4l2_enum_dv_timings *timings) |
564 | { | 506 | { |
@@ -689,8 +631,6 @@ static int mxr_enum_output(struct file *file, void *fh, struct v4l2_output *a) | |||
689 | /* try to obtain supported tv norms */ | 631 | /* try to obtain supported tv norms */ |
690 | v4l2_subdev_call(sd, video, g_tvnorms_output, &a->std); | 632 | v4l2_subdev_call(sd, video, g_tvnorms_output, &a->std); |
691 | a->capabilities = 0; | 633 | a->capabilities = 0; |
692 | if (sd->ops->video && sd->ops->video->s_dv_preset) | ||
693 | a->capabilities |= V4L2_OUT_CAP_PRESETS; | ||
694 | if (sd->ops->video && sd->ops->video->s_dv_timings) | 634 | if (sd->ops->video && sd->ops->video->s_dv_timings) |
695 | a->capabilities |= V4L2_OUT_CAP_DV_TIMINGS; | 635 | a->capabilities |= V4L2_OUT_CAP_DV_TIMINGS; |
696 | if (sd->ops->video && sd->ops->video->s_std_output) | 636 | if (sd->ops->video && sd->ops->video->s_std_output) |
@@ -813,10 +753,6 @@ static const struct v4l2_ioctl_ops mxr_ioctl_ops = { | |||
813 | /* Streaming control */ | 753 | /* Streaming control */ |
814 | .vidioc_streamon = mxr_streamon, | 754 | .vidioc_streamon = mxr_streamon, |
815 | .vidioc_streamoff = mxr_streamoff, | 755 | .vidioc_streamoff = mxr_streamoff, |
816 | /* Preset functions */ | ||
817 | .vidioc_enum_dv_presets = mxr_enum_dv_presets, | ||
818 | .vidioc_s_dv_preset = mxr_s_dv_preset, | ||
819 | .vidioc_g_dv_preset = mxr_g_dv_preset, | ||
820 | /* DV Timings functions */ | 756 | /* DV Timings functions */ |
821 | .vidioc_enum_dv_timings = mxr_enum_dv_timings, | 757 | .vidioc_enum_dv_timings = mxr_enum_dv_timings, |
822 | .vidioc_s_dv_timings = mxr_s_dv_timings, | 758 | .vidioc_s_dv_timings = mxr_s_dv_timings, |