diff options
author | Patrick McHardy <kaber@trash.net> | 2010-02-18 13:04:44 -0500 |
---|---|---|
committer | Patrick McHardy <kaber@trash.net> | 2010-02-18 13:04:44 -0500 |
commit | 37ee3d5b3e979a168536e7e2f15bd1e769cb4122 (patch) | |
tree | aa6abf4c6976e9f5f1904f42d0745578560f871d | |
parent | 2906f66a5682e5670a5eefe991843689b8d8563f (diff) |
netfilter: nf_defrag_ipv4: fix compilation error with NF_CONNTRACK=n
As reported by Randy Dunlap <randy.dunlap@oracle.com>, compilation
of nf_defrag_ipv4 fails with:
include/net/netfilter/nf_conntrack.h:94: error: field 'ct_general' has incomplete type
include/net/netfilter/nf_conntrack.h:178: error: 'const struct sk_buff' has no member named 'nfct'
include/net/netfilter/nf_conntrack.h:185: error: implicit declaration of function 'nf_conntrack_put'
include/net/netfilter/nf_conntrack.h:294: error: 'const struct sk_buff' has no member named 'nfct'
net/ipv4/netfilter/nf_defrag_ipv4.c:45: error: 'struct sk_buff' has no member named 'nfct'
net/ipv4/netfilter/nf_defrag_ipv4.c:46: error: 'struct sk_buff' has no member named 'nfct'
net/nf_conntrack.h must not be included with NF_CONNTRACK=n, add a
few #ifdefs. Long term the header file should be fixed to be usable
even with NF_CONNTRACK=n.
Tested-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
-rw-r--r-- | include/net/netfilter/nf_conntrack_zones.h | 6 | ||||
-rw-r--r-- | net/ipv4/netfilter/nf_defrag_ipv4.c | 6 |
2 files changed, 9 insertions, 3 deletions
diff --git a/include/net/netfilter/nf_conntrack_zones.h b/include/net/netfilter/nf_conntrack_zones.h index 0bbb2bd51e89..034efe8d45a5 100644 --- a/include/net/netfilter/nf_conntrack_zones.h +++ b/include/net/netfilter/nf_conntrack_zones.h | |||
@@ -1,10 +1,11 @@ | |||
1 | #ifndef _NF_CONNTRACK_ZONES_H | 1 | #ifndef _NF_CONNTRACK_ZONES_H |
2 | #define _NF_CONNTRACK_ZONES_H | 2 | #define _NF_CONNTRACK_ZONES_H |
3 | 3 | ||
4 | #include <net/netfilter/nf_conntrack_extend.h> | ||
5 | |||
6 | #define NF_CT_DEFAULT_ZONE 0 | 4 | #define NF_CT_DEFAULT_ZONE 0 |
7 | 5 | ||
6 | #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) | ||
7 | #include <net/netfilter/nf_conntrack_extend.h> | ||
8 | |||
8 | struct nf_conntrack_zone { | 9 | struct nf_conntrack_zone { |
9 | u16 id; | 10 | u16 id; |
10 | }; | 11 | }; |
@@ -20,4 +21,5 @@ static inline u16 nf_ct_zone(const struct nf_conn *ct) | |||
20 | return NF_CT_DEFAULT_ZONE; | 21 | return NF_CT_DEFAULT_ZONE; |
21 | } | 22 | } |
22 | 23 | ||
24 | #endif /* CONFIG_NF_CONNTRACK || CONFIG_NF_CONNTRACK_MODULE */ | ||
23 | #endif /* _NF_CONNTRACK_ZONES_H */ | 25 | #endif /* _NF_CONNTRACK_ZONES_H */ |
diff --git a/net/ipv4/netfilter/nf_defrag_ipv4.c b/net/ipv4/netfilter/nf_defrag_ipv4.c index d498a704d456..cb763ae9ed90 100644 --- a/net/ipv4/netfilter/nf_defrag_ipv4.c +++ b/net/ipv4/netfilter/nf_defrag_ipv4.c | |||
@@ -16,9 +16,11 @@ | |||
16 | 16 | ||
17 | #include <linux/netfilter_bridge.h> | 17 | #include <linux/netfilter_bridge.h> |
18 | #include <linux/netfilter_ipv4.h> | 18 | #include <linux/netfilter_ipv4.h> |
19 | #include <net/netfilter/nf_conntrack_zones.h> | ||
20 | #include <net/netfilter/ipv4/nf_defrag_ipv4.h> | 19 | #include <net/netfilter/ipv4/nf_defrag_ipv4.h> |
20 | #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) | ||
21 | #include <net/netfilter/nf_conntrack.h> | 21 | #include <net/netfilter/nf_conntrack.h> |
22 | #endif | ||
23 | #include <net/netfilter/nf_conntrack_zones.h> | ||
22 | 24 | ||
23 | /* Returns new sk_buff, or NULL */ | 25 | /* Returns new sk_buff, or NULL */ |
24 | static int nf_ct_ipv4_gather_frags(struct sk_buff *skb, u_int32_t user) | 26 | static int nf_ct_ipv4_gather_frags(struct sk_buff *skb, u_int32_t user) |
@@ -42,8 +44,10 @@ static enum ip_defrag_users nf_ct_defrag_user(unsigned int hooknum, | |||
42 | { | 44 | { |
43 | u16 zone = NF_CT_DEFAULT_ZONE; | 45 | u16 zone = NF_CT_DEFAULT_ZONE; |
44 | 46 | ||
47 | #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) | ||
45 | if (skb->nfct) | 48 | if (skb->nfct) |
46 | zone = nf_ct_zone((struct nf_conn *)skb->nfct); | 49 | zone = nf_ct_zone((struct nf_conn *)skb->nfct); |
50 | #endif | ||
47 | 51 | ||
48 | #ifdef CONFIG_BRIDGE_NETFILTER | 52 | #ifdef CONFIG_BRIDGE_NETFILTER |
49 | if (skb->nf_bridge && | 53 | if (skb->nf_bridge && |