diff options
author | David Brown <davidb@codeaurora.org> | 2013-03-12 14:41:53 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-25 13:39:40 -0400 |
commit | 37799ef4fa95ceec09b5c214fb281c6e6acddf5b (patch) | |
tree | 6ad3791689283ea6fb69a47593a680d5e0508a0a | |
parent | 90f2d32ca5ca4a7f6d4eb509b81a9a802eb62905 (diff) |
ssbi: Remove extraneous logging
Remove some unhelpful error logs. This also removes the necessity of
having a pointer back to the struct device within the ssbi-specific
structure
Signed-off-by: David Brown <davidb@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/ssbi/ssbi.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/drivers/ssbi/ssbi.c b/drivers/ssbi/ssbi.c index 6878e550fde6..b056a072c3b3 100644 --- a/drivers/ssbi/ssbi.c +++ b/drivers/ssbi/ssbi.c | |||
@@ -66,7 +66,6 @@ | |||
66 | #define SSBI_TIMEOUT_US 100 | 66 | #define SSBI_TIMEOUT_US 100 |
67 | 67 | ||
68 | struct msm_ssbi { | 68 | struct msm_ssbi { |
69 | struct device *dev; | ||
70 | struct device *slave; | 69 | struct device *slave; |
71 | void __iomem *base; | 70 | void __iomem *base; |
72 | spinlock_t lock; | 71 | spinlock_t lock; |
@@ -108,8 +107,6 @@ static int ssbi_wait_mask(struct msm_ssbi *ssbi, u32 set_mask, u32 clr_mask) | |||
108 | udelay(1); | 107 | udelay(1); |
109 | } | 108 | } |
110 | 109 | ||
111 | dev_err(ssbi->dev, "%s: timeout (status %x set_mask %x clr_mask %x)\n", | ||
112 | __func__, ssbi_readl(ssbi, SSBI2_STATUS), set_mask, clr_mask); | ||
113 | return -ETIMEDOUT; | 110 | return -ETIMEDOUT; |
114 | } | 111 | } |
115 | 112 | ||
@@ -185,11 +182,8 @@ msm_ssbi_pa_transfer(struct msm_ssbi *ssbi, u32 cmd, u8 *data) | |||
185 | while (timeout--) { | 182 | while (timeout--) { |
186 | rd_status = ssbi_readl(ssbi, SSBI_PA_RD_STATUS); | 183 | rd_status = ssbi_readl(ssbi, SSBI_PA_RD_STATUS); |
187 | 184 | ||
188 | if (rd_status & SSBI_PA_RD_STATUS_TRANS_DENIED) { | 185 | if (rd_status & SSBI_PA_RD_STATUS_TRANS_DENIED) |
189 | dev_err(ssbi->dev, "%s: transaction denied (0x%x)\n", | ||
190 | __func__, rd_status); | ||
191 | return -EPERM; | 186 | return -EPERM; |
192 | } | ||
193 | 187 | ||
194 | if (rd_status & SSBI_PA_RD_STATUS_TRANS_DONE) { | 188 | if (rd_status & SSBI_PA_RD_STATUS_TRANS_DONE) { |
195 | if (data) | 189 | if (data) |
@@ -199,7 +193,6 @@ msm_ssbi_pa_transfer(struct msm_ssbi *ssbi, u32 cmd, u8 *data) | |||
199 | udelay(1); | 193 | udelay(1); |
200 | } | 194 | } |
201 | 195 | ||
202 | dev_err(ssbi->dev, "%s: timeout, status 0x%x\n", __func__, rd_status); | ||
203 | return -ETIMEDOUT; | 196 | return -ETIMEDOUT; |
204 | } | 197 | } |
205 | 198 | ||
@@ -248,9 +241,6 @@ int msm_ssbi_read(struct device *dev, u16 addr, u8 *buf, int len) | |||
248 | unsigned long flags; | 241 | unsigned long flags; |
249 | int ret; | 242 | int ret; |
250 | 243 | ||
251 | if (ssbi->dev != dev) | ||
252 | return -ENXIO; | ||
253 | |||
254 | spin_lock_irqsave(&ssbi->lock, flags); | 244 | spin_lock_irqsave(&ssbi->lock, flags); |
255 | ret = ssbi->read(ssbi, addr, buf, len); | 245 | ret = ssbi->read(ssbi, addr, buf, len); |
256 | spin_unlock_irqrestore(&ssbi->lock, flags); | 246 | spin_unlock_irqrestore(&ssbi->lock, flags); |
@@ -265,9 +255,6 @@ int msm_ssbi_write(struct device *dev, u16 addr, u8 *buf, int len) | |||
265 | unsigned long flags; | 255 | unsigned long flags; |
266 | int ret; | 256 | int ret; |
267 | 257 | ||
268 | if (ssbi->dev != dev) | ||
269 | return -ENXIO; | ||
270 | |||
271 | spin_lock_irqsave(&ssbi->lock, flags); | 258 | spin_lock_irqsave(&ssbi->lock, flags); |
272 | ret = ssbi->write(ssbi, addr, buf, len); | 259 | ret = ssbi->write(ssbi, addr, buf, len); |
273 | spin_unlock_irqrestore(&ssbi->lock, flags); | 260 | spin_unlock_irqrestore(&ssbi->lock, flags); |
@@ -303,7 +290,6 @@ static int msm_ssbi_probe(struct platform_device *pdev) | |||
303 | ret = -EINVAL; | 290 | ret = -EINVAL; |
304 | goto err_ioremap; | 291 | goto err_ioremap; |
305 | } | 292 | } |
306 | ssbi->dev = &pdev->dev; | ||
307 | platform_set_drvdata(pdev, ssbi); | 293 | platform_set_drvdata(pdev, ssbi); |
308 | 294 | ||
309 | type = of_get_property(np, "qcom,controller-type", NULL); | 295 | type = of_get_property(np, "qcom,controller-type", NULL); |