diff options
| author | Fabio Estevam <fabio.estevam@freescale.com> | 2014-04-24 21:27:04 -0400 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-04-25 07:17:18 -0400 |
| commit | 3598aad5470deb5eb4f643ef89abb9b172803e76 (patch) | |
| tree | 4d80bbb3b7d0d16dc47f9174dea58441892d1b77 | |
| parent | c9eaa447e77efe77b7fa4c953bd62de8297fd6c5 (diff) | |
ASoC: wm8731: Use devm_regulator_bulk_get()
Using devm_regulator_bulk_get() can make the code cleaner and smaller as we
do not need to call regulator_bulk_free() in the error and remove paths.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
| -rw-r--r-- | sound/soc/codecs/wm8731.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index d74f43975b90..0ac3567253e6 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c | |||
| @@ -586,7 +586,7 @@ static int wm8731_probe(struct snd_soc_codec *codec) | |||
| 586 | for (i = 0; i < ARRAY_SIZE(wm8731->supplies); i++) | 586 | for (i = 0; i < ARRAY_SIZE(wm8731->supplies); i++) |
| 587 | wm8731->supplies[i].supply = wm8731_supply_names[i]; | 587 | wm8731->supplies[i].supply = wm8731_supply_names[i]; |
| 588 | 588 | ||
| 589 | ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies), | 589 | ret = devm_regulator_bulk_get(codec->dev, ARRAY_SIZE(wm8731->supplies), |
| 590 | wm8731->supplies); | 590 | wm8731->supplies); |
| 591 | if (ret != 0) { | 591 | if (ret != 0) { |
| 592 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); | 592 | dev_err(codec->dev, "Failed to request supplies: %d\n", ret); |
| @@ -597,7 +597,7 @@ static int wm8731_probe(struct snd_soc_codec *codec) | |||
| 597 | wm8731->supplies); | 597 | wm8731->supplies); |
| 598 | if (ret != 0) { | 598 | if (ret != 0) { |
| 599 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); | 599 | dev_err(codec->dev, "Failed to enable supplies: %d\n", ret); |
| 600 | goto err_regulator_get; | 600 | return ret; |
| 601 | } | 601 | } |
| 602 | 602 | ||
| 603 | ret = wm8731_reset(codec); | 603 | ret = wm8731_reset(codec); |
| @@ -624,8 +624,6 @@ static int wm8731_probe(struct snd_soc_codec *codec) | |||
| 624 | 624 | ||
| 625 | err_regulator_enable: | 625 | err_regulator_enable: |
| 626 | regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); | 626 | regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); |
| 627 | err_regulator_get: | ||
| 628 | regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); | ||
| 629 | 627 | ||
| 630 | return ret; | 628 | return ret; |
| 631 | } | 629 | } |
| @@ -638,7 +636,6 @@ static int wm8731_remove(struct snd_soc_codec *codec) | |||
| 638 | wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF); | 636 | wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF); |
| 639 | 637 | ||
| 640 | regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); | 638 | regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); |
| 641 | regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies); | ||
| 642 | 639 | ||
| 643 | return 0; | 640 | return 0; |
| 644 | } | 641 | } |
