diff options
author | Seth Jennings <sjenning@redhat.com> | 2014-09-05 15:28:47 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2014-10-08 16:04:16 -0400 |
commit | 351fc4a99d49fde63fe5ab7412beb35c40d27269 (patch) | |
tree | 19d9be53c1d36c3cbfe0ffabf43a76d5da33c898 | |
parent | c91662cb18f00f225c74816353f222b6997131ca (diff) |
sb_edac: avoid INTERNAL ERROR message in EDAC with unspecified channel
Intel IA32 SDM Table 15-14 defines channel 0xf as 'not specified', but
EDAC doesn't know about this and returns and INTERNAL ERROR when the
channel is greater than NUM_CHANNELS:
kernel: [ 1538.886456] CPU 0: Machine Check Exception: 0 Bank 1: 940000000000009f
kernel: [ 1538.886669] TSC 2bc68b22e7e812 ADDR 46dae7000 MISC 0 PROCESSOR 0:306e4 TIME 1390414572 SOCKET 0 APIC 0
kernel: [ 1538.971948] EDAC MC1: INTERNAL ERROR: channel value is out of range (15 >= 4)
kernel: [ 1538.972203] EDAC MC1: 0 CE memory read error on unknown memory (slot:0 page:0x46dae7 offset:0x0 grain:0 syndrome:0x0 - area:DRAM err_code:0000:009f socket:1 channel_mask:1 rank:0)
This commit changes sb_edac to forward a channel of -1 to EDAC if the
channel is not specified. edac_mc_handle_error() sets the channel to -1
internally after the error message anyway, so this commit should have no
effect other than avoiding the INTERNAL ERROR message when the channel
is not specified.
Signed-off-by: Seth Jennings <sjenning@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r-- | drivers/edac/sb_edac.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index 0034c4844428..07efed452a15 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c | |||
@@ -283,8 +283,9 @@ static const u32 correrrthrsld[] = { | |||
283 | * sbridge structs | 283 | * sbridge structs |
284 | */ | 284 | */ |
285 | 285 | ||
286 | #define NUM_CHANNELS 4 | 286 | #define NUM_CHANNELS 4 |
287 | #define MAX_DIMMS 3 /* Max DIMMS per channel */ | 287 | #define MAX_DIMMS 3 /* Max DIMMS per channel */ |
288 | #define CHANNEL_UNSPECIFIED 0xf /* Intel IA32 SDM 15-14 */ | ||
288 | 289 | ||
289 | enum type { | 290 | enum type { |
290 | SANDY_BRIDGE, | 291 | SANDY_BRIDGE, |
@@ -1991,6 +1992,9 @@ static void sbridge_mce_output_error(struct mem_ctl_info *mci, | |||
1991 | 1992 | ||
1992 | /* FIXME: need support for channel mask */ | 1993 | /* FIXME: need support for channel mask */ |
1993 | 1994 | ||
1995 | if (channel == CHANNEL_UNSPECIFIED) | ||
1996 | channel = -1; | ||
1997 | |||
1994 | /* Call the helper to output message */ | 1998 | /* Call the helper to output message */ |
1995 | edac_mc_handle_error(tp_event, mci, core_err_cnt, | 1999 | edac_mc_handle_error(tp_event, mci, core_err_cnt, |
1996 | m->addr >> PAGE_SHIFT, m->addr & ~PAGE_MASK, 0, | 2000 | m->addr >> PAGE_SHIFT, m->addr & ~PAGE_MASK, 0, |