diff options
author | Christoph Hellwig <hch@lst.de> | 2014-09-06 19:08:05 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2014-10-21 16:02:54 -0400 |
commit | 34b48db66e08ca1c1bc07cf305d672ac940268dc (patch) | |
tree | 06fc3e6639a492eb14c326bd8697c1ba9907c9da | |
parent | c2661b806092d8ea2dccb7b02b65776555e0ee47 (diff) |
block: remove artifical max_hw_sectors cap
Set max_sectors to the value the drivers provides as hardware limit by
default. Linux had proper I/O throttling for a long time and doesn't
rely on a artifically small maximum I/O size anymore. By not limiting
the I/O size by default we remove an annoying tuning step required for
most Linux installation.
Note that both the user, and if absolutely required the driver can still
impose a limit for FS requests below max_hw_sectors_kb.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r-- | block/blk-settings.c | 4 | ||||
-rw-r--r-- | drivers/block/aoe/aoeblk.c | 2 | ||||
-rw-r--r-- | include/linux/blkdev.h | 1 |
3 files changed, 2 insertions, 5 deletions
diff --git a/block/blk-settings.c b/block/blk-settings.c index aa02247d227e..6ed2cbe5e8c9 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c | |||
@@ -257,9 +257,7 @@ void blk_limits_max_hw_sectors(struct queue_limits *limits, unsigned int max_hw_ | |||
257 | __func__, max_hw_sectors); | 257 | __func__, max_hw_sectors); |
258 | } | 258 | } |
259 | 259 | ||
260 | limits->max_hw_sectors = max_hw_sectors; | 260 | limits->max_sectors = limits->max_hw_sectors = max_hw_sectors; |
261 | limits->max_sectors = min_t(unsigned int, max_hw_sectors, | ||
262 | BLK_DEF_MAX_SECTORS); | ||
263 | } | 261 | } |
264 | EXPORT_SYMBOL(blk_limits_max_hw_sectors); | 262 | EXPORT_SYMBOL(blk_limits_max_hw_sectors); |
265 | 263 | ||
diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index dd73e1ff1759..46c282fff104 100644 --- a/drivers/block/aoe/aoeblk.c +++ b/drivers/block/aoe/aoeblk.c | |||
@@ -395,7 +395,7 @@ aoeblk_gdalloc(void *vp) | |||
395 | WARN_ON(d->flags & DEVFL_TKILL); | 395 | WARN_ON(d->flags & DEVFL_TKILL); |
396 | WARN_ON(d->gd); | 396 | WARN_ON(d->gd); |
397 | WARN_ON(d->flags & DEVFL_UP); | 397 | WARN_ON(d->flags & DEVFL_UP); |
398 | blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS); | 398 | blk_queue_max_hw_sectors(q, 1024); |
399 | q->backing_dev_info.name = "aoe"; | 399 | q->backing_dev_info.name = "aoe"; |
400 | q->backing_dev_info.ra_pages = READ_AHEAD / PAGE_CACHE_SIZE; | 400 | q->backing_dev_info.ra_pages = READ_AHEAD / PAGE_CACHE_SIZE; |
401 | d->bufpool = mp; | 401 | d->bufpool = mp; |
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 0207a78a8d82..74d14dba6fb7 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h | |||
@@ -1186,7 +1186,6 @@ extern int blk_verify_command(unsigned char *cmd, fmode_t has_write_perm); | |||
1186 | enum blk_default_limits { | 1186 | enum blk_default_limits { |
1187 | BLK_MAX_SEGMENTS = 128, | 1187 | BLK_MAX_SEGMENTS = 128, |
1188 | BLK_SAFE_MAX_SECTORS = 255, | 1188 | BLK_SAFE_MAX_SECTORS = 255, |
1189 | BLK_DEF_MAX_SECTORS = 1024, | ||
1190 | BLK_MAX_SEGMENT_SIZE = 65536, | 1189 | BLK_MAX_SEGMENT_SIZE = 65536, |
1191 | BLK_SEG_BOUNDARY_MASK = 0xFFFFFFFFUL, | 1190 | BLK_SEG_BOUNDARY_MASK = 0xFFFFFFFFUL, |
1192 | }; | 1191 | }; |