aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2014-01-10 13:49:20 -0500
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-01-10 16:26:15 -0500
commit3432087ef846d760427eceff0ff4e7d0a2565b8a (patch)
treee5cd87628660ca84f11d50e35b3d59b076442c0f
parent704cfb87886cddffd79e78ea5f717963dac68175 (diff)
drm/i915: Only WARN about a stuck hotplug irq ONCE
It seems that hardware that is broken enough to emit a hotplug IRQ even though the pin is surposedly disable, will do so indefinitely. Note: There's a good chance the underlying issue has been fixed with commit 0ce99f749b3834edeb500e17d6ad17e86b60ff83 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Fri Jul 26 11:27:49 2013 +0200 drm/i915: fix gen4 digital port hotplug definitions References: https://bugzilla.redhat.com/show_bug.cgi?id=1051170 Link: https://bugzilla.redhat.com/attachment.cgi?id=847786 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> [danvet: Add note about the potential fix.] Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/i915/i915_irq.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index a9b0b181cb40..72453f1f7ae5 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1233,9 +1233,9 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev,
1233 spin_lock(&dev_priv->irq_lock); 1233 spin_lock(&dev_priv->irq_lock);
1234 for (i = 1; i < HPD_NUM_PINS; i++) { 1234 for (i = 1; i < HPD_NUM_PINS; i++) {
1235 1235
1236 WARN(((hpd[i] & hotplug_trigger) && 1236 WARN_ONCE(hpd[i] & hotplug_trigger &&
1237 dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED), 1237 dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED,
1238 "Received HPD interrupt although disabled\n"); 1238 "Received HPD interrupt although disabled\n");
1239 1239
1240 if (!(hpd[i] & hotplug_trigger) || 1240 if (!(hpd[i] & hotplug_trigger) ||
1241 dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED) 1241 dev_priv->hpd_stats[i].hpd_mark != HPD_ENABLED)