diff options
author | Julia Lawall <julia@diku.dk> | 2009-09-23 18:57:36 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-24 10:21:05 -0400 |
commit | 3354f73b24c6d392ed7fd5583cfcc7604c1934ae (patch) | |
tree | b1c72139bef6d31eebcc72af5634f303c5242e69 | |
parent | a21f3c2a04d8a8d26b4bf3523368380feb8742b7 (diff) |
drivers/vlynq/vlynq.c: fix resource size off by 1 error
In this case, the calls to request_mem_region, ioremap, and
release_mem_region all have a consistent length argument, len, but since
in other files (res->end - res->start) + 1, equivalent to
resource_size(res), is used for a resource-typed structure res, one could
consider whether the same should be done here.
The problem was found using the following semantic patch:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
struct resource *res;
@@
- (res->end - res->start) + 1
+ resource_size(res)
@@
struct resource *res;
@@
- res->end - res->start
+ BAD(resource_size(res))
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/vlynq/vlynq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c index ba3d71f5c7d0..9554ad5f9af7 100644 --- a/drivers/vlynq/vlynq.c +++ b/drivers/vlynq/vlynq.c | |||
@@ -702,7 +702,7 @@ static int vlynq_probe(struct platform_device *pdev) | |||
702 | dev->mem_start = mem_res->start; | 702 | dev->mem_start = mem_res->start; |
703 | dev->mem_end = mem_res->end; | 703 | dev->mem_end = mem_res->end; |
704 | 704 | ||
705 | len = regs_res->end - regs_res->start; | 705 | len = resource_size(regs_res); |
706 | if (!request_mem_region(regs_res->start, len, dev_name(&dev->dev))) { | 706 | if (!request_mem_region(regs_res->start, len, dev_name(&dev->dev))) { |
707 | printk(KERN_ERR "%s: Can't request vlynq registers\n", | 707 | printk(KERN_ERR "%s: Can't request vlynq registers\n", |
708 | dev_name(&dev->dev)); | 708 | dev_name(&dev->dev)); |