aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2014-03-14 14:20:58 -0400
committerTejun Heo <tj@kernel.org>2014-03-14 14:26:29 -0400
commit33081b34681742add8d8c1e49fc93045415e5a18 (patch)
treed99e5f0f73f2714a575621ca0b16543bf481329a
parentd920203695029558ef16925182f89cf6302b50b0 (diff)
ata: ahci_st: build fixes
* The config option for ahci_st driver was renamed from CONFIG_SATA_AHCI_ST to CONFIG_AHCI_ST but Makefile was not updated. Fix it (also while at it move the ahci_st driver entry below ahci_imx and ahci_sunxi ones). * Fix a few build issues in the ahci_st driver itself. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r--drivers/ata/Makefile2
-rw-r--r--drivers/ata/ahci_st.c12
2 files changed, 6 insertions, 8 deletions
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 6bbd6dadef50..e20148c022b4 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -5,7 +5,6 @@ obj-$(CONFIG_ATA) += libata.o
5obj-$(CONFIG_SATA_AHCI) += ahci.o libahci.o 5obj-$(CONFIG_SATA_AHCI) += ahci.o libahci.o
6obj-$(CONFIG_SATA_ACARD_AHCI) += acard-ahci.o libahci.o 6obj-$(CONFIG_SATA_ACARD_AHCI) += acard-ahci.o libahci.o
7obj-$(CONFIG_SATA_AHCI_PLATFORM) += ahci_platform.o libahci.o 7obj-$(CONFIG_SATA_AHCI_PLATFORM) += ahci_platform.o libahci.o
8obj-$(CONFIG_SATA_AHCI_ST) += ahci_st.o
9obj-$(CONFIG_SATA_FSL) += sata_fsl.o 8obj-$(CONFIG_SATA_FSL) += sata_fsl.o
10obj-$(CONFIG_SATA_INIC162X) += sata_inic162x.o 9obj-$(CONFIG_SATA_INIC162X) += sata_inic162x.o
11obj-$(CONFIG_SATA_SIL24) += sata_sil24.o 10obj-$(CONFIG_SATA_SIL24) += sata_sil24.o
@@ -13,6 +12,7 @@ obj-$(CONFIG_SATA_DWC) += sata_dwc_460ex.o
13obj-$(CONFIG_SATA_HIGHBANK) += sata_highbank.o libahci.o 12obj-$(CONFIG_SATA_HIGHBANK) += sata_highbank.o libahci.o
14obj-$(CONFIG_AHCI_IMX) += ahci_imx.o 13obj-$(CONFIG_AHCI_IMX) += ahci_imx.o
15obj-$(CONFIG_AHCI_SUNXI) += ahci_sunxi.o 14obj-$(CONFIG_AHCI_SUNXI) += ahci_sunxi.o
15obj-$(CONFIG_AHCI_ST) += ahci_st.o
16 16
17# SFF w/ custom DMA 17# SFF w/ custom DMA
18obj-$(CONFIG_PDC_ADMA) += pdc_adma.o 18obj-$(CONFIG_PDC_ADMA) += pdc_adma.o
diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
index 17191b96648e..e1aa5447a400 100644
--- a/drivers/ata/ahci_st.c
+++ b/drivers/ata/ahci_st.c
@@ -87,7 +87,7 @@ static int st_ahci_deassert_resets(struct device *dev)
87 return 0; 87 return 0;
88} 88}
89 89
90static int st_ahci_exit(struct device *dev) 90static void st_ahci_exit(struct device *dev)
91{ 91{
92 struct st_ahci_drv_data *drv_data = dev_get_drvdata(dev); 92 struct st_ahci_drv_data *drv_data = dev_get_drvdata(dev);
93 struct ahci_host_priv *hpriv = drv_data->hpriv; 93 struct ahci_host_priv *hpriv = drv_data->hpriv;
@@ -96,12 +96,10 @@ static int st_ahci_exit(struct device *dev)
96 if (drv_data->pwr) { 96 if (drv_data->pwr) {
97 err = reset_control_assert(drv_data->pwr); 97 err = reset_control_assert(drv_data->pwr);
98 if (err) 98 if (err)
99 dev_err(&pdev->dev, "unable to pwrdwn\n"); 99 dev_err(dev, "unable to pwrdwn\n");
100 } 100 }
101 101
102 ahci_platform_disable_resources(hpriv); 102 ahci_platform_disable_resources(hpriv);
103
104 return 0;
105} 103}
106 104
107static int st_ahci_probe_resets(struct platform_device *pdev) 105static int st_ahci_probe_resets(struct platform_device *pdev)
@@ -186,9 +184,9 @@ static int st_ahci_suspend(struct device *dev)
186 struct ahci_host_priv *hpriv = drv_data->hpriv; 184 struct ahci_host_priv *hpriv = drv_data->hpriv;
187 int err; 185 int err;
188 186
189 ret = ahci_platform_suspend_host(dev); 187 err = ahci_platform_suspend_host(dev);
190 if (ret) 188 if (err)
191 return ret; 189 return err;
192 190
193 if (drv_data->pwr) { 191 if (drv_data->pwr) {
194 err = reset_control_assert(drv_data->pwr); 192 err = reset_control_assert(drv_data->pwr);