diff options
author | Arnd Bergmann <arnd@arndb.de> | 2015-01-23 09:40:15 -0500 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2015-02-18 06:20:25 -0500 |
commit | 31612d6484271ad6d4db5b4c8df366f35bded928 (patch) | |
tree | 63a569e982a6a742c36677a2de7f293c3f093961 | |
parent | ff34cae5b4fc7a84113d7c7e8611ba87a7c31dba (diff) |
ARM: davinci: davinci_cfg_reg cannot be init
davinci_cfg_reg gets called from a lot of locations that
might get called after the init section has been discarded,
so the function itself must not be marked __init either.
The kernel build currently warns about this with lots of
messages like:
WARNING: vmlinux.o(.text.unlikely+0x24c): Section mismatch in reference from the function dm365evm_mmc_configure() to the function .init.text:davinci_cfg_reg()
The function dm365evm_mmc_configure() references
the function __init davinci_cfg_reg().
This is often because dm365evm_mmc_configure lacks a __init
annotation or the annotation of davinci_cfg_reg is wrong.
This removes the extraneous __init_or_module annotation.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
-rw-r--r-- | arch/arm/mach-davinci/mux.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm/mach-davinci/mux.c b/arch/arm/mach-davinci/mux.c index a8eb909a2b6c..6a2ff0a654a5 100644 --- a/arch/arm/mach-davinci/mux.c +++ b/arch/arm/mach-davinci/mux.c | |||
@@ -30,7 +30,7 @@ static void __iomem *pinmux_base; | |||
30 | /* | 30 | /* |
31 | * Sets the DAVINCI MUX register based on the table | 31 | * Sets the DAVINCI MUX register based on the table |
32 | */ | 32 | */ |
33 | int __init_or_module davinci_cfg_reg(const unsigned long index) | 33 | int davinci_cfg_reg(const unsigned long index) |
34 | { | 34 | { |
35 | static DEFINE_SPINLOCK(mux_spin_lock); | 35 | static DEFINE_SPINLOCK(mux_spin_lock); |
36 | struct davinci_soc_info *soc_info = &davinci_soc_info; | 36 | struct davinci_soc_info *soc_info = &davinci_soc_info; |
@@ -101,7 +101,7 @@ int __init_or_module davinci_cfg_reg(const unsigned long index) | |||
101 | } | 101 | } |
102 | EXPORT_SYMBOL(davinci_cfg_reg); | 102 | EXPORT_SYMBOL(davinci_cfg_reg); |
103 | 103 | ||
104 | int __init_or_module davinci_cfg_reg_list(const short pins[]) | 104 | int davinci_cfg_reg_list(const short pins[]) |
105 | { | 105 | { |
106 | int i, error = -EINVAL; | 106 | int i, error = -EINVAL; |
107 | 107 | ||