aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVivek Goyal <vgoyal@in.ibm.com>2007-05-02 13:27:07 -0400
committerAndi Kleen <andi@basil.nowhere.org>2007-05-02 13:27:07 -0400
commit30f472895401fbe8e64f861a2569bc9acb098741 (patch)
tree121c0836f9327125e14e1b54d7a82da722efa6a5
parent278c0eb7f96586c02b2bfaa8e250d951919a2e6a (diff)
[PATCH] x86-64: cleanup segments
Move __KERNEL32_CS up into the unused gdt entry. __KERNEL32_CS is used when entering the kernel so putting it first is useful when trying to keep boot gdt sizes to a minimum. Set the accessed bit on all gdt entries. We don't care so there is no need for the cpu to burn the extra cycles, and it potentially allows the pages to be immutable. Plus it is confusing when debugging and your gdt entries mysteriously change. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andi Kleen <ak@suse.de>
-rw-r--r--arch/x86_64/kernel/head.S12
-rw-r--r--include/asm-x86_64/segment.h2
2 files changed, 7 insertions, 7 deletions
diff --git a/arch/x86_64/kernel/head.S b/arch/x86_64/kernel/head.S
index 23b45e79a27c..2b2e2c51e532 100644
--- a/arch/x86_64/kernel/head.S
+++ b/arch/x86_64/kernel/head.S
@@ -362,13 +362,13 @@ gdt:
362 362
363ENTRY(cpu_gdt_table) 363ENTRY(cpu_gdt_table)
364 .quad 0x0000000000000000 /* NULL descriptor */ 364 .quad 0x0000000000000000 /* NULL descriptor */
365 .quad 0x00cf9b000000ffff /* __KERNEL32_CS */
366 .quad 0x00af9b000000ffff /* __KERNEL_CS */
367 .quad 0x00cf93000000ffff /* __KERNEL_DS */
368 .quad 0x00cffb000000ffff /* __USER32_CS */
369 .quad 0x00cff3000000ffff /* __USER_DS, __USER32_DS */
370 .quad 0x00affb000000ffff /* __USER_CS */
365 .quad 0x0 /* unused */ 371 .quad 0x0 /* unused */
366 .quad 0x00af9a000000ffff /* __KERNEL_CS */
367 .quad 0x00cf92000000ffff /* __KERNEL_DS */
368 .quad 0x00cffa000000ffff /* __USER32_CS */
369 .quad 0x00cff2000000ffff /* __USER_DS, __USER32_DS */
370 .quad 0x00affa000000ffff /* __USER_CS */
371 .quad 0x00cf9a000000ffff /* __KERNEL32_CS */
372 .quad 0,0 /* TSS */ 372 .quad 0,0 /* TSS */
373 .quad 0,0 /* LDT */ 373 .quad 0,0 /* LDT */
374 .quad 0,0,0 /* three TLS descriptors */ 374 .quad 0,0,0 /* three TLS descriptors */
diff --git a/include/asm-x86_64/segment.h b/include/asm-x86_64/segment.h
index 334ddcdd8f92..adf2bf1e187c 100644
--- a/include/asm-x86_64/segment.h
+++ b/include/asm-x86_64/segment.h
@@ -6,7 +6,7 @@
6#define __KERNEL_CS 0x10 6#define __KERNEL_CS 0x10
7#define __KERNEL_DS 0x18 7#define __KERNEL_DS 0x18
8 8
9#define __KERNEL32_CS 0x38 9#define __KERNEL32_CS 0x08
10 10
11/* 11/*
12 * we cannot use the same code segment descriptor for user and kernel 12 * we cannot use the same code segment descriptor for user and kernel