diff options
| author | Nicolas Ferre <nicolas.ferre@atmel.com> | 2011-04-30 10:57:48 -0400 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2011-05-02 06:12:09 -0400 |
| commit | 2f432823ec6e693d7b934e805ce1838f41d66ce7 (patch) | |
| tree | d3081ac9ae558e05b18f9df49a9c127bf8dc45de | |
| parent | cc52a10a048fc1fbe4ffba58c2f0afc79ae0f56f (diff) | |
dmaengine: at_hdmac: remove channel status testing in tasklet
There is no need to test if channel is enabled in tasklet:
- in error path, channel is disabled in interrupt routine
- in normal path, this test is performed in sub functions to report
a misuse of the engine.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
| -rw-r--r-- | drivers/dma/at_hdmac.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 8f50a0fb79e7..65bd52a84bc3 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c | |||
| @@ -472,13 +472,6 @@ static void atc_tasklet(unsigned long data) | |||
| 472 | { | 472 | { |
| 473 | struct at_dma_chan *atchan = (struct at_dma_chan *)data; | 473 | struct at_dma_chan *atchan = (struct at_dma_chan *)data; |
| 474 | 474 | ||
| 475 | /* Channel cannot be enabled here */ | ||
| 476 | if (atc_chan_is_enabled(atchan)) { | ||
| 477 | dev_err(chan2dev(&atchan->chan_common), | ||
| 478 | "BUG: channel enabled in tasklet\n"); | ||
| 479 | return; | ||
| 480 | } | ||
| 481 | |||
| 482 | spin_lock(&atchan->lock); | 475 | spin_lock(&atchan->lock); |
| 483 | if (test_and_clear_bit(ATC_IS_ERROR, &atchan->status)) | 476 | if (test_and_clear_bit(ATC_IS_ERROR, &atchan->status)) |
| 484 | atc_handle_error(atchan); | 477 | atc_handle_error(atchan); |
