diff options
author | Johannes Berg <johannes.berg@intel.com> | 2012-10-31 16:46:07 -0400 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2012-11-05 10:12:23 -0500 |
commit | 2eb81a40aa521035ff9c8c8309e482dff523f8c9 (patch) | |
tree | 4e43f5901878b7448f9224516ff87b0ccf60eedf | |
parent | 37c477dc1c6cad4a36049a9a10e4aa3dbf450c0f (diff) |
iwlwifi: don't clear CTL_AMPDU on frame status
There's no reason to clear the CTL_AMPDU flag on
transmitted frame status, it's not used by the
driver here and mac80211 only uses it for some
rate statistics.
Also remove a stray space in the function.
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r-- | drivers/net/wireless/iwlwifi/dvm/tx.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/net/wireless/iwlwifi/dvm/tx.c b/drivers/net/wireless/iwlwifi/dvm/tx.c index f5ca73a89870..4ae031f6726b 100644 --- a/drivers/net/wireless/iwlwifi/dvm/tx.c +++ b/drivers/net/wireless/iwlwifi/dvm/tx.c | |||
@@ -1075,14 +1075,11 @@ static void iwlagn_count_tx_err_status(struct iwl_priv *priv, u16 status) | |||
1075 | 1075 | ||
1076 | static void iwlagn_set_tx_status(struct iwl_priv *priv, | 1076 | static void iwlagn_set_tx_status(struct iwl_priv *priv, |
1077 | struct ieee80211_tx_info *info, | 1077 | struct ieee80211_tx_info *info, |
1078 | struct iwlagn_tx_resp *tx_resp, | 1078 | struct iwlagn_tx_resp *tx_resp) |
1079 | bool is_agg) | ||
1080 | { | 1079 | { |
1081 | u16 status = le16_to_cpu(tx_resp->status.status); | 1080 | u16 status = le16_to_cpu(tx_resp->status.status); |
1082 | 1081 | ||
1083 | info->status.rates[0].count = tx_resp->failure_frame + 1; | 1082 | info->status.rates[0].count = tx_resp->failure_frame + 1; |
1084 | if (is_agg) | ||
1085 | info->flags &= ~IEEE80211_TX_CTL_AMPDU; | ||
1086 | info->flags |= iwl_tx_status_to_mac80211(status); | 1083 | info->flags |= iwl_tx_status_to_mac80211(status); |
1087 | iwlagn_hwrate_to_tx_control(priv, le32_to_cpu(tx_resp->rate_n_flags), | 1084 | iwlagn_hwrate_to_tx_control(priv, le32_to_cpu(tx_resp->rate_n_flags), |
1088 | info); | 1085 | info); |
@@ -1231,7 +1228,7 @@ int iwlagn_rx_reply_tx(struct iwl_priv *priv, struct iwl_rx_cmd_buffer *rxb, | |||
1231 | if (is_agg && !iwl_is_tx_success(status)) | 1228 | if (is_agg && !iwl_is_tx_success(status)) |
1232 | info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK; | 1229 | info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK; |
1233 | iwlagn_set_tx_status(priv, IEEE80211_SKB_CB(skb), | 1230 | iwlagn_set_tx_status(priv, IEEE80211_SKB_CB(skb), |
1234 | tx_resp, is_agg); | 1231 | tx_resp); |
1235 | if (!is_agg) | 1232 | if (!is_agg) |
1236 | iwlagn_non_agg_tx_status(priv, ctx, hdr->addr1); | 1233 | iwlagn_non_agg_tx_status(priv, ctx, hdr->addr1); |
1237 | 1234 | ||