diff options
| author | S.Caglar Onur <caglar@pardus.org.tr> | 2008-04-29 03:59:26 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-29 11:06:04 -0400 |
| commit | 2e50b6ccdaaf0d933bb9d8409cac4b2f088f5a2f (patch) | |
| tree | ba25ec419f3a4fb6e6845ec5b74d6af753e7f78f | |
| parent | aab3c3b01d1848a5e8a1ddec4e5656fc4de04982 (diff) | |
fs/binfmt_aout.c: use printk_ratelimit()
Use printk_ratelimit() instead of jiffies based arithmetic, suggested by Geert
Uytterhoeven
Signed-off-by: S.Caglar Onur <caglar@pardus.org.tr>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/binfmt_aout.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c index a1bb2244cac7..ba4cddb92f1d 100644 --- a/fs/binfmt_aout.c +++ b/fs/binfmt_aout.c | |||
| @@ -372,21 +372,17 @@ static int load_aout_binary(struct linux_binprm * bprm, struct pt_regs * regs) | |||
| 372 | 372 | ||
| 373 | flush_icache_range(text_addr, text_addr+ex.a_text+ex.a_data); | 373 | flush_icache_range(text_addr, text_addr+ex.a_text+ex.a_data); |
| 374 | } else { | 374 | } else { |
| 375 | static unsigned long error_time, error_time2; | ||
| 376 | if ((ex.a_text & 0xfff || ex.a_data & 0xfff) && | 375 | if ((ex.a_text & 0xfff || ex.a_data & 0xfff) && |
| 377 | (N_MAGIC(ex) != NMAGIC) && (jiffies-error_time2) > 5*HZ) | 376 | (N_MAGIC(ex) != NMAGIC) && printk_ratelimit()) |
| 378 | { | 377 | { |
| 379 | printk(KERN_NOTICE "executable not page aligned\n"); | 378 | printk(KERN_NOTICE "executable not page aligned\n"); |
| 380 | error_time2 = jiffies; | ||
| 381 | } | 379 | } |
| 382 | 380 | ||
| 383 | if ((fd_offset & ~PAGE_MASK) != 0 && | 381 | if ((fd_offset & ~PAGE_MASK) != 0 && printk_ratelimit()) |
| 384 | (jiffies-error_time) > 5*HZ) | ||
| 385 | { | 382 | { |
| 386 | printk(KERN_WARNING | 383 | printk(KERN_WARNING |
| 387 | "fd_offset is not page aligned. Please convert program: %s\n", | 384 | "fd_offset is not page aligned. Please convert program: %s\n", |
| 388 | bprm->file->f_path.dentry->d_name.name); | 385 | bprm->file->f_path.dentry->d_name.name); |
| 389 | error_time = jiffies; | ||
| 390 | } | 386 | } |
| 391 | 387 | ||
| 392 | if (!bprm->file->f_op->mmap||((fd_offset & ~PAGE_MASK) != 0)) { | 388 | if (!bprm->file->f_op->mmap||((fd_offset & ~PAGE_MASK) != 0)) { |
| @@ -495,15 +491,13 @@ static int load_aout_library(struct file *file) | |||
| 495 | start_addr = ex.a_entry & 0xfffff000; | 491 | start_addr = ex.a_entry & 0xfffff000; |
| 496 | 492 | ||
| 497 | if ((N_TXTOFF(ex) & ~PAGE_MASK) != 0) { | 493 | if ((N_TXTOFF(ex) & ~PAGE_MASK) != 0) { |
| 498 | static unsigned long error_time; | ||
| 499 | loff_t pos = N_TXTOFF(ex); | 494 | loff_t pos = N_TXTOFF(ex); |
| 500 | 495 | ||
| 501 | if ((jiffies-error_time) > 5*HZ) | 496 | if (printk_ratelimit()) |
| 502 | { | 497 | { |
| 503 | printk(KERN_WARNING | 498 | printk(KERN_WARNING |
| 504 | "N_TXTOFF is not page aligned. Please convert library: %s\n", | 499 | "N_TXTOFF is not page aligned. Please convert library: %s\n", |
| 505 | file->f_path.dentry->d_name.name); | 500 | file->f_path.dentry->d_name.name); |
| 506 | error_time = jiffies; | ||
| 507 | } | 501 | } |
| 508 | down_write(¤t->mm->mmap_sem); | 502 | down_write(¤t->mm->mmap_sem); |
| 509 | do_brk(start_addr, ex.a_text + ex.a_data + ex.a_bss); | 503 | do_brk(start_addr, ex.a_text + ex.a_data + ex.a_bss); |
