aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2013-03-04 03:15:21 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2013-03-21 13:33:31 -0400
commit2e2d612d80c1cb829769d413a8e8bf64f64197f8 (patch)
tree4104569995181ae6a12ad8adef56f7861fbce168
parent15a0934201780f7a95d9fa3b910e19bf89ab25d5 (diff)
[media] soc_camera/sh_mobile_csi2: Convert to devm_ioremap_resource()
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/platform/soc_camera/sh_mobile_csi2.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/media/platform/soc_camera/sh_mobile_csi2.c b/drivers/media/platform/soc_camera/sh_mobile_csi2.c
index 42c559eb4937..09cb4fc88f34 100644
--- a/drivers/media/platform/soc_camera/sh_mobile_csi2.c
+++ b/drivers/media/platform/soc_camera/sh_mobile_csi2.c
@@ -9,6 +9,7 @@
9 */ 9 */
10 10
11#include <linux/delay.h> 11#include <linux/delay.h>
12#include <linux/err.h>
12#include <linux/i2c.h> 13#include <linux/i2c.h>
13#include <linux/io.h> 14#include <linux/io.h>
14#include <linux/platform_device.h> 15#include <linux/platform_device.h>
@@ -324,11 +325,9 @@ static int sh_csi2_probe(struct platform_device *pdev)
324 325
325 priv->irq = irq; 326 priv->irq = irq;
326 327
327 priv->base = devm_request_and_ioremap(&pdev->dev, res); 328 priv->base = devm_ioremap_resource(&pdev->dev, res);
328 if (!priv->base) { 329 if (IS_ERR(priv->base))
329 dev_err(&pdev->dev, "Unable to ioremap CSI2 registers.\n"); 330 return PTR_ERR(priv->base);
330 return -ENXIO;
331 }
332 331
333 priv->pdev = pdev; 332 priv->pdev = pdev;
334 platform_set_drvdata(pdev, priv); 333 platform_set_drvdata(pdev, priv);