diff options
| author | Ingo Molnar <mingo@elte.hu> | 2011-04-29 08:16:18 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2011-04-29 08:35:57 -0400 |
| commit | 2b427e14b77dbf3e05f1bd0785f1d07ea5fe924e (patch) | |
| tree | 207749426e797f00553e15c339965c45398d61e0 | |
| parent | d3d1e86da07b4565815e3dbcd082f53017d215f8 (diff) | |
perf stat: Adjust stall cycles warning percentages
Adjust to color thresholds to better match the percentages seen in
real workloads. Both are now a bit more sensitive.
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/n/tip-7y40wib8n004io7hjpn1dsrm@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rw-r--r-- | tools/perf/builtin-stat.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index e45449938b80..2492a0efa4d8 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c | |||
| @@ -492,11 +492,11 @@ static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __us | |||
| 492 | ratio = avg / total * 100.0; | 492 | ratio = avg / total * 100.0; |
| 493 | 493 | ||
| 494 | color = PERF_COLOR_NORMAL; | 494 | color = PERF_COLOR_NORMAL; |
| 495 | if (ratio > 75.0) | 495 | if (ratio > 50.0) |
| 496 | color = PERF_COLOR_RED; | 496 | color = PERF_COLOR_RED; |
| 497 | else if (ratio > 50.0) | 497 | else if (ratio > 30.0) |
| 498 | color = PERF_COLOR_MAGENTA; | 498 | color = PERF_COLOR_MAGENTA; |
| 499 | else if (ratio > 20.0) | 499 | else if (ratio > 10.0) |
| 500 | color = PERF_COLOR_YELLOW; | 500 | color = PERF_COLOR_YELLOW; |
| 501 | 501 | ||
| 502 | fprintf(stderr, " # "); | 502 | fprintf(stderr, " # "); |
| @@ -519,7 +519,7 @@ static void print_stalled_cycles_backend(int cpu, struct perf_evsel *evsel __use | |||
| 519 | color = PERF_COLOR_RED; | 519 | color = PERF_COLOR_RED; |
| 520 | else if (ratio > 50.0) | 520 | else if (ratio > 50.0) |
| 521 | color = PERF_COLOR_MAGENTA; | 521 | color = PERF_COLOR_MAGENTA; |
| 522 | else if (ratio > 25.0) | 522 | else if (ratio > 20.0) |
| 523 | color = PERF_COLOR_YELLOW; | 523 | color = PERF_COLOR_YELLOW; |
| 524 | 524 | ||
| 525 | fprintf(stderr, " # "); | 525 | fprintf(stderr, " # "); |
