diff options
author | Sam Ravnborg <sam@ravnborg.org> | 2014-04-21 15:39:22 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-04-29 01:12:25 -0400 |
commit | 2b399177dc58b28efa5937613760bdabfd5638f0 (patch) | |
tree | d9167eb5bc90034e23aa539249cbd9624e3b754a | |
parent | fcd0196b7eb17a8b696a1263281bcdb9eedcfbc0 (diff) |
sparc32: fix sparse warnings in sun4m_irq.c and sun4d_irq.c
Fix following warnings:
sun4m_irq.c:308:6: warning: symbol 'sun4m_nmi' was not declared. Should it be static?
sun4m_irq.c:396:28: warning: incorrect type in assignment (different address spaces)
sun4m_irq.c:396:28: expected unsigned int volatile *extern [addressable] [toplevel] master_l10_counter
sun4d_irq.c:469:28: warning: incorrect type in assignment (different address spaces)
sun4d_irq.c:469:28: expected unsigned int volatile *extern [addressable] [toplevel] master_l10_counter
master_l10_counter is a pointer to __iomem - add annotations.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | arch/sparc/include/asm/timer_32.h | 2 | ||||
-rw-r--r-- | arch/sparc/kernel/irq.h | 3 | ||||
-rw-r--r-- | arch/sparc/kernel/leon_kernel.c | 5 | ||||
-rw-r--r-- | arch/sparc/kernel/time_32.c | 2 |
4 files changed, 8 insertions, 4 deletions
diff --git a/arch/sparc/include/asm/timer_32.h b/arch/sparc/include/asm/timer_32.h index 72f40a546de3..93476f8d7fea 100644 --- a/arch/sparc/include/asm/timer_32.h +++ b/arch/sparc/include/asm/timer_32.h | |||
@@ -32,7 +32,7 @@ static inline unsigned int timer_value(unsigned int value) | |||
32 | return (value + 1) << TIMER_VALUE_SHIFT; | 32 | return (value + 1) << TIMER_VALUE_SHIFT; |
33 | } | 33 | } |
34 | 34 | ||
35 | extern __volatile__ unsigned int *master_l10_counter; | 35 | extern volatile unsigned int __iomem *master_l10_counter; |
36 | 36 | ||
37 | extern irqreturn_t notrace timer_interrupt(int dummy, void *dev_id); | 37 | extern irqreturn_t notrace timer_interrupt(int dummy, void *dev_id); |
38 | 38 | ||
diff --git a/arch/sparc/kernel/irq.h b/arch/sparc/kernel/irq.h index b66b6aad1d6d..97c07dead26b 100644 --- a/arch/sparc/kernel/irq.h +++ b/arch/sparc/kernel/irq.h | |||
@@ -82,6 +82,9 @@ void handler_irq(unsigned int pil, struct pt_regs *regs); | |||
82 | 82 | ||
83 | unsigned long leon_get_irqmask(unsigned int irq); | 83 | unsigned long leon_get_irqmask(unsigned int irq); |
84 | 84 | ||
85 | /* sun4m_irq.c */ | ||
86 | void sun4m_nmi(struct pt_regs *regs); | ||
87 | |||
85 | #ifdef CONFIG_SMP | 88 | #ifdef CONFIG_SMP |
86 | 89 | ||
87 | /* All SUN4D IPIs are sent on this IRQ, may be shared with hard IRQs */ | 90 | /* All SUN4D IPIs are sent on this IRQ, may be shared with hard IRQs */ |
diff --git a/arch/sparc/kernel/leon_kernel.c b/arch/sparc/kernel/leon_kernel.c index b7c68976cbc7..b9a2599e3a3a 100644 --- a/arch/sparc/kernel/leon_kernel.c +++ b/arch/sparc/kernel/leon_kernel.c | |||
@@ -32,7 +32,7 @@ struct leon3_gptimer_regs_map *leon3_gptimer_regs; /* timer controller base addr | |||
32 | 32 | ||
33 | int leondebug_irq_disable; | 33 | int leondebug_irq_disable; |
34 | int leon_debug_irqout; | 34 | int leon_debug_irqout; |
35 | static int dummy_master_l10_counter; | 35 | static volatile unsigned int dummy_master_l10_counter; |
36 | unsigned long amba_system_id; | 36 | unsigned long amba_system_id; |
37 | static DEFINE_SPINLOCK(leon_irq_lock); | 37 | static DEFINE_SPINLOCK(leon_irq_lock); |
38 | 38 | ||
@@ -313,7 +313,8 @@ void __init leon_init_timers(void) | |||
313 | 313 | ||
314 | leondebug_irq_disable = 0; | 314 | leondebug_irq_disable = 0; |
315 | leon_debug_irqout = 0; | 315 | leon_debug_irqout = 0; |
316 | master_l10_counter = (unsigned int *)&dummy_master_l10_counter; | 316 | master_l10_counter = |
317 | (unsigned int __iomem *)&dummy_master_l10_counter; | ||
317 | dummy_master_l10_counter = 0; | 318 | dummy_master_l10_counter = 0; |
318 | 319 | ||
319 | rootnp = of_find_node_by_path("/ambapp0"); | 320 | rootnp = of_find_node_by_path("/ambapp0"); |
diff --git a/arch/sparc/kernel/time_32.c b/arch/sparc/kernel/time_32.c index c4c27b0f9063..772b37986a9c 100644 --- a/arch/sparc/kernel/time_32.c +++ b/arch/sparc/kernel/time_32.c | |||
@@ -83,7 +83,7 @@ unsigned long profile_pc(struct pt_regs *regs) | |||
83 | 83 | ||
84 | EXPORT_SYMBOL(profile_pc); | 84 | EXPORT_SYMBOL(profile_pc); |
85 | 85 | ||
86 | __volatile__ unsigned int *master_l10_counter; | 86 | volatile unsigned int __iomem *master_l10_counter; |
87 | 87 | ||
88 | int update_persistent_clock(struct timespec now) | 88 | int update_persistent_clock(struct timespec now) |
89 | { | 89 | { |