diff options
| author | Jan Beulich <jbeulich@novell.com> | 2006-01-11 16:47:03 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-11 22:05:04 -0500 |
| commit | 2a2d5924c249e0f73aa00d617f8d5e242ea1430d (patch) | |
| tree | 2458187ff2b5eea03f269e15acf3532f351f8fcb | |
| parent | 4092bdebab46235d69fcd68afc710cddad550892 (diff) | |
[PATCH] i386/x86-64: make setup_early_printk() usage consistent
The explicit and implicit calls to setup_early_printk() were passing
inconsistent arguments.
Signed-Off-By: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | arch/i386/kernel/setup.c | 2 | ||||
| -rw-r--r-- | arch/x86_64/kernel/early_printk.c | 4 | ||||
| -rw-r--r-- | arch/x86_64/kernel/head64.c | 2 |
3 files changed, 3 insertions, 5 deletions
diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c index a720f743ea6e..51e513b4f72d 100644 --- a/arch/i386/kernel/setup.c +++ b/arch/i386/kernel/setup.c | |||
| @@ -1584,7 +1584,7 @@ void __init setup_arch(char **cmdline_p) | |||
| 1584 | if (s) { | 1584 | if (s) { |
| 1585 | extern void setup_early_printk(char *); | 1585 | extern void setup_early_printk(char *); |
| 1586 | 1586 | ||
| 1587 | setup_early_printk(s); | 1587 | setup_early_printk(strchr(s, '=') + 1); |
| 1588 | printk("early console enabled\n"); | 1588 | printk("early console enabled\n"); |
| 1589 | } | 1589 | } |
| 1590 | } | 1590 | } |
diff --git a/arch/x86_64/kernel/early_printk.c b/arch/x86_64/kernel/early_printk.c index 9cd968dd0f5a..6dffb498ccd7 100644 --- a/arch/x86_64/kernel/early_printk.c +++ b/arch/x86_64/kernel/early_printk.c | |||
| @@ -216,7 +216,7 @@ void early_printk(const char *fmt, ...) | |||
| 216 | va_end(ap); | 216 | va_end(ap); |
| 217 | } | 217 | } |
| 218 | 218 | ||
| 219 | static int keep_early; | 219 | static int __initdata keep_early; |
| 220 | 220 | ||
| 221 | int __init setup_early_printk(char *opt) | 221 | int __init setup_early_printk(char *opt) |
| 222 | { | 222 | { |
| @@ -226,8 +226,6 @@ int __init setup_early_printk(char *opt) | |||
| 226 | if (early_console_initialized) | 226 | if (early_console_initialized) |
| 227 | return -1; | 227 | return -1; |
| 228 | 228 | ||
| 229 | opt = strchr(opt, '=') + 1; | ||
| 230 | |||
| 231 | strlcpy(buf,opt,sizeof(buf)); | 229 | strlcpy(buf,opt,sizeof(buf)); |
| 232 | space = strchr(buf, ' '); | 230 | space = strchr(buf, ' '); |
| 233 | if (space) | 231 | if (space) |
diff --git a/arch/x86_64/kernel/head64.c b/arch/x86_64/kernel/head64.c index 2ea42ceb08f3..cea20a66c150 100644 --- a/arch/x86_64/kernel/head64.c +++ b/arch/x86_64/kernel/head64.c | |||
| @@ -102,7 +102,7 @@ void __init x86_64_start_kernel(char * real_mode_data) | |||
| 102 | #endif | 102 | #endif |
| 103 | s = strstr(saved_command_line, "earlyprintk="); | 103 | s = strstr(saved_command_line, "earlyprintk="); |
| 104 | if (s != NULL) | 104 | if (s != NULL) |
| 105 | setup_early_printk(s); | 105 | setup_early_printk(strchr(s, '=') + 1); |
| 106 | #ifdef CONFIG_NUMA | 106 | #ifdef CONFIG_NUMA |
| 107 | s = strstr(saved_command_line, "numa="); | 107 | s = strstr(saved_command_line, "numa="); |
| 108 | if (s != NULL) | 108 | if (s != NULL) |
