diff options
author | Bill Pemberton <wfp5p@virginia.edu> | 2013-03-20 11:46:10 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-20 19:27:55 -0400 |
commit | 29727f3bc2e691d59c521ff09b4d59a743b5d9a3 (patch) | |
tree | 7a2d05637010f9fd21bbc0adb27866a6132c04f5 | |
parent | cf2d9500a5a0df61713b56f2f40aa0b81a6f9f63 (diff) |
Revert "USB: quatech2: only write to the tty if the port is open."
This reverts commit 27b351c5546008c640b3e65152f60ca74b3706f1.
Calling tty_flip_buffer_push on an unopened tty is legal, so the
driver doesn't need track if port has been opened. Reverting this
allows the entire is_open logic to be removed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/usb/serial/quatech2.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index d643a4d4d770..00e6c9bac8a3 100644 --- a/drivers/usb/serial/quatech2.c +++ b/drivers/usb/serial/quatech2.c | |||
@@ -661,9 +661,7 @@ void qt2_process_read_urb(struct urb *urb) | |||
661 | __func__); | 661 | __func__); |
662 | break; | 662 | break; |
663 | } | 663 | } |
664 | 664 | tty_flip_buffer_push(&port->port); | |
665 | if (port_priv->is_open) | ||
666 | tty_flip_buffer_push(&port->port); | ||
667 | 665 | ||
668 | newport = *(ch + 3); | 666 | newport = *(ch + 3); |
669 | 667 | ||
@@ -706,8 +704,7 @@ void qt2_process_read_urb(struct urb *urb) | |||
706 | tty_insert_flip_string(&port->port, ch, 1); | 704 | tty_insert_flip_string(&port->port, ch, 1); |
707 | } | 705 | } |
708 | 706 | ||
709 | if (port_priv->is_open) | 707 | tty_flip_buffer_push(&port->port); |
710 | tty_flip_buffer_push(&port->port); | ||
711 | } | 708 | } |
712 | 709 | ||
713 | static void qt2_write_bulk_callback(struct urb *urb) | 710 | static void qt2_write_bulk_callback(struct urb *urb) |