diff options
author | Joe Perches <joe@perches.com> | 2012-05-08 14:56:46 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-05-09 20:49:17 -0400 |
commit | 28b29801b95de20405b2a11945cb6dfc7c6c84f9 (patch) | |
tree | 63b29d9295b2989eedf876717bc96432b72b0237 | |
parent | a599b0f54d233d0f63d6be9a2ff0049d24751669 (diff) |
802: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
Done via cocci script:
$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/802/stp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/802/stp.c b/net/802/stp.c index 15540b7323cd..2c40ba0ec116 100644 --- a/net/802/stp.c +++ b/net/802/stp.c | |||
@@ -46,7 +46,7 @@ static int stp_pdu_rcv(struct sk_buff *skb, struct net_device *dev, | |||
46 | proto = rcu_dereference(garp_protos[eh->h_dest[5] - | 46 | proto = rcu_dereference(garp_protos[eh->h_dest[5] - |
47 | GARP_ADDR_MIN]); | 47 | GARP_ADDR_MIN]); |
48 | if (proto && | 48 | if (proto && |
49 | compare_ether_addr(eh->h_dest, proto->group_address)) | 49 | !ether_addr_equal(eh->h_dest, proto->group_address)) |
50 | goto err; | 50 | goto err; |
51 | } else | 51 | } else |
52 | proto = rcu_dereference(stp_proto); | 52 | proto = rcu_dereference(stp_proto); |