diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2012-04-30 17:21:02 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2012-04-30 17:21:02 -0400 |
commit | 284f5f9dbac170b054c1e386ef92cbf654e91bba (patch) | |
tree | 74cacc94070d5590378c368fa7378d37319d07be | |
parent | 66f75a5d028beaf67c931435fdc3e7823125730c (diff) |
PCI: work around Stratus ftServer broken PCIe hierarchy
A PCIe downstream port is a P2P bridge. Its secondary interface is
a link that should lead only to device 0 (unless ARI is enabled)[1], so
we don't probe for non-zero device numbers.
Some Stratus ftServer systems have a PCIe downstream port (02:00.0) that
leads to both an upstream port (03:00.0) and a downstream port (03:01.0),
and 03:01.0 has important devices below it:
[0000:02]-+-00.0-[03-3c]--+-00.0-[04-09]--...
\-01.0-[0a-0d]--+-[USB]
+-[NIC]
+-...
Previously, we didn't enumerate device 03:01.0, so USB and the network
didn't work. This patch adds a DMI quirk to scan all device numbers,
not just 0, below a downstream port.
Based on a patch by Prarit Bhargava.
[1] PCIe spec r3.0, sec 7.3.1
CC: Myron Stowe <mstowe@redhat.com>
CC: Don Dutile <ddutile@redhat.com>
CC: James Paradis <james.paradis@stratus.com>
CC: Matthew Wilcox <matthew.r.wilcox@intel.com>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>
CC: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
-rw-r--r-- | Documentation/kernel-parameters.txt | 3 | ||||
-rw-r--r-- | arch/x86/pci/common.c | 16 | ||||
-rw-r--r-- | drivers/pci/pci.c | 3 | ||||
-rw-r--r-- | drivers/pci/probe.c | 8 | ||||
-rw-r--r-- | include/asm-generic/pci-bridge.h | 6 |
5 files changed, 34 insertions, 2 deletions
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index c1601e5a8b71..f995195409fd 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt | |||
@@ -2161,6 +2161,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted. | |||
2161 | on: Turn realloc on | 2161 | on: Turn realloc on |
2162 | realloc same as realloc=on | 2162 | realloc same as realloc=on |
2163 | noari do not use PCIe ARI. | 2163 | noari do not use PCIe ARI. |
2164 | pcie_scan_all Scan all possible PCIe devices. Otherwise we | ||
2165 | only look for one device below a PCIe downstream | ||
2166 | port. | ||
2164 | 2167 | ||
2165 | pcie_aspm= [PCIE] Forcibly enable or disable PCIe Active State Power | 2168 | pcie_aspm= [PCIE] Forcibly enable or disable PCIe Active State Power |
2166 | Management. | 2169 | Management. |
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 323481e06ef8..16c5d7835295 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c | |||
@@ -11,6 +11,7 @@ | |||
11 | #include <linux/dmi.h> | 11 | #include <linux/dmi.h> |
12 | #include <linux/slab.h> | 12 | #include <linux/slab.h> |
13 | 13 | ||
14 | #include <asm-generic/pci-bridge.h> | ||
14 | #include <asm/acpi.h> | 15 | #include <asm/acpi.h> |
15 | #include <asm/segment.h> | 16 | #include <asm/segment.h> |
16 | #include <asm/io.h> | 17 | #include <asm/io.h> |
@@ -229,6 +230,14 @@ static int __devinit assign_all_busses(const struct dmi_system_id *d) | |||
229 | } | 230 | } |
230 | #endif | 231 | #endif |
231 | 232 | ||
233 | static int __devinit set_scan_all(const struct dmi_system_id *d) | ||
234 | { | ||
235 | printk(KERN_INFO "PCI: %s detected, enabling pci=pcie_scan_all\n", | ||
236 | d->ident); | ||
237 | pci_add_flags(PCI_SCAN_ALL_PCIE_DEVS); | ||
238 | return 0; | ||
239 | } | ||
240 | |||
232 | static const struct dmi_system_id __devinitconst pciprobe_dmi_table[] = { | 241 | static const struct dmi_system_id __devinitconst pciprobe_dmi_table[] = { |
233 | #ifdef __i386__ | 242 | #ifdef __i386__ |
234 | /* | 243 | /* |
@@ -420,6 +429,13 @@ static const struct dmi_system_id __devinitconst pciprobe_dmi_table[] = { | |||
420 | DMI_MATCH(DMI_PRODUCT_NAME, "ProLiant DL585 G2"), | 429 | DMI_MATCH(DMI_PRODUCT_NAME, "ProLiant DL585 G2"), |
421 | }, | 430 | }, |
422 | }, | 431 | }, |
432 | { | ||
433 | .callback = set_scan_all, | ||
434 | .ident = "Stratus/NEC ftServer", | ||
435 | .matches = { | ||
436 | DMI_MATCH(DMI_SYS_VENDOR, "ftServer"), | ||
437 | }, | ||
438 | }, | ||
423 | {} | 439 | {} |
424 | }; | 440 | }; |
425 | 441 | ||
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 111569ccab43..8e6c38817036 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c | |||
@@ -22,6 +22,7 @@ | |||
22 | #include <linux/interrupt.h> | 22 | #include <linux/interrupt.h> |
23 | #include <linux/device.h> | 23 | #include <linux/device.h> |
24 | #include <linux/pm_runtime.h> | 24 | #include <linux/pm_runtime.h> |
25 | #include <asm-generic/pci-bridge.h> | ||
25 | #include <asm/setup.h> | 26 | #include <asm/setup.h> |
26 | #include "pci.h" | 27 | #include "pci.h" |
27 | 28 | ||
@@ -3893,6 +3894,8 @@ static int __init pci_setup(char *str) | |||
3893 | pcie_bus_config = PCIE_BUS_PERFORMANCE; | 3894 | pcie_bus_config = PCIE_BUS_PERFORMANCE; |
3894 | } else if (!strncmp(str, "pcie_bus_peer2peer", 18)) { | 3895 | } else if (!strncmp(str, "pcie_bus_peer2peer", 18)) { |
3895 | pcie_bus_config = PCIE_BUS_PEER2PEER; | 3896 | pcie_bus_config = PCIE_BUS_PEER2PEER; |
3897 | } else if (!strncmp(str, "pcie_scan_all", 13)) { | ||
3898 | pci_add_flags(PCI_SCAN_ALL_PCIE_DEVS); | ||
3896 | } else { | 3899 | } else { |
3897 | printk(KERN_ERR "PCI: Unknown option `%s'\n", | 3900 | printk(KERN_ERR "PCI: Unknown option `%s'\n", |
3898 | str); | 3901 | str); |
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 5e1ca3c58a7d..2dc8675eea1a 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c | |||
@@ -10,6 +10,7 @@ | |||
10 | #include <linux/module.h> | 10 | #include <linux/module.h> |
11 | #include <linux/cpumask.h> | 11 | #include <linux/cpumask.h> |
12 | #include <linux/pci-aspm.h> | 12 | #include <linux/pci-aspm.h> |
13 | #include <asm-generic/pci-bridge.h> | ||
13 | #include "pci.h" | 14 | #include "pci.h" |
14 | 15 | ||
15 | #define CARDBUS_LATENCY_TIMER 176 /* secondary latency timer */ | 16 | #define CARDBUS_LATENCY_TIMER 176 /* secondary latency timer */ |
@@ -1395,10 +1396,13 @@ static unsigned no_next_fn(struct pci_dev *dev, unsigned fn) | |||
1395 | static int only_one_child(struct pci_bus *bus) | 1396 | static int only_one_child(struct pci_bus *bus) |
1396 | { | 1397 | { |
1397 | struct pci_dev *parent = bus->self; | 1398 | struct pci_dev *parent = bus->self; |
1399 | |||
1398 | if (!parent || !pci_is_pcie(parent)) | 1400 | if (!parent || !pci_is_pcie(parent)) |
1399 | return 0; | 1401 | return 0; |
1400 | if (parent->pcie_type == PCI_EXP_TYPE_ROOT_PORT || | 1402 | if (parent->pcie_type == PCI_EXP_TYPE_ROOT_PORT) |
1401 | parent->pcie_type == PCI_EXP_TYPE_DOWNSTREAM) | 1403 | return 1; |
1404 | if (parent->pcie_type == PCI_EXP_TYPE_DOWNSTREAM && | ||
1405 | !pci_has_flag(PCI_SCAN_ALL_PCIE_DEVS)) | ||
1402 | return 1; | 1406 | return 1; |
1403 | return 0; | 1407 | return 0; |
1404 | } | 1408 | } |
diff --git a/include/asm-generic/pci-bridge.h b/include/asm-generic/pci-bridge.h index a5b5d5a89a4f..20db2e5a0a69 100644 --- a/include/asm-generic/pci-bridge.h +++ b/include/asm-generic/pci-bridge.h | |||
@@ -30,6 +30,12 @@ enum { | |||
30 | PCI_ENABLE_PROC_DOMAINS = 0x00000010, | 30 | PCI_ENABLE_PROC_DOMAINS = 0x00000010, |
31 | /* ... except for domain 0 */ | 31 | /* ... except for domain 0 */ |
32 | PCI_COMPAT_DOMAIN_0 = 0x00000020, | 32 | PCI_COMPAT_DOMAIN_0 = 0x00000020, |
33 | |||
34 | /* PCIe downstream ports are bridges that normally lead to only a | ||
35 | * device 0, but if this is set, we scan all possible devices, not | ||
36 | * just device 0. | ||
37 | */ | ||
38 | PCI_SCAN_ALL_PCIE_DEVS = 0x00000040, | ||
33 | }; | 39 | }; |
34 | 40 | ||
35 | #ifdef CONFIG_PCI | 41 | #ifdef CONFIG_PCI |