diff options
| author | Sam Bobroff <sam.bobroff@au1.ibm.com> | 2014-09-18 19:40:41 -0400 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2014-09-22 07:21:29 -0400 |
| commit | 27fbe64bfa63cfb9da025975b59d96568caa2d53 (patch) | |
| tree | a7cc2aac710c41561e5eed5dd296eda2a777820b | |
| parent | 85c8555ff07ef09261bd50d603cd4290cff5a8cc (diff) | |
KVM: correct null pid check in kvm_vcpu_yield_to()
Correct a simple mistake of checking the wrong variable
before a dereference, resulting in the dereference not being
properly protected by rcu_dereference().
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | virt/kvm/kvm_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 96ec6226e4ab..95519bc959ed 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c | |||
| @@ -1725,7 +1725,7 @@ int kvm_vcpu_yield_to(struct kvm_vcpu *target) | |||
| 1725 | rcu_read_lock(); | 1725 | rcu_read_lock(); |
| 1726 | pid = rcu_dereference(target->pid); | 1726 | pid = rcu_dereference(target->pid); |
| 1727 | if (pid) | 1727 | if (pid) |
| 1728 | task = get_pid_task(target->pid, PIDTYPE_PID); | 1728 | task = get_pid_task(pid, PIDTYPE_PID); |
| 1729 | rcu_read_unlock(); | 1729 | rcu_read_unlock(); |
| 1730 | if (!task) | 1730 | if (!task) |
| 1731 | return ret; | 1731 | return ret; |
