diff options
author | Arnaud Ebalard <arno@natisbad.org> | 2013-11-29 15:27:25 -0500 |
---|---|---|
committer | Jason Cooper <jason@lakedaemon.net> | 2013-12-01 16:49:51 -0500 |
commit | 261e7735d0ed0f0916b3edc528e206af5196688d (patch) | |
tree | 9d76ace9349ba29b55d826eca3556453356a064a | |
parent | bd22bb23919e6727967e90eb89bb41ab790bcd2d (diff) |
ARM: kirkwood: NETGEAR ReadyNAS Duo v2 .dts cleanup
The patch does some cleanup work on NETGEAR ReadyNAS Duo v2 .dts
file. Changes are listed below:
- Converted from value to macros for GPIO voltage level
- Converted all numeric input key values to macros
- Made button names more explicit
- Document ethernet PHY (Marvell 88E1318) via a comment
- Added header for the file to describe content and author
- Made G762 clock node name unique by including g762 in it
- Fixed all node names and labels to use respectively '-' and '_'
- Changed order of included files from general to local
- Removed useless clocks and gpio-keys properties
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
-rw-r--r-- | arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts | 51 |
1 files changed, 29 insertions, 22 deletions
diff --git a/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts b/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts index 362770229c1b..d408adc3974d 100644 --- a/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +++ b/arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts | |||
@@ -1,5 +1,17 @@ | |||
1 | /* | ||
2 | * Device Tree file for NETGEAR ReadyNAS Duo v2 | ||
3 | * | ||
4 | * Copyright (C) 2013, Arnaud EBALARD <arno@natisbad.org> | ||
5 | * | ||
6 | * This program is free software; you can redistribute it and/or | ||
7 | * modify it under the terms of the GNU General Public License | ||
8 | * as published by the Free Software Foundation; either version | ||
9 | * 2 of the License, or (at your option) any later version. | ||
10 | */ | ||
11 | |||
1 | /dts-v1/; | 12 | /dts-v1/; |
2 | 13 | ||
14 | #include <dt-bindings/input/input.h> | ||
3 | #include <dt-bindings/gpio/gpio.h> | 15 | #include <dt-bindings/gpio/gpio.h> |
4 | #include "kirkwood.dtsi" | 16 | #include "kirkwood.dtsi" |
5 | #include "kirkwood-6282.dtsi" | 17 | #include "kirkwood-6282.dtsi" |
@@ -68,10 +80,7 @@ | |||
68 | }; | 80 | }; |
69 | 81 | ||
70 | clocks { | 82 | clocks { |
71 | #address-cells = <1>; | 83 | g762_clk: g762-oscillator { |
72 | #size-cells = <0>; | ||
73 | |||
74 | g762_clk: fixedclk { | ||
75 | compatible = "fixed-clock"; | 84 | compatible = "fixed-clock"; |
76 | #clock-cells = <0>; | 85 | #clock-cells = <0>; |
77 | clock-frequency = <8192>; | 86 | clock-frequency = <8192>; |
@@ -117,49 +126,47 @@ | |||
117 | 126 | ||
118 | power_led { | 127 | power_led { |
119 | label = "status:blue:power_led"; | 128 | label = "status:blue:power_led"; |
120 | gpios = <&gpio0 31 1>; /* GPIO 31 Active Low */ | 129 | gpios = <&gpio0 31 GPIO_ACTIVE_LOW>; |
121 | default-state = "keep"; | 130 | default-state = "keep"; |
122 | }; | 131 | }; |
123 | activity_led { | 132 | activity_led { |
124 | label = "status:blue:activity_led"; | 133 | label = "status:blue:activity_led"; |
125 | gpios = <&gpio1 6 1>; /* GPIO 38 Active Low */ | 134 | gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; |
126 | }; | 135 | }; |
127 | disk1_led { | 136 | disk1_led { |
128 | label = "status:blue:disk1_led"; | 137 | label = "status:blue:disk1_led"; |
129 | gpios = <&gpio0 23 1>; /* GPIO 23 Active Low */ | 138 | gpios = <&gpio0 23 GPIO_ACTIVE_LOW>; |
130 | }; | 139 | }; |
131 | disk2_led { | 140 | disk2_led { |
132 | label = "status:blue:disk2_led"; | 141 | label = "status:blue:disk2_led"; |
133 | gpios = <&gpio0 22 1>; /* GPIO 22 Active Low */ | 142 | gpios = <&gpio0 22 GPIO_ACTIVE_LOW>; |
134 | }; | 143 | }; |
135 | backup_led { | 144 | backup_led { |
136 | label = "status:blue:backup_led"; | 145 | label = "status:blue:backup_led"; |
137 | gpios = <&gpio0 29 1>; /* GPIO 29 Active Low*/ | 146 | gpios = <&gpio0 29 GPIO_ACTIVE_LOW>; |
138 | }; | 147 | }; |
139 | }; | 148 | }; |
140 | 149 | ||
141 | gpio_keys { | 150 | gpio-keys { |
142 | compatible = "gpio-keys"; | 151 | compatible = "gpio-keys"; |
143 | #address-cells = <1>; | ||
144 | #size-cells = <0>; | ||
145 | pinctrl-0 = <&pmx_button_power &pmx_button_backup | 152 | pinctrl-0 = <&pmx_button_power &pmx_button_backup |
146 | &pmx_button_reset>; | 153 | &pmx_button_reset>; |
147 | pinctrl-names = "default"; | 154 | pinctrl-names = "default"; |
148 | 155 | ||
149 | button@1 { | 156 | power-button { |
150 | label = "Power Button"; | 157 | label = "Power Button"; |
151 | linux,code = <116>; /* KEY_POWER */ | 158 | linux,code = <KEY_POWER>; |
152 | gpios = <&gpio1 15 1>; | 159 | gpios = <&gpio1 15 GPIO_ACTIVE_LOW>; |
153 | }; | 160 | }; |
154 | button@2 { | 161 | reset-button { |
155 | label = "Reset Button"; | 162 | label = "Reset Button"; |
156 | linux,code = <0x198>; /* KEY_RESTART */ | 163 | linux,code = <KEY_RESTART>; |
157 | gpios = <&gpio0 13 1>; | 164 | gpios = <&gpio0 13 GPIO_ACTIVE_LOW>; |
158 | }; | 165 | }; |
159 | button@3 { | 166 | backup-button { |
160 | label = "Backup Button"; | 167 | label = "Backup Button"; |
161 | linux,code = <133>; /* KEY_COPY */ | 168 | linux,code = <KEY_COPY>; |
162 | gpios = <&gpio1 13 1>; | 169 | gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; |
163 | }; | 170 | }; |
164 | }; | 171 | }; |
165 | 172 | ||
@@ -222,7 +229,7 @@ | |||
222 | &mdio { | 229 | &mdio { |
223 | status = "okay"; | 230 | status = "okay"; |
224 | 231 | ||
225 | ethphy0: ethernet-phy@0 { | 232 | ethphy0: ethernet-phy@0 { /* Marvell 88E1318 */ |
226 | device_type = "ethernet-phy"; | 233 | device_type = "ethernet-phy"; |
227 | reg = <0>; | 234 | reg = <0>; |
228 | }; | 235 | }; |