diff options
author | Axel Lin <axel.lin@ingics.com> | 2015-03-31 20:44:32 -0400 |
---|---|---|
committer | Kishon Vijay Abraham I <kishon@ti.com> | 2015-04-03 08:46:21 -0400 |
commit | 247e21c613649f34bcf2f71e57e813e6ed18b458 (patch) | |
tree | 25c8c056422059dc3b6a281200e7276391a0dcb9 | |
parent | fbea230e7884044ee2e84bb28f6879dc30e1db24 (diff) |
phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate
The of_xlate callback should return ERR_PTR on error.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
-rw-r--r-- | drivers/phy/phy-spear1310-miphy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c index 9f47fae7eecb..65ae640cfbd1 100644 --- a/drivers/phy/phy-spear1310-miphy.c +++ b/drivers/phy/phy-spear1310-miphy.c | |||
@@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev, | |||
192 | 192 | ||
193 | if (args->args_count < 1) { | 193 | if (args->args_count < 1) { |
194 | dev_err(dev, "DT did not pass correct no of args\n"); | 194 | dev_err(dev, "DT did not pass correct no of args\n"); |
195 | return NULL; | 195 | return ERR_PTR(-ENODEV); |
196 | } | 196 | } |
197 | 197 | ||
198 | priv->mode = args->args[0]; | 198 | priv->mode = args->args[0]; |
199 | 199 | ||
200 | if (priv->mode != SATA && priv->mode != PCIE) { | 200 | if (priv->mode != SATA && priv->mode != PCIE) { |
201 | dev_err(dev, "DT did not pass correct phy mode\n"); | 201 | dev_err(dev, "DT did not pass correct phy mode\n"); |
202 | return NULL; | 202 | return ERR_PTR(-ENODEV); |
203 | } | 203 | } |
204 | 204 | ||
205 | return priv->phy; | 205 | return priv->phy; |