aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Walmsley <pwalmsley@nvidia.com>2013-12-09 21:00:12 -0500
committerThierry Reding <treding@nvidia.com>2013-12-19 03:29:52 -0500
commit23a0e27aacad6b97598dd6786f782e4b6dd86096 (patch)
treebe0145a2eca936ce171ca1d8f1fab1a91f4e7d4d
parent8e0d788c6feeb13cbf312acaefa0e91cece0677b (diff)
gpu: host1x: clk_round_rate() can return a zero upon error
Treat both negative and zero return values from clk_round_rate() as errors. This is needed since subsequent patches will convert clk_round_rate()'s return value to be an unsigned type, rather than a signed type, since some clock sources can generate rates higher than (2^31)-1 Hz. Eventually, when calling clk_round_rate(), only a return value of zero will be considered a error. All other values will be considered valid rates. The comparison against values less than 0 is kept to preserve the correct behavior in the meantime. Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com> Cc: Mikko Perttunen <mperttunen@nvidia.com> Cc: Arto Merilainen <amerilainen@nvidia.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Terje Bergström <tbergstrom@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com>
-rw-r--r--drivers/gpu/drm/tegra/hdmi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 7f6253ea5cb5..0cfc94f8d14c 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -960,7 +960,7 @@ static int tegra_output_hdmi_check_mode(struct tegra_output *output,
960 parent = clk_get_parent(hdmi->clk_parent); 960 parent = clk_get_parent(hdmi->clk_parent);
961 961
962 err = clk_round_rate(parent, pclk * 4); 962 err = clk_round_rate(parent, pclk * 4);
963 if (err < 0) 963 if (err <= 0)
964 *status = MODE_NOCLOCK; 964 *status = MODE_NOCLOCK;
965 else 965 else
966 *status = MODE_OK; 966 *status = MODE_OK;