diff options
author | Emil Tantilov <emil.s.tantilov@intel.com> | 2011-10-19 03:41:58 -0400 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2011-11-02 19:55:15 -0400 |
commit | 232ef6bc451de2bc17c22fd116838cd89b94e1c1 (patch) | |
tree | 88fe56de1620255842b800431544e54c8c15cf6c | |
parent | d5a0e3640c05b7d07c548f9f8f986dbb87cfad98 (diff) |
ixgbe: Fix link issues caused by a reset while interface is down
Interface fails to obtain link on 82599 SFP in the following scenario:
1. Set advertised speed to GB:
ethtool -s eth0 advertise 0x20
2. Bring interface down
ip link set eth0 down
3. Issue any command that leads to a reset:
ethtool -t eth0
4. Bring link back up:
ip link set eth0 up
Following patch makes sure that the driver flaps the Tx laser every time
ixgbe_start_hw() is called, and not only when the speed is set.
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r-- | drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 09b8e88b2999..b7abf43a877e 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | |||
@@ -6125,7 +6125,6 @@ static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter) | |||
6125 | autoneg = hw->phy.autoneg_advertised; | 6125 | autoneg = hw->phy.autoneg_advertised; |
6126 | if ((!autoneg) && (hw->mac.ops.get_link_capabilities)) | 6126 | if ((!autoneg) && (hw->mac.ops.get_link_capabilities)) |
6127 | hw->mac.ops.get_link_capabilities(hw, &autoneg, &negotiation); | 6127 | hw->mac.ops.get_link_capabilities(hw, &autoneg, &negotiation); |
6128 | hw->mac.autotry_restart = false; | ||
6129 | if (hw->mac.ops.setup_link) | 6128 | if (hw->mac.ops.setup_link) |
6130 | hw->mac.ops.setup_link(hw, autoneg, negotiation, true); | 6129 | hw->mac.ops.setup_link(hw, autoneg, negotiation, true); |
6131 | 6130 | ||