diff options
author | Syam Sidhardhan <syamsidhardh@gmail.com> | 2013-02-24 17:31:48 -0500 |
---|---|---|
committer | Patrik Jakobsson <patrik.r.jakobsson@gmail.com> | 2013-03-13 17:37:32 -0400 |
commit | 22ccb2a146f92b81cc5731db8c1ee2316cca3576 (patch) | |
tree | 0aabe6511bcbcfa40c9dd357181798bdfbe7b709 | |
parent | bc6a541941df6e05b0c53133537ce4cf31336c3f (diff) |
gma500: medfield: Fix possible NULL pointer dereference
The use of pointer sender should be after the NULL check.
Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
-rw-r--r-- | drivers/gpu/drm/gma500/mdfld_dsi_output.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c index 2d4ab48f07a2..3abf8315f57c 100644 --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c | |||
@@ -92,8 +92,8 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe) | |||
92 | { | 92 | { |
93 | struct mdfld_dsi_pkg_sender *sender = | 93 | struct mdfld_dsi_pkg_sender *sender = |
94 | mdfld_dsi_get_pkg_sender(dsi_config); | 94 | mdfld_dsi_get_pkg_sender(dsi_config); |
95 | struct drm_device *dev = sender->dev; | 95 | struct drm_device *dev; |
96 | struct drm_psb_private *dev_priv = dev->dev_private; | 96 | struct drm_psb_private *dev_priv; |
97 | u32 gen_ctrl_val; | 97 | u32 gen_ctrl_val; |
98 | 98 | ||
99 | if (!sender) { | 99 | if (!sender) { |
@@ -101,6 +101,9 @@ void mdfld_dsi_brightness_init(struct mdfld_dsi_config *dsi_config, int pipe) | |||
101 | return; | 101 | return; |
102 | } | 102 | } |
103 | 103 | ||
104 | dev = sender->dev; | ||
105 | dev_priv = dev->dev_private; | ||
106 | |||
104 | /* Set default display backlight value to 85% (0xd8)*/ | 107 | /* Set default display backlight value to 85% (0xd8)*/ |
105 | mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, | 108 | mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, |
106 | true); | 109 | true); |