aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMárton Németh <nm127@freemail.hu>2009-12-11 18:05:10 -0500
committerMauro Carvalho Chehab <mchehab@redhat.com>2009-12-16 06:27:53 -0500
commit2184dda0d4814fc1baeb6cfa1f82ec8015df88b0 (patch)
treec1280d681d863573a48cbe245c87289b49f2cfcf
parent3839a0dc1c012558281878436a5807b9abe9afad (diff)
V4L/DVB (13683): sanio-ms: clean up init, exit and id_table
MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make module_init static and mark it with __init. Make module_exit static and mark it with __exit. Mark probe functions with __devinit. Make id table static and mark with __devinitconst. This will eliminate the following sparse warnings (see "make C=1"): * smsdvb.c:668:5: warning: symbol 'smsdvb_module_init' was not declared. Should it be static? * smsdvb.c:682:6: warning: symbol 'smsdvb_module_exit' was not declared. Should it be static? * smsusb.c:491:22: warning: symbol 'smsusb_id_table' was not declared. Should it be static? * smsusb.c:567:5: warning: symbol 'smsusb_module_init' was not declared. Should it be static? * smsusb.c:578:6: warning: symbol 'smsusb_module_exit' was not declared. Should it be static? * smssdio.c:341:5: warning: symbol 'smssdio_module_init' was not declared. Should it be static? * smssdio.c:353:6: warning: symbol 'smssdio_module_exit' was not declared. Should it be static? Signed-off-by: Márton Németh <nm127@freemail.hu> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r--drivers/media/dvb/siano/smsdvb.c4
-rw-r--r--drivers/media/dvb/siano/smssdio.c8
-rw-r--r--drivers/media/dvb/siano/smsusb.c8
3 files changed, 10 insertions, 10 deletions
diff --git a/drivers/media/dvb/siano/smsdvb.c b/drivers/media/dvb/siano/smsdvb.c
index 266033ae2784..68bf9fbd8fed 100644
--- a/drivers/media/dvb/siano/smsdvb.c
+++ b/drivers/media/dvb/siano/smsdvb.c
@@ -662,7 +662,7 @@ adapter_error:
662 return rc; 662 return rc;
663} 663}
664 664
665int smsdvb_module_init(void) 665static int __init smsdvb_module_init(void)
666{ 666{
667 int rc; 667 int rc;
668 668
@@ -676,7 +676,7 @@ int smsdvb_module_init(void)
676 return rc; 676 return rc;
677} 677}
678 678
679void smsdvb_module_exit(void) 679static void __exit smsdvb_module_exit(void)
680{ 680{
681 smscore_unregister_hotplug(smsdvb_hotplug); 681 smscore_unregister_hotplug(smsdvb_hotplug);
682 682
diff --git a/drivers/media/dvb/siano/smssdio.c b/drivers/media/dvb/siano/smssdio.c
index 24206cbda264..195244a3e69b 100644
--- a/drivers/media/dvb/siano/smssdio.c
+++ b/drivers/media/dvb/siano/smssdio.c
@@ -48,7 +48,7 @@
48#define SMSSDIO_INT 0x04 48#define SMSSDIO_INT 0x04
49#define SMSSDIO_BLOCK_SIZE 128 49#define SMSSDIO_BLOCK_SIZE 128
50 50
51static const struct sdio_device_id smssdio_ids[] = { 51static const struct sdio_device_id smssdio_ids[] __devinitconst = {
52 {SDIO_DEVICE(SDIO_VENDOR_ID_SIANO, SDIO_DEVICE_ID_SIANO_STELLAR), 52 {SDIO_DEVICE(SDIO_VENDOR_ID_SIANO, SDIO_DEVICE_ID_SIANO_STELLAR),
53 .driver_data = SMS1XXX_BOARD_SIANO_STELLAR}, 53 .driver_data = SMS1XXX_BOARD_SIANO_STELLAR},
54 {SDIO_DEVICE(SDIO_VENDOR_ID_SIANO, SDIO_DEVICE_ID_SIANO_NOVA_A0), 54 {SDIO_DEVICE(SDIO_VENDOR_ID_SIANO, SDIO_DEVICE_ID_SIANO_NOVA_A0),
@@ -222,7 +222,7 @@ static void smssdio_interrupt(struct sdio_func *func)
222 smscore_onresponse(smsdev->coredev, cb); 222 smscore_onresponse(smsdev->coredev, cb);
223} 223}
224 224
225static int smssdio_probe(struct sdio_func *func, 225static int __devinit smssdio_probe(struct sdio_func *func,
226 const struct sdio_device_id *id) 226 const struct sdio_device_id *id)
227{ 227{
228 int ret; 228 int ret;
@@ -338,7 +338,7 @@ static struct sdio_driver smssdio_driver = {
338/* Module functions */ 338/* Module functions */
339/*******************************************************************/ 339/*******************************************************************/
340 340
341int smssdio_module_init(void) 341static int __init smssdio_module_init(void)
342{ 342{
343 int ret = 0; 343 int ret = 0;
344 344
@@ -350,7 +350,7 @@ int smssdio_module_init(void)
350 return ret; 350 return ret;
351} 351}
352 352
353void smssdio_module_exit(void) 353static void __exit smssdio_module_exit(void)
354{ 354{
355 sdio_unregister_driver(&smssdio_driver); 355 sdio_unregister_driver(&smssdio_driver);
356} 356}
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
index 6b03dbf3635e..5eac27287d9c 100644
--- a/drivers/media/dvb/siano/smsusb.c
+++ b/drivers/media/dvb/siano/smsusb.c
@@ -390,7 +390,7 @@ static int smsusb_init_device(struct usb_interface *intf, int board_id)
390 return rc; 390 return rc;
391} 391}
392 392
393static int smsusb_probe(struct usb_interface *intf, 393static int __devinit smsusb_probe(struct usb_interface *intf,
394 const struct usb_device_id *id) 394 const struct usb_device_id *id)
395{ 395{
396 struct usb_device *udev = interface_to_usbdev(intf); 396 struct usb_device *udev = interface_to_usbdev(intf);
@@ -484,7 +484,7 @@ static int smsusb_resume(struct usb_interface *intf)
484 return 0; 484 return 0;
485} 485}
486 486
487struct usb_device_id smsusb_id_table[] = { 487static const struct usb_device_id smsusb_id_table[] __devinitconst = {
488 { USB_DEVICE(0x187f, 0x0010), 488 { USB_DEVICE(0x187f, 0x0010),
489 .driver_info = SMS1XXX_BOARD_SIANO_STELLAR }, 489 .driver_info = SMS1XXX_BOARD_SIANO_STELLAR },
490 { USB_DEVICE(0x187f, 0x0100), 490 { USB_DEVICE(0x187f, 0x0100),
@@ -560,7 +560,7 @@ static struct usb_driver smsusb_driver = {
560 .resume = smsusb_resume, 560 .resume = smsusb_resume,
561}; 561};
562 562
563int smsusb_module_init(void) 563static int __init smsusb_module_init(void)
564{ 564{
565 int rc = usb_register(&smsusb_driver); 565 int rc = usb_register(&smsusb_driver);
566 if (rc) 566 if (rc)
@@ -571,7 +571,7 @@ int smsusb_module_init(void)
571 return rc; 571 return rc;
572} 572}
573 573
574void smsusb_module_exit(void) 574static void __exit smsusb_module_exit(void)
575{ 575{
576 /* Regular USB Cleanup */ 576 /* Regular USB Cleanup */
577 usb_deregister(&smsusb_driver); 577 usb_deregister(&smsusb_driver);