diff options
| author | Nishanth Menon <nm@ti.com> | 2014-08-18 12:56:55 -0400 |
|---|---|---|
| committer | Tero Kristo <t-kristo@ti.com> | 2014-08-21 11:04:16 -0400 |
| commit | 20411dad75ece9a613af715df4489e60990c4017 (patch) | |
| tree | a9d8dfbb92732c28b24737916f2aaf84bb703aa0 | |
| parent | 2f1032517623b70920d99529e5c87c8c680ab8bf (diff) | |
clk: ti: dra7-atl: Provide error check for incoming parameters in set_rate
Check for valid parameters in check rate. Else, we end up getting
errors.
This occurs as part of the inital clock tree update of child clock
nodes where new_rate could be 0 for non functional clocks.
Fixes: 9ac33b0ce81fa48 (" CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
| -rw-r--r-- | drivers/clk/ti/clk-dra7-atl.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c index 4a65b410e4d5..af29359677da 100644 --- a/drivers/clk/ti/clk-dra7-atl.c +++ b/drivers/clk/ti/clk-dra7-atl.c | |||
| @@ -139,9 +139,13 @@ static long atl_clk_round_rate(struct clk_hw *hw, unsigned long rate, | |||
| 139 | static int atl_clk_set_rate(struct clk_hw *hw, unsigned long rate, | 139 | static int atl_clk_set_rate(struct clk_hw *hw, unsigned long rate, |
| 140 | unsigned long parent_rate) | 140 | unsigned long parent_rate) |
| 141 | { | 141 | { |
| 142 | struct dra7_atl_desc *cdesc = to_atl_desc(hw); | 142 | struct dra7_atl_desc *cdesc; |
| 143 | u32 divider; | 143 | u32 divider; |
| 144 | 144 | ||
| 145 | if (!hw || !rate) | ||
| 146 | return -EINVAL; | ||
| 147 | |||
| 148 | cdesc = to_atl_desc(hw); | ||
| 145 | divider = ((parent_rate + rate / 2) / rate) - 1; | 149 | divider = ((parent_rate + rate / 2) / rate) - 1; |
| 146 | if (divider > DRA7_ATL_DIVIDER_MASK) | 150 | if (divider > DRA7_ATL_DIVIDER_MASK) |
| 147 | divider = DRA7_ATL_DIVIDER_MASK; | 151 | divider = DRA7_ATL_DIVIDER_MASK; |