diff options
author | Mike Qiu <qiudayu@linux.vnet.ibm.com> | 2013-08-12 02:15:36 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2013-08-14 01:33:16 -0400 |
commit | 202127031a14f244c15ae4434993d36bd10a439c (patch) | |
tree | 16b66ff8f9d1fdb0dfc9a1f4dba33634c459a71a | |
parent | 5ba840ec54be71ed01ba5d18e30d6678ea27f2c6 (diff) |
powerpc/eeh: powerpc/eeh: Fix undefined variable
changes for V4:
- changes the type of frozen_pe_no from %d to %llu
in pr_devel()
'pe_no' hasn't been defined, it should be an typo error,
it should be 'frozen_pe_no'.
Also '__func__' has missed in IODA_EEH_DBG(),
For safety reasons, use pr_devel() directly, instead
of use IODA_EEH_DBG()
Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r-- | arch/powerpc/platforms/powernv/eeh-ioda.c | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c index 0cd1c4a71755..cf42e74514fa 100644 --- a/arch/powerpc/platforms/powernv/eeh-ioda.c +++ b/arch/powerpc/platforms/powernv/eeh-ioda.c | |||
@@ -36,13 +36,6 @@ | |||
36 | #include "powernv.h" | 36 | #include "powernv.h" |
37 | #include "pci.h" | 37 | #include "pci.h" |
38 | 38 | ||
39 | /* Debugging option */ | ||
40 | #ifdef IODA_EEH_DBG_ON | ||
41 | #define IODA_EEH_DBG(args...) pr_info(args) | ||
42 | #else | ||
43 | #define IODA_EEH_DBG(args...) | ||
44 | #endif | ||
45 | |||
46 | static char *hub_diag = NULL; | 39 | static char *hub_diag = NULL; |
47 | static int ioda_eeh_nb_init = 0; | 40 | static int ioda_eeh_nb_init = 0; |
48 | 41 | ||
@@ -823,17 +816,17 @@ static int ioda_eeh_next_error(struct eeh_pe **pe) | |||
823 | 816 | ||
824 | /* If OPAL API returns error, we needn't proceed */ | 817 | /* If OPAL API returns error, we needn't proceed */ |
825 | if (rc != OPAL_SUCCESS) { | 818 | if (rc != OPAL_SUCCESS) { |
826 | IODA_EEH_DBG("%s: Invalid return value on " | 819 | pr_devel("%s: Invalid return value on " |
827 | "PHB#%x (0x%lx) from opal_pci_next_error", | 820 | "PHB#%x (0x%lx) from opal_pci_next_error", |
828 | __func__, hose->global_number, rc); | 821 | __func__, hose->global_number, rc); |
829 | continue; | 822 | continue; |
830 | } | 823 | } |
831 | 824 | ||
832 | /* If the PHB doesn't have error, stop processing */ | 825 | /* If the PHB doesn't have error, stop processing */ |
833 | if (err_type == OPAL_EEH_NO_ERROR || | 826 | if (err_type == OPAL_EEH_NO_ERROR || |
834 | severity == OPAL_EEH_SEV_NO_ERROR) { | 827 | severity == OPAL_EEH_SEV_NO_ERROR) { |
835 | IODA_EEH_DBG("%s: No error found on PHB#%x\n", | 828 | pr_devel("%s: No error found on PHB#%x\n", |
836 | __func__, hose->global_number); | 829 | __func__, hose->global_number); |
837 | continue; | 830 | continue; |
838 | } | 831 | } |
839 | 832 | ||
@@ -842,8 +835,9 @@ static int ioda_eeh_next_error(struct eeh_pe **pe) | |||
842 | * highest priority reported upon multiple errors on the | 835 | * highest priority reported upon multiple errors on the |
843 | * specific PHB. | 836 | * specific PHB. |
844 | */ | 837 | */ |
845 | IODA_EEH_DBG("%s: Error (%d, %d, %d) on PHB#%x\n", | 838 | pr_devel("%s: Error (%d, %d, %llu) on PHB#%x\n", |
846 | err_type, severity, pe_no, hose->global_number); | 839 | __func__, err_type, severity, |
840 | frozen_pe_no, hose->global_number); | ||
847 | switch (err_type) { | 841 | switch (err_type) { |
848 | case OPAL_EEH_IOC_ERROR: | 842 | case OPAL_EEH_IOC_ERROR: |
849 | if (severity == OPAL_EEH_SEV_IOC_DEAD) { | 843 | if (severity == OPAL_EEH_SEV_IOC_DEAD) { |