aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2014-07-11 13:30:10 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-07-23 01:05:15 -0400
commit1fcc9d1cf3c72ec7c7a3253b50b8e44f95f3f616 (patch)
treec41f23d11c84faa4f5d6ca945fe368312970f5e3
parent9a603f48fa2e0760d043bd66f4dc62055ea8c745 (diff)
drm/i915: Add a FIXME about drrs/psr interactions
Can't review this right now due to lack of DRRS code. Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Vandana Kannan <vandana.kannan@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--drivers/gpu/drm/i915/intel_dp.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 6359005180f0..4017406b810d 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4104,6 +4104,11 @@ void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate)
4104 return; 4104 return;
4105 } 4105 }
4106 4106
4107 /*
4108 * FIXME: This needs proper synchronization with psr state. But really
4109 * hard to tell without seeing the user of this function of this code.
4110 * Check locking and ordering once that lands.
4111 */
4107 if (INTEL_INFO(dev)->gen < 8 && intel_edp_is_psr_enabled(dev)) { 4112 if (INTEL_INFO(dev)->gen < 8 && intel_edp_is_psr_enabled(dev)) {
4108 DRM_DEBUG_KMS("DRRS is disabled as PSR is enabled\n"); 4113 DRM_DEBUG_KMS("DRRS is disabled as PSR is enabled\n");
4109 return; 4114 return;