diff options
author | Philipp Zabel <p.zabel@pengutronix.de> | 2013-06-21 04:57:20 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-06-24 19:01:06 -0400 |
commit | 1f941ae8977bc34b521c976090dfd0ad24fa91f9 (patch) | |
tree | aabbdf4e94f84e537cc4b0936d0173b947179a03 | |
parent | 0b92e2f40378d4426145467301f9a249bba5907d (diff) |
staging: drm/imx: ipuv3-crtc: immediately update crtc->fb in ipu_page_flip
Since commit 8cf1e9811471f2910fa38dc1b28e1789080ba961
("drm: Add consistency check for page-flipping") drm_mode_page_flip_ioctl
contains a WARN_ON that triggers if the .page_flip callback didn't update
the crtc->fb pointer to the new framebuffer immediately.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/imx-drm/ipuv3-crtc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index abcdaefce8e0..4a7eedfafbdb 100644 --- a/drivers/staging/imx-drm/ipuv3-crtc.c +++ b/drivers/staging/imx-drm/ipuv3-crtc.c | |||
@@ -147,6 +147,7 @@ static int ipu_page_flip(struct drm_crtc *crtc, | |||
147 | 147 | ||
148 | ipu_crtc->newfb = fb; | 148 | ipu_crtc->newfb = fb; |
149 | ipu_crtc->page_flip_event = event; | 149 | ipu_crtc->page_flip_event = event; |
150 | crtc->fb = fb; | ||
150 | 151 | ||
151 | return 0; | 152 | return 0; |
152 | } | 153 | } |
@@ -329,7 +330,6 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id) | |||
329 | imx_drm_handle_vblank(ipu_crtc->imx_crtc); | 330 | imx_drm_handle_vblank(ipu_crtc->imx_crtc); |
330 | 331 | ||
331 | if (ipu_crtc->newfb) { | 332 | if (ipu_crtc->newfb) { |
332 | ipu_crtc->base.fb = ipu_crtc->newfb; | ||
333 | ipu_crtc->newfb = NULL; | 333 | ipu_crtc->newfb = NULL; |
334 | ipu_drm_set_base(&ipu_crtc->base, 0, 0); | 334 | ipu_drm_set_base(&ipu_crtc->base, 0, 0); |
335 | ipu_crtc_handle_pageflip(ipu_crtc); | 335 | ipu_crtc_handle_pageflip(ipu_crtc); |