Merge branch 'perf/test' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing into perf/core

7 files changed, 257 insertions, 145 deletions

diff --git a/include/trace/events/lock.h b/include/trace/events/lock.h
index 5c1dcfc16c60..2821b86de63b 100644
--- a/include/trace/events/lock.h
+++ b/include/trace/events/lock.h
@@ -35,15 +35,15 @@ TRACE_EVENT(lock_acquire,
                   __get_str(name))
 );
 
-TRACE_EVENT(lock_release,
+DECLARE_EVENT_CLASS(lock,
 
-        TP_PROTO(struct lockdep_map *lock, int nested, unsigned long ip),
+        TP_PROTO(struct lockdep_map *lock, unsigned long ip),
 
-        TP_ARGS(lock, nested, ip),
+        TP_ARGS(lock, ip),
 
         TP_STRUCT__entry(
-                __string(name, lock->name)
-                __field(void *, lockdep_addr)
+                __string(       name,   lock->name      )
+                __field(        void *, lockdep_addr    )
         ),
 
         TP_fast_assign(
@@ -51,51 +51,30 @@ TRACE_EVENT(lock_release,
                 __entry->lockdep_addr = lock;
         ),
 
-        TP_printk("%p %s",
-                  __entry->lockdep_addr, __get_str(name))
+        TP_printk("%p %s",  __entry->lockdep_addr, __get_str(name))
 );
 
-#ifdef CONFIG_LOCK_STAT
-
-TRACE_EVENT(lock_contended,
+DEFINE_EVENT(lock, lock_release,
 
         TP_PROTO(struct lockdep_map *lock, unsigned long ip),
 
-        TP_ARGS(lock, ip),
+        TP_ARGS(lock, ip)
+);
 
-        TP_STRUCT__entry(
-                __string(name, lock->name)
-                __field(void *, lockdep_addr)
-        ),
+#ifdef CONFIG_LOCK_STAT
 
-        TP_fast_assign(
-                __assign_str(name, lock->name);
-                __entry->lockdep_addr = lock;
-        ),
+DEFINE_EVENT(lock, lock_contended,
 
-        TP_printk("%p %s",
-                  __entry->lockdep_addr, __get_str(name))
-);
+        TP_PROTO(struct lockdep_map *lock, unsigned long ip),
 
-TRACE_EVENT(lock_acquired,
-        TP_PROTO(struct lockdep_map *lock, unsigned long ip, s64 waittime),
+        TP_ARGS(lock, ip)
+);
 
-        TP_ARGS(lock, ip, waittime),
+DEFINE_EVENT(lock, lock_acquired,
 
-        TP_STRUCT__entry(
-                __string(name, lock->name)
-                __field(s64, wait_nsec)
-                __field(void *, lockdep_addr)
-        ),
+        TP_PROTO(struct lockdep_map *lock, unsigned long ip),
 
-        TP_fast_assign(
-                __assign_str(name, lock->name);
-                __entry->wait_nsec = waittime;
-                __entry->lockdep_addr = lock;
-        ),
-        TP_printk("%p %s (%llu ns)", __entry->lockdep_addr,
-                  __get_str(name),
-                  __entry->wait_nsec)
+        TP_ARGS(lock, ip)
 );
 
 #endif
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 2594e1ce41cb..e9c759f06c1d 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3227,7 +3227,7 @@ void lock_release(struct lockdep_map *lock, int nested,
         raw_local_irq_save(flags);
         check_flags(flags);
         current->lockdep_recursion = 1;
-        trace_lock_release(lock, nested, ip);
+        trace_lock_release(lock, ip);
         __lock_release(lock, nested, ip);
         current->lockdep_recursion = 0;
         raw_local_irq_restore(flags);
@@ -3380,7 +3380,7 @@ found_it:
                 hlock->holdtime_stamp = now;
         }
 
-        trace_lock_acquired(lock, ip, waittime);
+        trace_lock_acquired(lock, ip);
 
         stats = get_lock_stats(hlock_class(hlock));
         if (waittime) {
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 6605000ed73d..e18dfdc2948a 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -387,7 +387,20 @@ static struct lock_seq_stat *get_seq(struct thread_stat *ts, void *addr)
         return seq;
 }
 
-static int bad_hist[4];
+enum broken_state {
+        BROKEN_ACQUIRE,
+        BROKEN_ACQUIRED,
+        BROKEN_CONTENDED,
+        BROKEN_RELEASE,
+        BROKEN_MAX,
+};
+
+static int bad_hist[BROKEN_MAX];
+
+enum acquire_flags {
+        TRY_LOCK = 1,
+        READ_LOCK = 2,
+};
 
 static void
 report_lock_acquire_event(struct trace_acquire_event *acquire_event,
@@ -413,9 +426,9 @@ report_lock_acquire_event(struct trace_acquire_event *acquire_event,
                 if (!acquire_event->flag) {
                         seq->state = SEQ_STATE_ACQUIRING;
                 } else {
-                        if (acquire_event->flag & 1)
+                        if (acquire_event->flag & TRY_LOCK)
                                 ls->nr_trylock++;
-                        if (acquire_event->flag & 2)
+                        if (acquire_event->flag & READ_LOCK)
                                 ls->nr_readlock++;
                         seq->state = SEQ_STATE_READ_ACQUIRED;
                         seq->read_count = 1;
@@ -423,7 +436,7 @@ report_lock_acquire_event(struct trace_acquire_event *acquire_event,
                 }
                 break;
         case SEQ_STATE_READ_ACQUIRED:
-                if (acquire_event->flag & 2) {
+                if (acquire_event->flag & READ_LOCK) {
                         seq->read_count++;
                         ls->nr_acquired++;
                         goto end;
@@ -437,7 +450,7 @@ report_lock_acquire_event(struct trace_acquire_event *acquire_event,
 broken:
                 /* broken lock sequence, discard it */
                 ls->discard = 1;
-                bad_hist[0]++;
+                bad_hist[BROKEN_ACQUIRE]++;
                 list_del(&seq->list);
                 free(seq);
                 goto end;
@@ -481,10 +494,9 @@ report_lock_acquired_event(struct trace_acquired_event *acquired_event,
         case SEQ_STATE_CONTENDED:
                 contended_term = timestamp - seq->prev_event_time;