aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNishanth Menon <nm@ti.com>2013-04-16 17:45:16 -0400
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-04-17 09:58:17 -0400
commit1e4b545cdd93318379c6b1fb0a99536fa3260f53 (patch)
treeff314a75ecf106aef718f1160d2dd9064ca7ebb9
parent0f7b87f0acc04e4f22ec5d3f2283a80993ca3aa8 (diff)
regulator: core: return err value for regulator_get if there is no DT binding
commit 6d191a5fc7a969d972f1681e1c23781aecb06a61 (regulator: core: Don't defer probe if there's no DT binding for a supply) Attempted to differentiate between regulator_get() with an actual DT binding for the supply and when there is none to avoid unnecessary deferal. However, ret value supplied by regulator_dev_lookup() is being ignored by regulator_get(). So, exit with the appropriate return value. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--drivers/regulator/core.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a51e1e5fdff3..73edb0ef6e17 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1229,7 +1229,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
1229 struct regulator_dev *rdev; 1229 struct regulator_dev *rdev;
1230 struct regulator *regulator = ERR_PTR(-EPROBE_DEFER); 1230 struct regulator *regulator = ERR_PTR(-EPROBE_DEFER);
1231 const char *devname = NULL; 1231 const char *devname = NULL;
1232 int ret; 1232 int ret = 0;
1233 1233
1234 if (id == NULL) { 1234 if (id == NULL) {
1235 pr_err("get() with no identifier\n"); 1235 pr_err("get() with no identifier\n");
@@ -1245,6 +1245,15 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
1245 if (rdev) 1245 if (rdev)
1246 goto found; 1246 goto found;
1247 1247
1248 /*
1249 * If we have return value from dev_lookup fail, we do not expect to
1250 * succeed, so, quit with appropriate error value
1251 */
1252 if (ret) {
1253 regulator = ERR_PTR(ret);
1254 goto out;
1255 }
1256
1248 if (board_wants_dummy_regulator) { 1257 if (board_wants_dummy_regulator) {
1249 rdev = dummy_regulator_rdev; 1258 rdev = dummy_regulator_rdev;
1250 goto found; 1259 goto found;