diff options
| author | Fabian Frederick <fabf@skynet.be> | 2014-08-08 17:22:29 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-08 18:57:24 -0400 |
| commit | 1da85fdff55da539fbe9c270689a7bcedead1cdd (patch) | |
| tree | 686e8a702f783c63e1fad91635954b1bce22b90e | |
| parent | 19bdd41a57e1418b8661148125e9b6d99f468c1b (diff) | |
fs/bfs: use bfs prefix for dump_imap
All bfs related functions use bfs_ prefix. This patch also moves extern
declaration to bfs.h and removes prototype from inode.c
This fixes checkpatch warning:
WARNING: externs should be avoided in .c files
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: "Tigran A. Aivazian" <tigran@aivazian.fsnet.co.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/bfs/bfs.h | 1 | ||||
| -rw-r--r-- | fs/bfs/dir.c | 4 | ||||
| -rw-r--r-- | fs/bfs/inode.c | 8 |
3 files changed, 5 insertions, 8 deletions
diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h index f7f87e233dd9..f40006db36df 100644 --- a/fs/bfs/bfs.h +++ b/fs/bfs/bfs.h | |||
| @@ -46,6 +46,7 @@ static inline struct bfs_inode_info *BFS_I(struct inode *inode) | |||
| 46 | 46 | ||
| 47 | /* inode.c */ | 47 | /* inode.c */ |
| 48 | extern struct inode *bfs_iget(struct super_block *sb, unsigned long ino); | 48 | extern struct inode *bfs_iget(struct super_block *sb, unsigned long ino); |
| 49 | extern void bfs_dump_imap(const char *, struct super_block *); | ||
| 49 | 50 | ||
| 50 | /* file.c */ | 51 | /* file.c */ |
| 51 | extern const struct inode_operations bfs_file_inops; | 52 | extern const struct inode_operations bfs_file_inops; |
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index a399e6d9dc74..08063ae0a17c 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c | |||
| @@ -75,8 +75,6 @@ const struct file_operations bfs_dir_operations = { | |||
| 75 | .llseek = generic_file_llseek, | 75 | .llseek = generic_file_llseek, |
| 76 | }; | 76 | }; |
| 77 | 77 | ||
| 78 | extern void dump_imap(const char *, struct super_block *); | ||
| 79 | |||
| 80 | static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | 78 | static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, |
| 81 | bool excl) | 79 | bool excl) |
| 82 | { | 80 | { |
| @@ -110,7 +108,7 @@ static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, | |||
| 110 | BFS_I(inode)->i_eblock = 0; | 108 | BFS_I(inode)->i_eblock = 0; |
| 111 | insert_inode_hash(inode); | 109 | insert_inode_hash(inode); |
| 112 | mark_inode_dirty(inode); | 110 | mark_inode_dirty(inode); |
| 113 | dump_imap("create", s); | 111 | bfs_dump_imap("create", s); |
| 114 | 112 | ||
| 115 | err = bfs_add_entry(dir, dentry->d_name.name, dentry->d_name.len, | 113 | err = bfs_add_entry(dir, dentry->d_name.name, dentry->d_name.len, |
| 116 | inode->i_ino); | 114 | inode->i_ino); |
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 7041ac35ace8..90bc079d9982 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
| @@ -30,8 +30,6 @@ MODULE_LICENSE("GPL"); | |||
| 30 | #define dprintf(x...) | 30 | #define dprintf(x...) |
| 31 | #endif | 31 | #endif |
| 32 | 32 | ||
| 33 | void dump_imap(const char *prefix, struct super_block *s); | ||
| 34 | |||
| 35 | struct inode *bfs_iget(struct super_block *sb, unsigned long ino) | 33 | struct inode *bfs_iget(struct super_block *sb, unsigned long ino) |
| 36 | { | 34 | { |
| 37 | struct bfs_inode *di; | 35 | struct bfs_inode *di; |
| @@ -194,7 +192,7 @@ static void bfs_evict_inode(struct inode *inode) | |||
| 194 | info->si_freeb += bi->i_eblock + 1 - bi->i_sblock; | 192 | info->si_freeb += bi->i_eblock + 1 - bi->i_sblock; |
| 195 | info->si_freei++; | 193 | info->si_freei++; |
| 196 | clear_bit(ino, info->si_imap); | 194 | clear_bit(ino, info->si_imap); |
| 197 | dump_imap("delete_inode", s); | 195 | bfs_dump_imap("delete_inode", s); |
| 198 | } | 196 | } |
| 199 | 197 | ||
| 200 | /* | 198 | /* |
| @@ -297,7 +295,7 @@ static const struct super_operations bfs_sops = { | |||
| 297 | .statfs = bfs_statfs, | 295 | .statfs = bfs_statfs, |
| 298 | }; | 296 | }; |
| 299 | 297 | ||
| 300 | void dump_imap(const char *prefix, struct super_block *s) | 298 | void bfs_dump_imap(const char *prefix, struct super_block *s) |
| 301 | { | 299 | { |
| 302 | #ifdef DEBUG | 300 | #ifdef DEBUG |
| 303 | int i; | 301 | int i; |
| @@ -443,7 +441,7 @@ static int bfs_fill_super(struct super_block *s, void *data, int silent) | |||
| 443 | } | 441 | } |
| 444 | brelse(bh); | 442 | brelse(bh); |
| 445 | brelse(sbh); | 443 | brelse(sbh); |
| 446 | dump_imap("read_super", s); | 444 | bfs_dump_imap("read_super", s); |
| 447 | return 0; | 445 | return 0; |
| 448 | 446 | ||
| 449 | out3: | 447 | out3: |
