diff options
| author | Tao Ma <tao.ma@oracle.com> | 2010-11-13 03:22:02 -0500 |
|---|---|---|
| committer | Joel Becker <joel.becker@oracle.com> | 2010-11-13 06:15:08 -0500 |
| commit | 1c66b360fe26204e2aa14e45086b4a6b8890b1a2 (patch) | |
| tree | d2608809e0985e4aff7bdc9f5673a8c39d7eb916 | |
| parent | 2d3b07c07b39c4b7d9b6641052a02d996cd5d87c (diff) | |
ocfs2: Change some lock status member in ocfs2_lock_res to char.
Commit 83fd9c7 changes l_level, l_requested and l_blocking of
ocfs2_lock_res from int to unsigned char. But actually it is
initially as -1(ocfs2_lock_res_init_common) which
correspoding to 255 for unsigned char. So the whole dlm lock
mechanism doesn't work now which means a disaster to ocfs2.
Cc: Goldwyn Rodrigues <rgoldwyn@suse.de>
Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
| -rw-r--r-- | fs/ocfs2/ocfs2.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h index d8408217e3bd..1efea3615589 100644 --- a/fs/ocfs2/ocfs2.h +++ b/fs/ocfs2/ocfs2.h | |||
| @@ -159,7 +159,9 @@ struct ocfs2_lock_res { | |||
| 159 | char l_name[OCFS2_LOCK_ID_MAX_LEN]; | 159 | char l_name[OCFS2_LOCK_ID_MAX_LEN]; |
| 160 | unsigned int l_ro_holders; | 160 | unsigned int l_ro_holders; |
| 161 | unsigned int l_ex_holders; | 161 | unsigned int l_ex_holders; |
| 162 | unsigned char l_level; | 162 | char l_level; |
| 163 | char l_requested; | ||
| 164 | char l_blocking; | ||
| 163 | 165 | ||
| 164 | /* Data packed - type enum ocfs2_lock_type */ | 166 | /* Data packed - type enum ocfs2_lock_type */ |
| 165 | unsigned char l_type; | 167 | unsigned char l_type; |
| @@ -169,8 +171,6 @@ struct ocfs2_lock_res { | |||
| 169 | unsigned char l_action; | 171 | unsigned char l_action; |
| 170 | /* Data packed - enum type ocfs2_unlock_action */ | 172 | /* Data packed - enum type ocfs2_unlock_action */ |
| 171 | unsigned char l_unlock_action; | 173 | unsigned char l_unlock_action; |
| 172 | unsigned char l_requested; | ||
| 173 | unsigned char l_blocking; | ||
| 174 | unsigned int l_pending_gen; | 174 | unsigned int l_pending_gen; |
| 175 | 175 | ||
| 176 | spinlock_t l_lock; | 176 | spinlock_t l_lock; |
