diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-01-14 11:21:50 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-02-21 09:27:04 -0500 |
commit | 1c3d038bd5fb9dc868bb7474caaddc7aea4d562e (patch) | |
tree | ec853560944959c1ac0ff9a7bd4ed89a3fd4e4af | |
parent | a7670151a48cc54fafd8f1b4f04a1495c2f8b6f0 (diff) |
PCMCIA: soc_common: remove explicit wrprot initialization in socket drivers
soc_common already initializes state.wrprot to zero, so explicitly
setting wrprot to zero in the socket drivers has no additional effect.
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r-- | drivers/pcmcia/pxa2xx_balloon3.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_cm_x255.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_cm_x270.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_colibri.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_e740.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_mainstone.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_palmld.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_palmtc.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_palmtx.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_stargate2.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_trizeps4.c | 2 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_viper.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/pxa2xx_vpac270.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/sa1100_assabet.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/sa1100_cerf.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/sa1100_h3600.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/sa1100_nanoengine.c | 1 | ||||
-rw-r--r-- | drivers/pcmcia/sa1100_shannon.c | 2 | ||||
-rw-r--r-- | drivers/pcmcia/sa1100_simpad.c | 1 |
19 files changed, 0 insertions, 21 deletions
diff --git a/drivers/pcmcia/pxa2xx_balloon3.c b/drivers/pcmcia/pxa2xx_balloon3.c index 12e38b497719..2ef576c5b69d 100644 --- a/drivers/pcmcia/pxa2xx_balloon3.c +++ b/drivers/pcmcia/pxa2xx_balloon3.c | |||
@@ -81,7 +81,6 @@ static void balloon3_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
81 | state->bvd2 = 0; /* not available */ | 81 | state->bvd2 = 0; /* not available */ |
82 | state->vs_3v = 1; /* Always true its a CF card */ | 82 | state->vs_3v = 1; /* Always true its a CF card */ |
83 | state->vs_Xv = 0; /* not available */ | 83 | state->vs_Xv = 0; /* not available */ |
84 | state->wrprot = 0; /* not available */ | ||
85 | } | 84 | } |
86 | 85 | ||
87 | static int balloon3_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, | 86 | static int balloon3_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, |
diff --git a/drivers/pcmcia/pxa2xx_cm_x255.c b/drivers/pcmcia/pxa2xx_cm_x255.c index f90e7b1a5958..da40908b29dd 100644 --- a/drivers/pcmcia/pxa2xx_cm_x255.c +++ b/drivers/pcmcia/pxa2xx_cm_x255.c | |||
@@ -58,7 +58,6 @@ static void cmx255_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
58 | { | 58 | { |
59 | state->vs_3v = 0; | 59 | state->vs_3v = 0; |
60 | state->vs_Xv = 0; | 60 | state->vs_Xv = 0; |
61 | state->wrprot = 0; /* not available */ | ||
62 | } | 61 | } |
63 | 62 | ||
64 | 63 | ||
diff --git a/drivers/pcmcia/pxa2xx_cm_x270.c b/drivers/pcmcia/pxa2xx_cm_x270.c index efb5f132851b..f59223f2307d 100644 --- a/drivers/pcmcia/pxa2xx_cm_x270.c +++ b/drivers/pcmcia/pxa2xx_cm_x270.c | |||
@@ -48,7 +48,6 @@ static void cmx270_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
48 | { | 48 | { |
49 | state->vs_3v = 0; | 49 | state->vs_3v = 0; |
50 | state->vs_Xv = 0; | 50 | state->vs_Xv = 0; |
51 | state->wrprot = 0; /* not available */ | ||
52 | } | 51 | } |
53 | 52 | ||
54 | 53 | ||
diff --git a/drivers/pcmcia/pxa2xx_colibri.c b/drivers/pcmcia/pxa2xx_colibri.c index 3565169a00f2..4dee7b2a8032 100644 --- a/drivers/pcmcia/pxa2xx_colibri.c +++ b/drivers/pcmcia/pxa2xx_colibri.c | |||
@@ -84,7 +84,6 @@ static void colibri_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
84 | state->ready = !!gpio_get_value(colibri_pcmcia_gpios[READY].gpio); | 84 | state->ready = !!gpio_get_value(colibri_pcmcia_gpios[READY].gpio); |
85 | state->bvd1 = !!gpio_get_value(colibri_pcmcia_gpios[BVD1].gpio); | 85 | state->bvd1 = !!gpio_get_value(colibri_pcmcia_gpios[BVD1].gpio); |
86 | state->bvd2 = !!gpio_get_value(colibri_pcmcia_gpios[BVD2].gpio); | 86 | state->bvd2 = !!gpio_get_value(colibri_pcmcia_gpios[BVD2].gpio); |
87 | state->wrprot = 0; | ||
88 | state->vs_3v = 1; | 87 | state->vs_3v = 1; |
89 | state->vs_Xv = 0; | 88 | state->vs_Xv = 0; |
90 | } | 89 | } |
diff --git a/drivers/pcmcia/pxa2xx_e740.c b/drivers/pcmcia/pxa2xx_e740.c index 24e00a503d08..8751a323b448 100644 --- a/drivers/pcmcia/pxa2xx_e740.c +++ b/drivers/pcmcia/pxa2xx_e740.c | |||
@@ -44,7 +44,6 @@ static void e740_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
44 | struct pcmcia_state *state) | 44 | struct pcmcia_state *state) |
45 | { | 45 | { |
46 | state->vs_3v = 1; | 46 | state->vs_3v = 1; |
47 | state->wrprot = 0; | ||
48 | state->vs_Xv = 0; | 47 | state->vs_Xv = 0; |
49 | } | 48 | } |
50 | 49 | ||
diff --git a/drivers/pcmcia/pxa2xx_mainstone.c b/drivers/pcmcia/pxa2xx_mainstone.c index b0ea4d3f8a1c..7e32e25cdcb2 100644 --- a/drivers/pcmcia/pxa2xx_mainstone.c +++ b/drivers/pcmcia/pxa2xx_mainstone.c | |||
@@ -83,7 +83,6 @@ static void mst_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
83 | state->bvd2 = (status & MST_PCMCIA_nSPKR_BVD2) ? 1 : 0; | 83 | state->bvd2 = (status & MST_PCMCIA_nSPKR_BVD2) ? 1 : 0; |
84 | state->vs_3v = (status & MST_PCMCIA_nVS1) ? 0 : 1; | 84 | state->vs_3v = (status & MST_PCMCIA_nVS1) ? 0 : 1; |
85 | state->vs_Xv = (status & MST_PCMCIA_nVS2) ? 0 : 1; | 85 | state->vs_Xv = (status & MST_PCMCIA_nVS2) ? 0 : 1; |
86 | state->wrprot = 0; /* not available */ | ||
87 | } | 86 | } |
88 | 87 | ||
89 | static int mst_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, | 88 | static int mst_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, |
diff --git a/drivers/pcmcia/pxa2xx_palmld.c b/drivers/pcmcia/pxa2xx_palmld.c index 4bf68144c365..ed7d4dbc39fa 100644 --- a/drivers/pcmcia/pxa2xx_palmld.c +++ b/drivers/pcmcia/pxa2xx_palmld.c | |||
@@ -47,7 +47,6 @@ static void palmld_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
47 | struct pcmcia_state *state) | 47 | struct pcmcia_state *state) |
48 | { | 48 | { |
49 | state->detect = 1; /* always inserted */ | 49 | state->detect = 1; /* always inserted */ |
50 | state->wrprot = 0; | ||
51 | state->vs_3v = 1; | 50 | state->vs_3v = 1; |
52 | state->vs_Xv = 0; | 51 | state->vs_Xv = 0; |
53 | } | 52 | } |
diff --git a/drivers/pcmcia/pxa2xx_palmtc.c b/drivers/pcmcia/pxa2xx_palmtc.c index b32d05f86789..81225a7a8cbb 100644 --- a/drivers/pcmcia/pxa2xx_palmtc.c +++ b/drivers/pcmcia/pxa2xx_palmtc.c | |||
@@ -51,7 +51,6 @@ static void palmtc_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
51 | struct pcmcia_state *state) | 51 | struct pcmcia_state *state) |
52 | { | 52 | { |
53 | state->detect = 1; /* always inserted */ | 53 | state->detect = 1; /* always inserted */ |
54 | state->wrprot = 0; | ||
55 | state->vs_3v = 1; | 54 | state->vs_3v = 1; |
56 | state->vs_Xv = 0; | 55 | state->vs_Xv = 0; |
57 | } | 56 | } |
diff --git a/drivers/pcmcia/pxa2xx_palmtx.c b/drivers/pcmcia/pxa2xx_palmtx.c index ee024ff0980a..069b6bbcf319 100644 --- a/drivers/pcmcia/pxa2xx_palmtx.c +++ b/drivers/pcmcia/pxa2xx_palmtx.c | |||
@@ -47,7 +47,6 @@ static void palmtx_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
47 | struct pcmcia_state *state) | 47 | struct pcmcia_state *state) |
48 | { | 48 | { |
49 | state->detect = 1; /* always inserted */ | 49 | state->detect = 1; /* always inserted */ |
50 | state->wrprot = 0; | ||
51 | state->vs_3v = 1; | 50 | state->vs_3v = 1; |
52 | state->vs_Xv = 0; | 51 | state->vs_Xv = 0; |
53 | } | 52 | } |
diff --git a/drivers/pcmcia/pxa2xx_stargate2.c b/drivers/pcmcia/pxa2xx_stargate2.c index e7c7eb530cb1..1d73c4401fdd 100644 --- a/drivers/pcmcia/pxa2xx_stargate2.c +++ b/drivers/pcmcia/pxa2xx_stargate2.c | |||
@@ -54,7 +54,6 @@ static void sg2_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
54 | state->bvd2 = 0; /* not available */ | 54 | state->bvd2 = 0; /* not available */ |
55 | state->vs_3v = 1; /* not available - voltage detect for card */ | 55 | state->vs_3v = 1; /* not available - voltage detect for card */ |
56 | state->vs_Xv = 0; /* not available */ | 56 | state->vs_Xv = 0; /* not available */ |
57 | state->wrprot = 0; /* not available - write protect */ | ||
58 | } | 57 | } |
59 | 58 | ||
60 | static int sg2_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, | 59 | static int sg2_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, |
diff --git a/drivers/pcmcia/pxa2xx_trizeps4.c b/drivers/pcmcia/pxa2xx_trizeps4.c index 31fd93449913..d326ba1fa1ce 100644 --- a/drivers/pcmcia/pxa2xx_trizeps4.c +++ b/drivers/pcmcia/pxa2xx_trizeps4.c | |||
@@ -75,7 +75,6 @@ static void trizeps_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
75 | state->bvd2 = (status & ConXS_CFSR_BVD2) ? 1 : 0; | 75 | state->bvd2 = (status & ConXS_CFSR_BVD2) ? 1 : 0; |
76 | state->vs_3v = (status & ConXS_CFSR_VS1) ? 0 : 1; | 76 | state->vs_3v = (status & ConXS_CFSR_VS1) ? 0 : 1; |
77 | state->vs_Xv = (status & ConXS_CFSR_VS2) ? 0 : 1; | 77 | state->vs_Xv = (status & ConXS_CFSR_VS2) ? 0 : 1; |
78 | state->wrprot = 0; /* not available */ | ||
79 | break; | 78 | break; |
80 | 79 | ||
81 | #ifndef CONFIG_MACH_TRIZEPS_CONXS | 80 | #ifndef CONFIG_MACH_TRIZEPS_CONXS |
@@ -87,7 +86,6 @@ static void trizeps_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
87 | state->bvd2 = 0; | 86 | state->bvd2 = 0; |
88 | state->vs_3v = 0; | 87 | state->vs_3v = 0; |
89 | state->vs_Xv = 0; | 88 | state->vs_Xv = 0; |
90 | state->wrprot = 0; | ||
91 | break; | 89 | break; |
92 | 90 | ||
93 | #endif | 91 | #endif |
diff --git a/drivers/pcmcia/pxa2xx_viper.c b/drivers/pcmcia/pxa2xx_viper.c index 6100ef8ce53e..adfae4987a42 100644 --- a/drivers/pcmcia/pxa2xx_viper.c +++ b/drivers/pcmcia/pxa2xx_viper.c | |||
@@ -81,7 +81,6 @@ static void viper_pcmcia_hw_shutdown(struct soc_pcmcia_socket *skt) | |||
81 | static void viper_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | 81 | static void viper_pcmcia_socket_state(struct soc_pcmcia_socket *skt, |
82 | struct pcmcia_state *state) | 82 | struct pcmcia_state *state) |
83 | { | 83 | { |
84 | state->wrprot = 0; | ||
85 | state->vs_3v = 1; /* Can only apply 3.3V */ | 84 | state->vs_3v = 1; /* Can only apply 3.3V */ |
86 | state->vs_Xv = 0; | 85 | state->vs_Xv = 0; |
87 | } | 86 | } |
diff --git a/drivers/pcmcia/pxa2xx_vpac270.c b/drivers/pcmcia/pxa2xx_vpac270.c index cf07d8825513..a47dcd24a26a 100644 --- a/drivers/pcmcia/pxa2xx_vpac270.c +++ b/drivers/pcmcia/pxa2xx_vpac270.c | |||
@@ -69,7 +69,6 @@ static void vpac270_pcmcia_hw_shutdown(struct soc_pcmcia_socket *skt) | |||
69 | static void vpac270_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | 69 | static void vpac270_pcmcia_socket_state(struct soc_pcmcia_socket *skt, |
70 | struct pcmcia_state *state) | 70 | struct pcmcia_state *state) |
71 | { | 71 | { |
72 | state->wrprot = 0; | ||
73 | state->vs_3v = 1; | 72 | state->vs_3v = 1; |
74 | state->vs_Xv = 0; | 73 | state->vs_Xv = 0; |
75 | } | 74 | } |
diff --git a/drivers/pcmcia/sa1100_assabet.c b/drivers/pcmcia/sa1100_assabet.c index 618f546e19c1..ba8557eea618 100644 --- a/drivers/pcmcia/sa1100_assabet.c +++ b/drivers/pcmcia/sa1100_assabet.c | |||
@@ -34,7 +34,6 @@ static int assabet_pcmcia_hw_init(struct soc_pcmcia_socket *skt) | |||
34 | static void | 34 | static void |
35 | assabet_pcmcia_socket_state(struct soc_pcmcia_socket *skt, struct pcmcia_state *state) | 35 | assabet_pcmcia_socket_state(struct soc_pcmcia_socket *skt, struct pcmcia_state *state) |
36 | { | 36 | { |
37 | state->wrprot = 0; /* Not available on Assabet. */ | ||
38 | state->vs_3v = 1; /* Can only apply 3.3V on Assabet. */ | 37 | state->vs_3v = 1; /* Can only apply 3.3V on Assabet. */ |
39 | state->vs_Xv = 0; | 38 | state->vs_Xv = 0; |
40 | } | 39 | } |
diff --git a/drivers/pcmcia/sa1100_cerf.c b/drivers/pcmcia/sa1100_cerf.c index 50df0e682b68..c59c44921a3a 100644 --- a/drivers/pcmcia/sa1100_cerf.c +++ b/drivers/pcmcia/sa1100_cerf.c | |||
@@ -48,7 +48,6 @@ static void cerf_pcmcia_hw_shutdown(struct soc_pcmcia_socket *skt) | |||
48 | static void | 48 | static void |
49 | cerf_pcmcia_socket_state(struct soc_pcmcia_socket *skt, struct pcmcia_state *state) | 49 | cerf_pcmcia_socket_state(struct soc_pcmcia_socket *skt, struct pcmcia_state *state) |
50 | { | 50 | { |
51 | state->wrprot = 0; | ||
52 | state->vs_3v = 1; | 51 | state->vs_3v = 1; |
53 | state->vs_Xv = 0; | 52 | state->vs_Xv = 0; |
54 | } | 53 | } |
diff --git a/drivers/pcmcia/sa1100_h3600.c b/drivers/pcmcia/sa1100_h3600.c index 410a636dbfc8..d9c7337b909c 100644 --- a/drivers/pcmcia/sa1100_h3600.c +++ b/drivers/pcmcia/sa1100_h3600.c | |||
@@ -96,7 +96,6 @@ h3600_pcmcia_socket_state(struct soc_pcmcia_socket *skt, struct pcmcia_state *st | |||
96 | { | 96 | { |
97 | state->bvd1 = 0; | 97 | state->bvd1 = 0; |
98 | state->bvd2 = 0; | 98 | state->bvd2 = 0; |
99 | state->wrprot = 0; /* Not available on H3600. */ | ||
100 | state->vs_3v = 0; | 99 | state->vs_3v = 0; |
101 | state->vs_Xv = 0; | 100 | state->vs_Xv = 0; |
102 | } | 101 | } |
diff --git a/drivers/pcmcia/sa1100_nanoengine.c b/drivers/pcmcia/sa1100_nanoengine.c index cb43e39aef3f..35c30ff41e81 100644 --- a/drivers/pcmcia/sa1100_nanoengine.c +++ b/drivers/pcmcia/sa1100_nanoengine.c | |||
@@ -106,7 +106,6 @@ static void nanoengine_pcmcia_socket_state( | |||
106 | 106 | ||
107 | state->bvd1 = 1; | 107 | state->bvd1 = 1; |
108 | state->bvd2 = 1; | 108 | state->bvd2 = 1; |
109 | state->wrprot = 0; /* Not available */ | ||
110 | state->vs_3v = 1; /* Can only apply 3.3V */ | 109 | state->vs_3v = 1; /* Can only apply 3.3V */ |
111 | state->vs_Xv = 0; | 110 | state->vs_Xv = 0; |
112 | } | 111 | } |
diff --git a/drivers/pcmcia/sa1100_shannon.c b/drivers/pcmcia/sa1100_shannon.c index 7552d8591a29..decb34730bcf 100644 --- a/drivers/pcmcia/sa1100_shannon.c +++ b/drivers/pcmcia/sa1100_shannon.c | |||
@@ -44,7 +44,6 @@ shannon_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
44 | { | 44 | { |
45 | switch (skt->nr) { | 45 | switch (skt->nr) { |
46 | case 0: | 46 | case 0: |
47 | state->wrprot = 0; /* Not available on Shannon. */ | ||
48 | state->bvd1 = 1; | 47 | state->bvd1 = 1; |
49 | state->bvd2 = 1; | 48 | state->bvd2 = 1; |
50 | state->vs_3v = 1; /* FIXME Can only apply 3.3V on Shannon. */ | 49 | state->vs_3v = 1; /* FIXME Can only apply 3.3V on Shannon. */ |
@@ -52,7 +51,6 @@ shannon_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
52 | break; | 51 | break; |
53 | 52 | ||
54 | case 1: | 53 | case 1: |
55 | state->wrprot = 0; /* Not available on Shannon. */ | ||
56 | state->bvd1 = 1; | 54 | state->bvd1 = 1; |
57 | state->bvd2 = 1; | 55 | state->bvd2 = 1; |
58 | state->vs_3v = 1; /* FIXME Can only apply 3.3V on Shannon. */ | 56 | state->vs_3v = 1; /* FIXME Can only apply 3.3V on Shannon. */ |
diff --git a/drivers/pcmcia/sa1100_simpad.c b/drivers/pcmcia/sa1100_simpad.c index 39d2241b9d80..8647b17c449e 100644 --- a/drivers/pcmcia/sa1100_simpad.c +++ b/drivers/pcmcia/sa1100_simpad.c | |||
@@ -46,7 +46,6 @@ simpad_pcmcia_socket_state(struct soc_pcmcia_socket *skt, | |||
46 | 46 | ||
47 | state->bvd1 = 1; /* Might be cs3reg & PCMCIA_BVD1 */ | 47 | state->bvd1 = 1; /* Might be cs3reg & PCMCIA_BVD1 */ |
48 | state->bvd2 = 1; /* Might be cs3reg & PCMCIA_BVD2 */ | 48 | state->bvd2 = 1; /* Might be cs3reg & PCMCIA_BVD2 */ |
49 | state->wrprot=0; /* Not available on Simpad. */ | ||
50 | 49 | ||
51 | if ((cs3reg & (PCMCIA_VS1|PCMCIA_VS2)) == | 50 | if ((cs3reg & (PCMCIA_VS1|PCMCIA_VS2)) == |
52 | (PCMCIA_VS1|PCMCIA_VS2)) { | 51 | (PCMCIA_VS1|PCMCIA_VS2)) { |